From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.85.221.67, mailfrom: philmd@redhat.com)
Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67])
 by groups.io with SMTP; Fri, 19 Jul 2019 10:09:58 -0700
Received: by mail-wr1-f67.google.com with SMTP id z1so32930085wru.13
        for <devel@edk2.groups.io>; Fri, 19 Jul 2019 10:09:57 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id
         :date:user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=HPsv+jW3ptWf+qbGfJCYI2pFGAR+ZBU29+SyAvV+hI0=;
        b=QIAxw4MFxxv+y9IhY+TImP/EWIF1QcjeSlR+yQURRlBZFqQVaY124D38aBtlxFe1GZ
         tVkk8NcrdxzVmsj0HTHUwg8BoyKOSngHRb9xPO5MbJrztQqYqXk9h0AjEFWgmqP2nNk9
         5WFmRREDCAWCOXYb+DKYv+j0p69R7yXZL+s+73mQ67Wmp8baFzV4Ko8AfOQrJi4ePnGV
         iyV/96DExE4doKGP+X6jsXNZVaP4JueU9MT2AJ3HWR4URWOzxjNZph+VZSH6BR3wK92X
         ySmv1rcoSgKKNErQLZBxcG8grSr8hz3AVljFl6aF/AEFqt7MBanM/LGNjX2IogZuftAu
         hfNQ==
X-Gm-Message-State: APjAAAX8f/sBtMnU7SRFVi9QkBjTENwbSkUnXsCdIw/SdoU8K1EkOJPJ
	zZY+S3eyUwTYJWwIToJjwN8oaw==
X-Google-Smtp-Source: APXvYqxCdpa7jf5wChP6NTjuiCur8Y1oYlXW4wAi1ze84A0zotBJ1pwRZi/4wBtkb4QYTJJRjUshuw==
X-Received: by 2002:adf:e50b:: with SMTP id j11mr20950761wrm.351.1563556196391;
        Fri, 19 Jul 2019 10:09:56 -0700 (PDT)
Return-Path: <philmd@redhat.com>
Received: from [192.168.1.37] (62.red-83-42-61.dynamicip.rima-tde.net. [83.42.61.62])
        by smtp.gmail.com with ESMTPSA id z7sm27542733wrh.67.2019.07.19.10.09.55
        (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128);
        Fri, 19 Jul 2019 10:09:55 -0700 (PDT)
Subject: Re: [edk2-devel] [PATCH 3/4] CryptoPkg/BaseCryptLib: list module-internal header files in INF [Sources]
To: devel@edk2.groups.io, lersek@redhat.com
Cc: Jian Wang <jian.j.wang@intel.com>, Ting Ye <ting.ye@intel.com>
References: <20190719164319.9070-1-lersek@redhat.com>
 <20190719164319.9070-4-lersek@redhat.com>
From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= <philmd@redhat.com>
Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE;
 url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE
Message-ID: <41c344e9-0bd4-40e9-1668-754e4d15a94c@redhat.com>
Date: Fri, 19 Jul 2019 19:09:55 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <20190719164319.9070-4-lersek@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 7/19/19 6:43 PM, Laszlo Ersek wrote:
> The BaseTools build feature introduced for TianoCore#1804 / in commit
> 1fa6699e6cd4 ("BaseTools: Add a checking for Sources section in INF file",
> 2019-06-10) logs some (non-fatal) warnings about unlisted internal header
> files. List those files explicitly.
> 
> Note: header files are added in lexicographical order only if the
> underlying INF file already keeps the [Sources] and [LibraryClasses]
> sections in lexicographical order. Otherwise, header files are added in
> rough "logical" order.
> 
> Cc: Jian Wang <jian.j.wang@intel.com>
> Cc: Ting Ye <ting.ye@intel.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

> ---
>  CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf     | 1 +
>  CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 1 +
>  CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf     | 1 +
>  3 files changed, 3 insertions(+)
> 
> diff --git a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
> index 4c4353747622..99dbad23ed5d 100644
> --- a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
> +++ b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
> @@ -34,6 +34,7 @@ [Defines]
>  #
>  
>  [Sources]
> +  InternalCryptLib.h
>    Hash/CryptMd4Null.c
>    Hash/CryptMd5.c
>    Hash/CryptSha1.c
> diff --git a/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf b/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
> index a59079d99e05..0e58d2b5b0ea 100644
> --- a/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
> +++ b/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
> @@ -33,6 +33,7 @@ [Defines]
>  #
>  
>  [Sources]
> +  InternalCryptLib.h
>    Hash/CryptMd4Null.c
>    Hash/CryptMd5.c
>    Hash/CryptSha1.c
> diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> index 3fd7d65abfca..c79f2bf4c6c0 100644
> --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> @@ -33,6 +33,7 @@ [Defines]
>  #
>  
>  [Sources]
> +  InternalCryptLib.h
>    Hash/CryptMd4Null.c
>    Hash/CryptMd5.c
>    Hash/CryptSha1.c
>