From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.56]) by mx.groups.io with SMTP id smtpd.web11.112077.1597935159484104645 for ; Thu, 20 Aug 2020 07:52:39 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b=CpgWX1Go; spf=none, err=SPF record not found (domain: amd.com, ip: 40.107.94.56, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nrnhhfi22nmFBXVnDGUR35gaaURuj9injOf9NNOums70tK5lGGNxom3m/VVNuF4yDuj6F+1q9XDaUi1329/76V1jKUwbUGlSigfGVtJcYka8l+aSsEAyr1WlwoeesCLcCd/hpgIoEP/y07fsID70T7JLl/Rv/UtCQavEvlI62NOjMv5+krltMtQTyuChnvgK/uOWwdbHnPjBZHc7hUTqdwOZUJ/Oa6NFQreB898XyMn1Nvwirdwi4/74wc36mwJJmLrilK/WjubCK9LnlLNyEHMtSLaOTYVzNac3GGiOk/0ZtK4tcV1qelYNAFFjW2Tr9tk9ucWnl3BM1KxHnmRNGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CVqhq7OrKyIUqyoCG2/dZjbXoytmlc8/Z7YdvGGjfNY=; b=Bxlmg98Cbf5MJ0Dvz32LxGsk6XLitSZ8NvWSN8j1T37+P9FsLibZ8Iwvrrcf3W+pk0EU8Rgntzh1YmpPISD/SrYxF2cpR1Uq0Iz3tlsLDc+yyC9QB/zqi2yhLlPdaqAUibZTyd+ZeEG2YOSicHBm8Fk5ZyTMtdaI181AQ72rwMFyIsF5ELTPVgVmVdB5j0IxyRrSMIt3W2sr9LnVnjAAeNdtaukfeDs4k8zZ4mD1sWiqWAUkQzGhjKirmUuIlvuyVBiyhHaOqifzeijEopFqO18LAM6sMP+DanY7Uqw9Tv1+HQ5k8Vy5nDezO8PyUsGyskxXBQPfhOGL+9An6odWCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CVqhq7OrKyIUqyoCG2/dZjbXoytmlc8/Z7YdvGGjfNY=; b=CpgWX1Go58iNCnV66HClCc4cECFT3cnaX/lYMzVMHjpiKnMtolHAP5P5xuEelvscvWwm+4zscTVNd7ErM56Jz2jaRobc9xROykNNgfUErO/sZ9hpNNE2z4KNvF/RIqbv0cvGVOzT3LiRLEEC/vjvXpG6GW/8TEkAslZnnbfpD2M= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=amd.com; Received: from DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) by DM5PR1201MB0220.namprd12.prod.outlook.com (2603:10b6:4:4e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3305.25; Thu, 20 Aug 2020 14:52:38 +0000 Received: from DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::299a:8ed2:23fc:6346]) by DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::299a:8ed2:23fc:6346%3]) with mapi id 15.20.3305.026; Thu, 20 Aug 2020 14:52:37 +0000 Subject: Re: [PATCH 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement variable To: "Gao, Liming" , "devel@edk2.groups.io" Cc: "Dong, Eric" , "Ni, Ray" , Laszlo Ersek , "Kumar, Rahul1" References: <477f5449c898cd96240729105dde26b1fd75baa9.1597756206.git.thomas.lendacky@amd.com> From: "Lendacky, Thomas" Message-ID: <41f06a4b-7aab-85c2-6a88-7564fcc01577@amd.com> Date: Thu, 20 Aug 2020 09:52:35 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: X-ClientProxiedBy: SA9PR10CA0021.namprd10.prod.outlook.com (2603:10b6:806:a7::26) To DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) Return-Path: thomas.lendacky@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from 255.255.255.255 (255.255.255.255) by SA9PR10CA0021.namprd10.prod.outlook.com (2603:10b6:806:a7::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3305.25 via Frontend Transport; Thu, 20 Aug 2020 14:52:37 +0000 X-Originating-IP: [67.79.209.213] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 7c97fb70-c68c-4a14-fda2-08d84518ae2d X-MS-TrafficTypeDiagnostic: DM5PR1201MB0220: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4502; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QO+7N/1YoXNr2ZF6qXZ9fGTWxGeg7lWCMrwVXlHS7L1gIMYhQbwOOMVOr8lD9R4ylhoIvdx0zFHwpntTaUNoVle+OwCLrLN8wFi5+ObThF1MmtL2MRDJmxHSuhsAFEV4FmyP9D2Tuscq1uRN55luRHQvV03p3HMQaWf3bAqutjzUfF93dDrejNqqWLS8t4Sv0wBIBOn/Oe+omP4agcuCLO6/fukIDbnMfxs2A6Np9Ixr3B1wz1X6KcVkhuBKQViMy40pANKLT4kRKhDA/cC9oWBXTpfobHBFP6zaPvnzo11QeCYQPnJFBPIFlUaXFIy6QDua7d42JiNwt6WFAetYLJ+LbWjklMS5pJSk1m/uTjy9+El9vSy/WhIcI5MBUsxmJ6PqmRhIzeohIdlwXbbxgLaIZR+Lzaq/dqMhCDGgLfI3X3v3mptu6fZG8dnUf5+t3clVKLAueHuuymYGX3SUJiFV/tN+dk0Kgb1S6wIUANmA4dd93AIcZPzsP6V1ArYx X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR12MB1355.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(39860400002)(366004)(136003)(396003)(346002)(376002)(478600001)(16576012)(45080400002)(110136005)(316002)(6486002)(186003)(54906003)(36756003)(86362001)(8936002)(66476007)(53546011)(5660300002)(66556008)(31696002)(66946007)(83380400001)(31686004)(956004)(2616005)(966005)(4326008)(8676002)(52116002)(2906002)(26005)(110011004)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: Rjrd6+QDwJ6K1S/Ab6CkItX5YGg4ncw0omhlfhn3vf/z5GpQv0U1NbzvT/5gRxvyGuEAV3/2DYYxnfBgjrAwluNVXL0jqr2D9Jj/uRLpCSTIAMjpFr6dtZDSLZ5bqlHHqUgg1NksNzy1NTPy+or3+ZpGnFFJb6ldx8XPgZaneMZMZxIo+E7DlVKuYtT2Yj6Sd8nISaFW+IYHzpTKFnh8cLJ1WmSf/CsQpg7bsYrSHsaXMQuG7ztCWbymrSB9VsMhWg0a1hyBleQI8vYev68bSPwDevygxIoU4hURpax6jTZskV4A5HXi7RbNaebOynrJG6iHtH24Z8aq/UWDYmJgj16rI/mNUhf7zsp34V+UTGhfzkTW4sf5wwDGQGpXJQyArVFBqgf4F6XsRJZgL3bEzErboWTW1P7V+V4f3324Dk/E0jMlR3A+5wEkoNxNv36PlL79VD7KRHfttP2dy/HqAwIjXpSi9itldFZ8fXGelDifgWWig8oiplAAKrFCoUYLzTaCZSlMb9gInBslP6OenYa9N8JYyCrSeHBozfmqm8tEHLcxZR1AsskJomEaXCLz1/FMQ/w0TZQJAR0iD8so3TV6kzoRjHZgU903HMJZG8j2IWuJTHtPpJL5+ZuvDcNdiNoYWX58tdaKpfAJrr06yQ== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c97fb70-c68c-4a14-fda2-08d84518ae2d X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1355.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2020 14:52:37.8355 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PA88J6hqw2EmBAn/qTN2IaMf016qFv8ErGjfz1SgbsAWR2ccP13mza3lEfG3arBKFg8YO3kYWAr3WRVKZVCndQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0220 Content-Type: text/plain; charset=iso-2022-jp; format=flowed; delsp=yes Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Liming, It didn't feel quite right to keep your Tested-by: and Reviewed-by: for the change in v2 that I'm about to send. So please re-test / re-review. Thanks, Tom On 8/19/20 2:08 AM, Gao, Liming wrote: > Tested-by: Liming Gao > Reviewed-by: Liming Gao > > -----Original Message----- > From: Tom Lendacky > Sent: 2020年8月18日 21:10 > To: devel@edk2.groups.io > Cc: Gao, Liming ; Dong, Eric ; Ni, Ray ; Laszlo Ersek ; Kumar, Rahul1 > Subject: [PATCH 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement variable > > From: Tom Lendacky > > REF: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2901&data=02%7C01%7Cthomas.lendacky%40amd.com%7Cb01af87f70694b578aef08d8440ea50c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637334176971927286&sdata=YSk7vULEekTRnjrd8XamlT1whKE3YkMk4lmh%2BfLf284%3D&reserved=0 > > The DoDecrement variable in ApWakeupFunction () wasn't always being initialized. Update the code to always fully initialize it. > > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Rahul Kumar > Signed-off-by: Tom Lendacky > --- > UefiCpuPkg/Library/MpInitLib/MpLib.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c b/UefiCpuPkg/Library/MpInitLib/MpLib.c > index 90416c81b616..e24bdc64f930 100644 > --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c > +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c > @@ -885,9 +885,7 @@ ApWakeupFunction ( > UINT64 Status; > BOOLEAN DoDecrement; > > - if (CpuMpData->InitFlag == ApInitConfig) { > - DoDecrement = TRUE; > - } > + DoDecrement = (CpuMpData->InitFlag == ApInitConfig) ? TRUE : > + FALSE; > > while (TRUE) { > Msr.GhcbPhysicalAddress = AsmReadMsr64 (MSR_SEV_ES_GHCB); > -- > 2.28.0 >