Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Remove unused print service driver (PrintDxe)

public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed

From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>, devel@edk2.groups.io
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>, Min Xu <min.m.xu@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Remove unused print service driver (PrintDxe)
Date: Wed, 7 Jul 2021 19:50:01 +0200	[thread overview]
Message-ID: <41f6606a-3787-a5ce-6031-6a12191bde2c@redhat.com> (raw)
In-Reply-To: <60dd70d6-313b-28bd-f8ec-a29379ec6bfd@redhat.com>

On 7/6/21 6:02 PM, Laszlo Ersek wrote:
> On 07/06/21 11:53, Philippe Mathieu-Daudé wrote:
>> From: Philippe Mathieu-Daude <philmd@redhat.com>
>>
>> The Print service driver is not used by OVMF, remove it.
>>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Brijesh Singh <brijesh.singh@amd.com>
>> Cc: Erdem Aktas <erdemaktas@google.com>
>> Cc: James Bottomley <jejb@linux.ibm.com>
>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>> Cc: Min Xu <min.m.xu@intel.com>
>> Cc: Tom Lendacky <thomas.lendacky@amd.com>
>> Suggested-by: Laszlo Ersek <lersek@redhat.com>
>> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
>> ---
>>  OvmfPkg/AmdSev/AmdSevX64.dsc | 1 -
>>  OvmfPkg/OvmfPkgIa32.dsc      | 1 -
>>  OvmfPkg/OvmfPkgIa32X64.dsc   | 1 -
>>  OvmfPkg/OvmfPkgX64.dsc       | 1 -
>>  OvmfPkg/AmdSev/AmdSevX64.fdf | 1 -
>>  OvmfPkg/OvmfPkgIa32.fdf      | 1 -
>>  OvmfPkg/OvmfPkgIa32X64.fdf   | 1 -
>>  OvmfPkg/OvmfPkgX64.fdf       | 1 -
>>  8 files changed, 8 deletions(-)
> 
> I think the same applies to all of the DSC/FDF files (basically,
> "platforms") under OvmfPkg -- including Bhyve and Xen.

Sorry I was sitting on an incorrect branch :(

> PrintDxe produces gEfiPrint2ProtocolGuid and gEfiPrint2SProtocolGuid,
> and those are consumed by the following PrintLib instance:
> 
> MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.inf
> 
> However, none of the OVMF DSC files contain such a PrintLib class
> resolution, so none of the OVMF platforms need PrintDxe.

Thanks!

> 
> Thanks,
> Laszlo
> 
>>
>> diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc
>> index 1d487befae08..d1974b4a6873 100644
>> --- a/OvmfPkg/AmdSev/AmdSevX64.dsc
>> +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc
>> @@ -722,7 +722,6 @@ [Components]
>>        DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
>>        PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
>>    }
>> -  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>>    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>>    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>>    MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
>> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
>> index f53efeae7986..dff4b97b37c0 100644
>> --- a/OvmfPkg/OvmfPkgIa32.dsc
>> +++ b/OvmfPkg/OvmfPkgIa32.dsc
>> @@ -816,7 +816,6 @@ [Components]
>>        DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
>>        PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
>>    }
>> -  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>>    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>>    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>>    MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
>> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
>> index b3662e17f256..f3df655c990e 100644
>> --- a/OvmfPkg/OvmfPkgIa32X64.dsc
>> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc
>> @@ -830,7 +830,6 @@ [Components.X64]
>>        DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
>>        PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
>>    }
>> -  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>>    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>>    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>>    MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
>> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
>> index 0a237a905866..dc9a2720f9b2 100644
>> --- a/OvmfPkg/OvmfPkgX64.dsc
>> +++ b/OvmfPkg/OvmfPkgX64.dsc
>> @@ -828,7 +828,6 @@ [Components]
>>        DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
>>        PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
>>    }
>> -  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>>    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>>    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>>    MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
>> diff --git a/OvmfPkg/AmdSev/AmdSevX64.fdf b/OvmfPkg/AmdSev/AmdSevX64.fdf
>> index 9977b0f00a18..42f120d016e1 100644
>> --- a/OvmfPkg/AmdSev/AmdSevX64.fdf
>> +++ b/OvmfPkg/AmdSev/AmdSevX64.fdf
>> @@ -234,7 +234,6 @@ [FV.DXEFV]
>>  INF  MdeModulePkg/Application/UiApp/UiApp.inf
>>  INF  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
>>  INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
>> -INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>>  INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>>  INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>>  INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
>> diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf
>> index 04b41445ca34..031eb4225c53 100644
>> --- a/OvmfPkg/OvmfPkgIa32.fdf
>> +++ b/OvmfPkg/OvmfPkgIa32.fdf
>> @@ -254,7 +254,6 @@ [FV.DXEFV]
>>  INF  MdeModulePkg/Application/UiApp/UiApp.inf
>>  INF  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
>>  INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
>> -INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>>  INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>>  INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>>  INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
>> diff --git a/OvmfPkg/OvmfPkgIa32X64.fdf b/OvmfPkg/OvmfPkgIa32X64.fdf
>> index 02fd8f0c413e..7194f08e6024 100644
>> --- a/OvmfPkg/OvmfPkgIa32X64.fdf
>> +++ b/OvmfPkg/OvmfPkgIa32X64.fdf
>> @@ -255,7 +255,6 @@ [FV.DXEFV]
>>  INF  MdeModulePkg/Application/UiApp/UiApp.inf
>>  INF  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
>>  INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
>> -INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>>  INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>>  INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>>  INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
>> diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf
>> index 5fa8c0895808..b304e3149d4f 100644
>> --- a/OvmfPkg/OvmfPkgX64.fdf
>> +++ b/OvmfPkg/OvmfPkgX64.fdf
>> @@ -267,7 +267,6 @@ [FV.DXEFV]
>>  INF  MdeModulePkg/Application/UiApp/UiApp.inf
>>  INF  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
>>  INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
>> -INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>>  INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>>  INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>>  INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
>>
>

     prev parent reply	other threads:[~2021-07-07 17:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-06  9:53 [PATCH 1/1] OvmfPkg: Remove unused print service driver (PrintDxe) Philippe Mathieu-Daudé
2021-07-06 16:02 ` [edk2-devel] " Laszlo Ersek
2021-07-07 17:50   ` Philippe Mathieu-Daudé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41f6606a-3787-a5ce-6031-6a12191bde2c@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox