From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web08.870.1625680205850497275 for ; Wed, 07 Jul 2021 10:50:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PJNHzeX4; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625680205; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c8r1R5Q26kj/TT7Iz1k7GMHyqproT4taRX2sMJaw2Q0=; b=PJNHzeX4Mk9NOmb4UyQBSuSSsHO17udXxow+CcjKtGwHED+IC20aQiPppXOXld1zgqN7WI 8VvHxCBqAjTpj3/zmvKC4pDYe9AMpnLeOG0JXzFjuPlaxzEQq+6OJyyIJApDcbFIUo9UN+ ZSuwFh5JORK7Hwl0BiStaSjQoseGj+E= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-490-hzIRyu0mMK6xnt5Bjdn3xg-1; Wed, 07 Jul 2021 13:50:03 -0400 X-MC-Unique: hzIRyu0mMK6xnt5Bjdn3xg-1 Received: by mail-wm1-f71.google.com with SMTP id m31-20020a05600c3b1fb02902082e9b2132so2758752wms.5 for ; Wed, 07 Jul 2021 10:50:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=c8r1R5Q26kj/TT7Iz1k7GMHyqproT4taRX2sMJaw2Q0=; b=ACXJrpefvFci4zq7/E7gRYHRDX704g+TeWEYIwd6SKPFW3p/e4NFr3cMEZ9l53e9wk Q01DeNgh8SR7HQljTni6qiwEdTkt7+I5CWgJ4zlHdioX2+kqjcBYwjeVZ/oHBx0d+q7X p64UWwiS8BW2JFDHvPNHX+es4U1G0HFHpkOuuE9t8Ra36sMa0qKhgiybtZrjRmCyGedT JyRHSr0LDNI28djc2Hd6xyOZ+xpuoacC6Q3AlxPofgoUWQuS+w7JU37DzpNWQN0q6q6+ AK9TqsFtYBSeaikozvkDnHWR7pkYdr00Z4jN626HxEMHSmv5GPCsimDZOSCFJ1vDVqOl 8+WA== X-Gm-Message-State: AOAM533wkyNpvBsOpuiwKfRmq+wcTOkCRIKea0jldXBQdSLDxCN/v+5B H8Xflivww31ZVNY6CwMInMxSiRmMD/edU+Vqmpf4IhEx6oe+ueUtrYFP5mq32AeLR5Fd8bz945c Tw9AM5717/Q1WWw== X-Received: by 2002:adf:9084:: with SMTP id i4mr29545889wri.23.1625680202765; Wed, 07 Jul 2021 10:50:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwGekCIkQJx0WmumZpMR+hic5WbTjqBSBunvjtJ7ns22tydD2AIUnxcjaYvi0l+G8raKo4Xqg== X-Received: by 2002:adf:9084:: with SMTP id i4mr29545865wri.23.1625680202597; Wed, 07 Jul 2021 10:50:02 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (93.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.93]) by smtp.gmail.com with ESMTPSA id o19sm6876386wmc.12.2021.07.07.10.50.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jul 2021 10:50:01 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Remove unused print service driver (PrintDxe) To: Laszlo Ersek , devel@edk2.groups.io Cc: Ard Biesheuvel , Jordan Justen , Brijesh Singh , Erdem Aktas , James Bottomley , Jiewen Yao , Min Xu , Tom Lendacky References: <20210706095345.1109163-1-philmd@redhat.com> <60dd70d6-313b-28bd-f8ec-a29379ec6bfd@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <41f6606a-3787-a5ce-6031-6a12191bde2c@redhat.com> Date: Wed, 7 Jul 2021 19:50:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <60dd70d6-313b-28bd-f8ec-a29379ec6bfd@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 7/6/21 6:02 PM, Laszlo Ersek wrote: > On 07/06/21 11:53, Philippe Mathieu-Daudé wrote: >> From: Philippe Mathieu-Daude >> >> The Print service driver is not used by OVMF, remove it. >> >> Cc: Laszlo Ersek >> Cc: Ard Biesheuvel >> Cc: Jordan Justen >> Cc: Brijesh Singh >> Cc: Erdem Aktas >> Cc: James Bottomley >> Cc: Jiewen Yao >> Cc: Min Xu >> Cc: Tom Lendacky >> Suggested-by: Laszlo Ersek >> Signed-off-by: Philippe Mathieu-Daude >> --- >> OvmfPkg/AmdSev/AmdSevX64.dsc | 1 - >> OvmfPkg/OvmfPkgIa32.dsc | 1 - >> OvmfPkg/OvmfPkgIa32X64.dsc | 1 - >> OvmfPkg/OvmfPkgX64.dsc | 1 - >> OvmfPkg/AmdSev/AmdSevX64.fdf | 1 - >> OvmfPkg/OvmfPkgIa32.fdf | 1 - >> OvmfPkg/OvmfPkgIa32X64.fdf | 1 - >> OvmfPkg/OvmfPkgX64.fdf | 1 - >> 8 files changed, 8 deletions(-) > > I think the same applies to all of the DSC/FDF files (basically, > "platforms") under OvmfPkg -- including Bhyve and Xen. Sorry I was sitting on an incorrect branch :( > PrintDxe produces gEfiPrint2ProtocolGuid and gEfiPrint2SProtocolGuid, > and those are consumed by the following PrintLib instance: > > MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.inf > > However, none of the OVMF DSC files contain such a PrintLib class > resolution, so none of the OVMF platforms need PrintDxe. Thanks! > > Thanks, > Laszlo > >> >> diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc >> index 1d487befae08..d1974b4a6873 100644 >> --- a/OvmfPkg/AmdSev/AmdSevX64.dsc >> +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc >> @@ -722,7 +722,6 @@ [Components] >> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf >> PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf >> } >> - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf >> MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc >> index f53efeae7986..dff4b97b37c0 100644 >> --- a/OvmfPkg/OvmfPkgIa32.dsc >> +++ b/OvmfPkg/OvmfPkgIa32.dsc >> @@ -816,7 +816,6 @@ [Components] >> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf >> PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf >> } >> - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf >> MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc >> index b3662e17f256..f3df655c990e 100644 >> --- a/OvmfPkg/OvmfPkgIa32X64.dsc >> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc >> @@ -830,7 +830,6 @@ [Components.X64] >> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf >> PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf >> } >> - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf >> MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc >> index 0a237a905866..dc9a2720f9b2 100644 >> --- a/OvmfPkg/OvmfPkgX64.dsc >> +++ b/OvmfPkg/OvmfPkgX64.dsc >> @@ -828,7 +828,6 @@ [Components] >> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf >> PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf >> } >> - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf >> MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >> diff --git a/OvmfPkg/AmdSev/AmdSevX64.fdf b/OvmfPkg/AmdSev/AmdSevX64.fdf >> index 9977b0f00a18..42f120d016e1 100644 >> --- a/OvmfPkg/AmdSev/AmdSevX64.fdf >> +++ b/OvmfPkg/AmdSev/AmdSevX64.fdf >> @@ -234,7 +234,6 @@ [FV.DXEFV] >> INF MdeModulePkg/Application/UiApp/UiApp.inf >> INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf >> INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf >> -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf >> INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >> diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf >> index 04b41445ca34..031eb4225c53 100644 >> --- a/OvmfPkg/OvmfPkgIa32.fdf >> +++ b/OvmfPkg/OvmfPkgIa32.fdf >> @@ -254,7 +254,6 @@ [FV.DXEFV] >> INF MdeModulePkg/Application/UiApp/UiApp.inf >> INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf >> INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf >> -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf >> INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >> diff --git a/OvmfPkg/OvmfPkgIa32X64.fdf b/OvmfPkg/OvmfPkgIa32X64.fdf >> index 02fd8f0c413e..7194f08e6024 100644 >> --- a/OvmfPkg/OvmfPkgIa32X64.fdf >> +++ b/OvmfPkg/OvmfPkgIa32X64.fdf >> @@ -255,7 +255,6 @@ [FV.DXEFV] >> INF MdeModulePkg/Application/UiApp/UiApp.inf >> INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf >> INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf >> -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf >> INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >> diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf >> index 5fa8c0895808..b304e3149d4f 100644 >> --- a/OvmfPkg/OvmfPkgX64.fdf >> +++ b/OvmfPkg/OvmfPkgX64.fdf >> @@ -267,7 +267,6 @@ [FV.DXEFV] >> INF MdeModulePkg/Application/UiApp/UiApp.inf >> INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf >> INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf >> -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf >> INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >> >