Re: [edk2-platforms][PATCH V2 2/3] ManageabilityPkg: Use SMBUS I2C instead of I2C

["Tinh Nguyen" <tinhnguyen@os.amperecomputing.com>]

[-- Attachment #1: Type: text/plain, Size: 4632 bytes --]

|||Reviewed-by: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>|

On 4/17/2023 7:55 PM, abner.chang@amd.com wrote:
> From: Abner Chang<abner.chang@amd.com>
>
> Signed-off-by: Abner Chang<abner.chang@amd.com>
> Cc: Isaac Oram<isaac.w.oram@intel.com>
> Cc: Abdul Lateef Attar<abdattar@amd.com>
> Cc: Nickle Wang<nicklew@nvidia.com>
> Cc: Tinh Nguyen<tinhnguyen@os.amperecomputing.com>
> ---
>   Features/ManageabilityPkg/ManageabilityPkg.dec     | 10 +++++-----
>   .../BaseManageabilityTransportHelper.inf           |  2 +-
>   .../BaseManageabilityTransportHelper.c             | 14 +++++++-------
>   3 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec b/Features/ManageabilityPkg/ManageabilityPkg.dec
> index 9a930d3e4b..3d279ef033 100644
> --- a/Features/ManageabilityPkg/ManageabilityPkg.dec
> +++ b/Features/ManageabilityPkg/ManageabilityPkg.dec
> @@ -32,13 +32,13 @@
>     # Manageability Transport Interface type
>     #
>     # Manageability Transport KCS
> -  gManageabilityTransportKcsGuid    = { 0x5A6E64E9, 0xFD47, 0x4086, { 0xAA, 0xB0, 0x7A, 0x5F, 0xD7, 0x6B, 0x02, 0x2E } }
> -  # Manageability Transport I2C
> -  gManageabilityTransportI2CGuid    = { 0x5B174658, 0x8263, 0x4CB8, { 0xA0, 0x0F, 0xD6, 0x82, 0xE6, 0xBC, 0x74, 0x93 } }
> +  gManageabilityTransportKcsGuid      = { 0x5A6E64E9, 0xFD47, 0x4086, { 0xAA, 0xB0, 0x7A, 0x5F, 0xD7, 0x6B, 0x02, 0x2E } }
> +  # Manageability Transport SMBUS I2C
> +  gManageabilityTransportSmbusI2cGuid = { 0x5B174658, 0x8263, 0x4CB8, { 0xA0, 0x0F, 0xD6, 0x82, 0xE6, 0xBC, 0x74, 0x93 } }
>     # Manageability Transport PCI VDM
> -  gManageabilityTransportPciVdmGuid = { 0x388021A7, 0xFB59, 0x4811, { 0x9D, 0xA7, 0xD5, 0x63, 0x7D, 0x04, 0xA7, 0x2F } }
> +  gManageabilityTransportPciVdmGuid   = { 0x388021A7, 0xFB59, 0x4811, { 0x9D, 0xA7, 0xD5, 0x63, 0x7D, 0x04, 0xA7, 0x2F } }
>     # Manageability Transport MCTP
> -  gManageabilityTransportMctpGuid   = { 0x6798448D, 0x1200, 0x4577, { 0x82, 0x50, 0xA9, 0x83, 0xBA, 0x2B, 0x45, 0xD9 } }
> +  gManageabilityTransportMctpGuid     = { 0x6798448D, 0x1200, 0x4577, { 0x82, 0x50, 0xA9, 0x83, 0xBA, 0x2B, 0x45, 0xD9 } }
>   
>     # Manageability Protocol Specification
>     #
> diff --git a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf
> index 95c3362ddb..5447954144 100644
> --- a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf
> +++ b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf
> @@ -32,7 +32,7 @@
>   
>   [Guids]
>     gManageabilityTransportKcsGuid
> -  gManageabilityTransportI2CGuid
> +  gManageabilityTransportSmbusI2cGuid
>     gManageabilityTransportPciVdmGuid
>     gManageabilityTransportMctpGuid
>     gManageabilityProtocolIpmiGuid
> diff --git a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c
> index 81da209764..c3f35b7beb 100644
> --- a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c
> +++ b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c
> @@ -15,13 +15,13 @@
>   // Make sure the global variables added here should be unchangable.
>   //
>   MANAGEABILITY_SPECIFICATION_NAME  ManageabilitySpecNameTable[] = {
> -  { &gManageabilityTransportKcsGuid,    L"KCS"     },
> -  { &gManageabilityTransportI2CGuid,    L"I2C"     },
> -  { &gManageabilityTransportPciVdmGuid, L"PCI VDM" },
> -  { &gManageabilityTransportMctpGuid,   L"MCTP"    },
> -  { &gManageabilityProtocolIpmiGuid,    L"IPMI"    },
> -  { &gManageabilityProtocolMctpGuid,    L"MCTP"    },
> -  { &gManageabilityProtocolPldmGuid,    L"PLDM"    }
> +  { &gManageabilityTransportKcsGuid,         L"KCS"      },
> +  { &gManageabilityTransportSmbusI2cGuid,    L"SMBUS I2C"},
> +  { &gManageabilityTransportPciVdmGuid,      L"PCI VDM"  },
> +  { &gManageabilityTransportMctpGuid,        L"MCTP"     },
> +  { &gManageabilityProtocolIpmiGuid,         L"IPMI"     },
> +  { &gManageabilityProtocolMctpGuid,         L"MCTP"     },
> +  { &gManageabilityProtocolPldmGuid,         L"PLDM"     }
>   };
>   
>   UINT16  mManageabilitySpecNum = sizeof (ManageabilitySpecNameTable)/ sizeof (MANAGEABILITY_SPECIFICATION_NAME);

[-- Attachment #2: Type: text/html, Size: 6568 bytes --]