From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (NAM02-BN1-obe.outbound.protection.outlook.com [40.107.212.132]) by mx.groups.io with SMTP id smtpd.web11.565.1681749322774396065 for ; Mon, 17 Apr 2023 09:35:23 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="no key for verify" header.i=@amperemail.onmicrosoft.com header.s=selector1-amperemail-onmicrosoft-com header.b=3TF+gfHO; spf=pass (domain: os.amperecomputing.com, ip: 40.107.212.132, mailfrom: tinhnguyen@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VY5jWLoF6h8N81TbyT4z3bGFwZmJN8H5gmDCNpwY363yN5vYTjd6TEYorclIOTpinbuV98osPwt0rZ3O9reNzRvFRrV5VOerh8unBgabusDfNwj/t9/Xf9raLl0MoKIFmwUQ+7sWMq6pvg6WM3lxfsif1z5/htf3Mi8z0A2wqf4aygviL28RU/4rrMvL9eNpxG6CP8WklpZ0adRpz10bDE26FIO5WOaZJngJF523B6HwjyykKwXQy31kqRsIlBEyzH6G02trBVHEgCiaDi4KlXoAIuj/+lA65+N547vvDBRYLxhnqTzImZzDgGpOgeC1afpmQpP9UOvwwG3REYhztw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c5JRJrgx960O1HZfrWzPhwm1AUn5Y9yFAQafCyyjkDA=; b=gpseox9IUdj77lhs3WNnxdPulnnCtt4TDWEY7MxFumbnOv/Ddk6xtA/WZA6EHakrqZVMVjNJKLmh6UIff5Q6Fqfz6+lroMDYnJjrXpvzNMrPdzoM3MASlMzaIrvR9B1fgTF8hAG60UMmM2J8WQxJZmEovrPzOTdPL+OYqd6gYOmoN97BH6NowTXEgZ8dBRL9cPsehlCMALGa8miS7N3vlADdX1Z0nEEhtgdn+3Az4Js5kt3uXyLbhyag+8t40KBCQBf7bgvimgQKAgEM1cbuBKRF7ts76RsPMUZCVkOvH9Swey3Bk1WdYApJv+aED/JjCtII3J7BLaPj3JNkLAPCyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=amperemail.onmicrosoft.com; dkim=pass header.d=amperemail.onmicrosoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amperemail.onmicrosoft.com; s=selector1-amperemail-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c5JRJrgx960O1HZfrWzPhwm1AUn5Y9yFAQafCyyjkDA=; b=3TF+gfHOAQNklr0hnPOpUp/ijZuQYxnUjouW2As/mpdfV7tAlEbzNqE/lrEn+t54mOKcfwBV/SXTC21B+9sAE1ZGVGueoTlwMtSHCPdaOtJiPYtQMEl3OVc1XR2xtqX/iMs1/ptBc9CV1MOXBwsrifHAAzExJvtmEZaJvNfYqvg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amperemail.onmicrosoft.com; Received: from DM5PR0102MB3336.prod.exchangelabs.com (2603:10b6:4:9f::11) by PH0PR01MB6780.prod.exchangelabs.com (2603:10b6:510:76::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.19; Mon, 17 Apr 2023 16:35:19 +0000 Received: from DM5PR0102MB3336.prod.exchangelabs.com ([fe80::bb9e:46d1:ae4b:caf2]) by DM5PR0102MB3336.prod.exchangelabs.com ([fe80::bb9e:46d1:ae4b:caf2%6]) with mapi id 15.20.6319.019; Mon, 17 Apr 2023 16:35:18 +0000 Message-ID: <42221892-90d9-d045-494e-064cfd8ba658@amperemail.onmicrosoft.com> Date: Mon, 17 Apr 2023 23:35:10 +0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [edk2-platforms][PATCH V2 2/3] ManageabilityPkg: Use SMBUS I2C instead of I2C To: abner.chang@amd.com, devel@edk2.groups.io Cc: Isaac Oram , Abdul Lateef Attar , Nickle Wang , Tinh Nguyen References: <20230417125534.920-1-abner.chang@amd.com> <20230417125534.920-2-abner.chang@amd.com> From: "Tinh Nguyen" In-Reply-To: <20230417125534.920-2-abner.chang@amd.com> X-ClientProxiedBy: SI1PR02CA0005.apcprd02.prod.outlook.com (2603:1096:4:1f7::13) To DM5PR0102MB3336.prod.exchangelabs.com (2603:10b6:4:9f::11) Return-Path: tinhnguyen@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR0102MB3336:EE_|PH0PR01MB6780:EE_ X-MS-Office365-Filtering-Correlation-Id: b9c51762-63da-4d47-f7c6-08db3f61bac1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dDJ1DPa58ou9mpfsj0WwNGJgBgB/nDXzubQapwWxGSDNOIcNKJlkgKhd6n2IH3sKi41sw/doO627Xi3XWRL58V6Re3he0WWhTgSRwli5s4gYvCwZUTzxkVVhfUqpM1jRtLG1CY1vQ/81Bvd7ogrtA1ZSMHF8MNFZIy/rjYo5fVKKmB4ub/bGHTWvnrQzWLFNIQ7XM9q4aYUHjIJRk05cZlV4CcSKdeCtKqit+tr3T6QYFNg5tBG0ETCJifMz1j7886Ps++QQ8WdWNIb3k57yeMq1Q99M4bARDRNE4U5j6NGrMQoLL7sgyTrJv11FcclDDviwDDEKVGemk/IgYOWf/ZAKBHiqOxxgHoBiKIRllog5vX6CEuhNTK0zuuNDF/ysm5pM+P10Xn/0FLr6HeRngERS1MIU/906ZA2BdosLUYJYNhLKS1l5F270ycOh67AciLmE/0d5Mtt8VSwQh5/0fcNX0BLbbbnVdNrz3HpNNmYacBMBQAsgXXwP4numy1zL1xfW5ZLyUOTg4nCE91M3PLcLHgZowHga5Hne0OLpFenCoTNr/dS8DbyD/q804b3t10zuFKHEuq7E4TXK2jQ5A/z+rpz6xMYSp4kK/6BgDqMLXeF0sTlu/x5ibAD+If58 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR0102MB3336.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(366004)(346002)(136003)(39850400004)(396003)(451199021)(2616005)(54906003)(53546011)(6512007)(107886003)(26005)(6506007)(31686004)(478600001)(66946007)(42882007)(66556008)(66476007)(83170400001)(83380400001)(316002)(19627235002)(6486002)(186003)(6666004)(33964004)(4326008)(8936002)(8676002)(41300700001)(5660300002)(2906002)(31696002)(38100700002)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dWtXQjdxTGNFS1U0YytFNTBYRFJXaXdneHg5ZmFKU2FMSzUyb0VoSTZyTVZY?= =?utf-8?B?U1BQbnhOb2gvOVlkN0RaUUhNWGRyNlpOaG9CVVQvbkVFTmF0V0VIcXJUY1Uw?= =?utf-8?B?ZUMzZWpwelB1cDJpM2hKdmMxVDZqL0g1K2pzZ2RUUUVYZ2RlbmNONndXTkVV?= =?utf-8?B?dk85czVvZWFFQzI4a1M4YngxS05LQkgvNk5kQi9nR0xuYjdxYmpzclNiVGlF?= =?utf-8?B?YTNSTEVqSXRoeVh2SUZaTnFpbjY0dS9ISmEzcytEUUsvYXVwZEh5ZURnQXdU?= =?utf-8?B?cnJWd2JrYmZHN3YyNnJpOURxdmhXQXRFS2k3VFE3SmxCaVNPMmp1cFM1VUJx?= =?utf-8?B?RHNya3kvblcyMFNoVHhCZmdmM1NHT1FpeUo5dUFsZm5sc3VFQlRoZ0c5bGs3?= =?utf-8?B?U2MyTG9FTVN2eXQ4RlNUcW1zMnVvbXlXTGVEWWFSQ0R2RzdFOW8vdjlOaDJn?= =?utf-8?B?RFpsWlZ4dHVWaHRoMUdMQ0JjZU5PMFArdzdPbE9kdHlZeE9HcTI3ZWk5enFo?= =?utf-8?B?ZUxHc3BLSjJLUnpTQVNzQVNKYkFPYmR1OEZOV2dUU2RuUFlRK3ZTYWxuN1lP?= =?utf-8?B?OGwvQmpvTndoK1VTOVdmdURQTDQ5MXAvZ2JwZ0hZM1BsT0J0L0psRVNXRFJH?= =?utf-8?B?M0I3bnVaRWJua09GN0tSTzdIc1ZLb0NlejNDa05wTTdKRnZ0YWRTYm91bk10?= =?utf-8?B?aE5paTYrbHpqRkpSYS9YMnhqWU1xZGFHZjFRU1BzUnBCTlV1c2d4TytBclZv?= =?utf-8?B?eHh0K1JhVlAxSmhSL3RqYUdELytjMlNsSEFIUWNOb1hVaUI5UkhVV1BWMVo4?= =?utf-8?B?K0ZwbGd0dEFCY05xQkFrRld4LzA0ODF0UVJkNUxUVFhHWnZ1eFZtRlhSYVQw?= =?utf-8?B?UnVHWkJaZGdDNW4zYWdVVFRzaTgxMTlMOFViU0Nuak5JS1JBU2hsL2RSellE?= =?utf-8?B?bE1qZE40VlNPYmZERzFtUmduRmpQcUlUTGZLbGl6b0FkVzhybFV5MnlyNEIv?= =?utf-8?B?VnUvc040VFpORU9wSFAvQW8wT1RHczIxdWI4L2xaY3BvbTZoMjd5Tk4zWWY2?= =?utf-8?B?YjhQNnk1d05VV2l0cmFVaDhhaXNhN0tXakZpRlF2NC9PbzRyWklkNFBRLy84?= =?utf-8?B?RXNjOUpoRGFPVGlWMjJDQ25OcHdmNUJQbXExM1dvVm9GYUgxVjBwNUI5R2JL?= =?utf-8?B?eThzUno1SGFnUmhqRWhCc2dwcERjMndGWnFvSU9xNGc5ME40ei9JLzQvaDNM?= =?utf-8?B?bWZZWjVZVUJhNjBNU3dXTjFKMU12RnRaSHdac01DbWNBS3BKNVlIaGNsZDhT?= =?utf-8?B?Sy8yWnlHajVlODdSemE3YzgzdjRZUWo0YzRJdzZMVTdxWkx4YytkR0VhWGZQ?= =?utf-8?B?Ukd0TFREQVJlMnVQK2dCV0FjbEFqZmxDblB5VUFBU2t6aEI2NXBYblE5cnE4?= =?utf-8?B?U3FNNHRCcGlBOFQ2T1hlWFd3YXVTNDNQcHFteTh1MGk2K0pUV3lkbWdodVpU?= =?utf-8?B?d1RZZlAvdG8xUWV0T1lHZWNmVUF0cDZyU1paYnU0SWRHVlk3ZGVucEhwQVlB?= =?utf-8?B?bU5MWWk2Y01QakRPYU9vTHBxaWl5TzlxeHllcDd6S1FvTndZd21CN3o2aUFl?= =?utf-8?B?VDIvTy9zbWtPc083TzBHaVg0RUYzOUk3WFdwZHVOQzBXSS9LUTU1M1BDeExo?= =?utf-8?B?WUd3bEV1NlhMcFM1SDNleEw1QVFGeWRWTjd4RWhvTldlVTVEeUdyOFdoVTBI?= =?utf-8?B?L1BPbFg2a2R4d1hMWDljV01leXNJZ0F1amxrNDByeXhMWEViM1JpVzZYdDlD?= =?utf-8?B?M2tzNnlveTRGV0djUCtVM0M2d0JwN2E3Vlk3Y2hwRmp6UHh3NXA1WmRKam5h?= =?utf-8?B?aDJFQ2Z0TW1xbVdZT3JZWmlyMjRIMldSNUR0SzR1bmFhc3dscG41ZHFLQWEr?= =?utf-8?B?TERyVlJaVmpmNTczSDVLemphdXBORVNzT0hOT0FNRzJCOVgyN3hOV2xJQS8r?= =?utf-8?B?UENTVzlaYWZQbnpFRlh5NmcxY2MrVldpQUh4NzR1MlMwMGVkMnplSjFGcm1n?= =?utf-8?B?OGxQQmIxTFIxblRkVVhxbmlHR1RZK254cHBRSm1ZUkYrdEJjbW5MdkhvZDZO?= =?utf-8?B?azVmVXVHV0tzcVgvRXUrYjBpa3VVakRCaDd0OWwrVFo5b1ZiMG52Nk5oSlNW?= =?utf-8?Q?AWZ96q+xH97oMW047RcCPxc=3D?= X-OriginatorOrg: amperemail.onmicrosoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: b9c51762-63da-4d47-f7c6-08db3f61bac1 X-MS-Exchange-CrossTenant-AuthSource: DM5PR0102MB3336.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2023 16:35:18.3867 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7ouzo8xg8iaJGMu6xwj3RKcBAK8pS5rnYZkZQgPejAQDrhSFhO3qVZbbs0pkqfCPK6obbUYMYweerRI/36at/dyjrzKfvsYZG3a/nnhUsKLS2XD7IW4NagYjwsDsnfTt X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR01MB6780 Content-Type: multipart/alternative; boundary="------------iliIdugpbE0jpQvBTpI37eqp" Content-Language: en-US --------------iliIdugpbE0jpQvBTpI37eqp Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit |||Reviewed-by: Tinh Nguyen | On 4/17/2023 7:55 PM, abner.chang@amd.com wrote: > From: Abner Chang > > Signed-off-by: Abner Chang > Cc: Isaac Oram > Cc: Abdul Lateef Attar > Cc: Nickle Wang > Cc: Tinh Nguyen > --- > Features/ManageabilityPkg/ManageabilityPkg.dec | 10 +++++----- > .../BaseManageabilityTransportHelper.inf | 2 +- > .../BaseManageabilityTransportHelper.c | 14 +++++++------- > 3 files changed, 13 insertions(+), 13 deletions(-) > > diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec b/Features/ManageabilityPkg/ManageabilityPkg.dec > index 9a930d3e4b..3d279ef033 100644 > --- a/Features/ManageabilityPkg/ManageabilityPkg.dec > +++ b/Features/ManageabilityPkg/ManageabilityPkg.dec > @@ -32,13 +32,13 @@ > # Manageability Transport Interface type > # > # Manageability Transport KCS > - gManageabilityTransportKcsGuid = { 0x5A6E64E9, 0xFD47, 0x4086, { 0xAA, 0xB0, 0x7A, 0x5F, 0xD7, 0x6B, 0x02, 0x2E } } > - # Manageability Transport I2C > - gManageabilityTransportI2CGuid = { 0x5B174658, 0x8263, 0x4CB8, { 0xA0, 0x0F, 0xD6, 0x82, 0xE6, 0xBC, 0x74, 0x93 } } > + gManageabilityTransportKcsGuid = { 0x5A6E64E9, 0xFD47, 0x4086, { 0xAA, 0xB0, 0x7A, 0x5F, 0xD7, 0x6B, 0x02, 0x2E } } > + # Manageability Transport SMBUS I2C > + gManageabilityTransportSmbusI2cGuid = { 0x5B174658, 0x8263, 0x4CB8, { 0xA0, 0x0F, 0xD6, 0x82, 0xE6, 0xBC, 0x74, 0x93 } } > # Manageability Transport PCI VDM > - gManageabilityTransportPciVdmGuid = { 0x388021A7, 0xFB59, 0x4811, { 0x9D, 0xA7, 0xD5, 0x63, 0x7D, 0x04, 0xA7, 0x2F } } > + gManageabilityTransportPciVdmGuid = { 0x388021A7, 0xFB59, 0x4811, { 0x9D, 0xA7, 0xD5, 0x63, 0x7D, 0x04, 0xA7, 0x2F } } > # Manageability Transport MCTP > - gManageabilityTransportMctpGuid = { 0x6798448D, 0x1200, 0x4577, { 0x82, 0x50, 0xA9, 0x83, 0xBA, 0x2B, 0x45, 0xD9 } } > + gManageabilityTransportMctpGuid = { 0x6798448D, 0x1200, 0x4577, { 0x82, 0x50, 0xA9, 0x83, 0xBA, 0x2B, 0x45, 0xD9 } } > > # Manageability Protocol Specification > # > diff --git a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf > index 95c3362ddb..5447954144 100644 > --- a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf > +++ b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf > @@ -32,7 +32,7 @@ > > [Guids] > gManageabilityTransportKcsGuid > - gManageabilityTransportI2CGuid > + gManageabilityTransportSmbusI2cGuid > gManageabilityTransportPciVdmGuid > gManageabilityTransportMctpGuid > gManageabilityProtocolIpmiGuid > diff --git a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c > index 81da209764..c3f35b7beb 100644 > --- a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c > +++ b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c > @@ -15,13 +15,13 @@ > // Make sure the global variables added here should be unchangable. > // > MANAGEABILITY_SPECIFICATION_NAME ManageabilitySpecNameTable[] = { > - { &gManageabilityTransportKcsGuid, L"KCS" }, > - { &gManageabilityTransportI2CGuid, L"I2C" }, > - { &gManageabilityTransportPciVdmGuid, L"PCI VDM" }, > - { &gManageabilityTransportMctpGuid, L"MCTP" }, > - { &gManageabilityProtocolIpmiGuid, L"IPMI" }, > - { &gManageabilityProtocolMctpGuid, L"MCTP" }, > - { &gManageabilityProtocolPldmGuid, L"PLDM" } > + { &gManageabilityTransportKcsGuid, L"KCS" }, > + { &gManageabilityTransportSmbusI2cGuid, L"SMBUS I2C"}, > + { &gManageabilityTransportPciVdmGuid, L"PCI VDM" }, > + { &gManageabilityTransportMctpGuid, L"MCTP" }, > + { &gManageabilityProtocolIpmiGuid, L"IPMI" }, > + { &gManageabilityProtocolMctpGuid, L"MCTP" }, > + { &gManageabilityProtocolPldmGuid, L"PLDM" } > }; > > UINT16 mManageabilitySpecNum = sizeof (ManageabilitySpecNameTable)/ sizeof (MANAGEABILITY_SPECIFICATION_NAME); --------------iliIdugpbE0jpQvBTpI37eqp Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit 

Reviewed-by: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>

On 4/17/2023 7:55 PM, abner.chang@amd.com wrote:
From: Abner Chang <abner.chang@amd.com>

Signed-off-by: Abner Chang <abner.chang@amd.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Abdul Lateef Attar <abdattar@amd.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
---
 Features/ManageabilityPkg/ManageabilityPkg.dec     | 10 +++++-----
 .../BaseManageabilityTransportHelper.inf           |  2 +-
 .../BaseManageabilityTransportHelper.c             | 14 +++++++-------
 3 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec b/Features/ManageabilityPkg/ManageabilityPkg.dec
index 9a930d3e4b..3d279ef033 100644
--- a/Features/ManageabilityPkg/ManageabilityPkg.dec
+++ b/Features/ManageabilityPkg/ManageabilityPkg.dec
@@ -32,13 +32,13 @@
   # Manageability Transport Interface type
   #
   # Manageability Transport KCS
-  gManageabilityTransportKcsGuid    = { 0x5A6E64E9, 0xFD47, 0x4086, { 0xAA, 0xB0, 0x7A, 0x5F, 0xD7, 0x6B, 0x02, 0x2E } }
-  # Manageability Transport I2C
-  gManageabilityTransportI2CGuid    = { 0x5B174658, 0x8263, 0x4CB8, { 0xA0, 0x0F, 0xD6, 0x82, 0xE6, 0xBC, 0x74, 0x93 } }
+  gManageabilityTransportKcsGuid      = { 0x5A6E64E9, 0xFD47, 0x4086, { 0xAA, 0xB0, 0x7A, 0x5F, 0xD7, 0x6B, 0x02, 0x2E } }
+  # Manageability Transport SMBUS I2C
+  gManageabilityTransportSmbusI2cGuid = { 0x5B174658, 0x8263, 0x4CB8, { 0xA0, 0x0F, 0xD6, 0x82, 0xE6, 0xBC, 0x74, 0x93 } }
   # Manageability Transport PCI VDM
-  gManageabilityTransportPciVdmGuid = { 0x388021A7, 0xFB59, 0x4811, { 0x9D, 0xA7, 0xD5, 0x63, 0x7D, 0x04, 0xA7, 0x2F } }
+  gManageabilityTransportPciVdmGuid   = { 0x388021A7, 0xFB59, 0x4811, { 0x9D, 0xA7, 0xD5, 0x63, 0x7D, 0x04, 0xA7, 0x2F } }
   # Manageability Transport MCTP
-  gManageabilityTransportMctpGuid   = { 0x6798448D, 0x1200, 0x4577, { 0x82, 0x50, 0xA9, 0x83, 0xBA, 0x2B, 0x45, 0xD9 } }
+  gManageabilityTransportMctpGuid     = { 0x6798448D, 0x1200, 0x4577, { 0x82, 0x50, 0xA9, 0x83, 0xBA, 0x2B, 0x45, 0xD9 } }
 
   # Manageability Protocol Specification
   #
diff --git a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf
index 95c3362ddb..5447954144 100644
--- a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf
+++ b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf
@@ -32,7 +32,7 @@
 
 [Guids]
   gManageabilityTransportKcsGuid
-  gManageabilityTransportI2CGuid
+  gManageabilityTransportSmbusI2cGuid
   gManageabilityTransportPciVdmGuid
   gManageabilityTransportMctpGuid
   gManageabilityProtocolIpmiGuid
diff --git a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c
index 81da209764..c3f35b7beb 100644
--- a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c
+++ b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c
@@ -15,13 +15,13 @@
 // Make sure the global variables added here should be unchangable.
 //
 MANAGEABILITY_SPECIFICATION_NAME  ManageabilitySpecNameTable[] = {
-  { &gManageabilityTransportKcsGuid,    L"KCS"     },
-  { &gManageabilityTransportI2CGuid,    L"I2C"     },
-  { &gManageabilityTransportPciVdmGuid, L"PCI VDM" },
-  { &gManageabilityTransportMctpGuid,   L"MCTP"    },
-  { &gManageabilityProtocolIpmiGuid,    L"IPMI"    },
-  { &gManageabilityProtocolMctpGuid,    L"MCTP"    },
-  { &gManageabilityProtocolPldmGuid,    L"PLDM"    }
+  { &gManageabilityTransportKcsGuid,         L"KCS"      },
+  { &gManageabilityTransportSmbusI2cGuid,    L"SMBUS I2C"},
+  { &gManageabilityTransportPciVdmGuid,      L"PCI VDM"  },
+  { &gManageabilityTransportMctpGuid,        L"MCTP"     },
+  { &gManageabilityProtocolIpmiGuid,         L"IPMI"     },
+  { &gManageabilityProtocolMctpGuid,         L"MCTP"     },
+  { &gManageabilityProtocolPldmGuid,         L"PLDM"     }
 };
 
 UINT16  mManageabilitySpecNum = sizeof (ManageabilitySpecNameTable)/ sizeof (MANAGEABILITY_SPECIFICATION_NAME);
--------------iliIdugpbE0jpQvBTpI37eqp--