[edk2-devel] [PATCH v2] ArmPkg/ProcessorSubClassDxe: Limit counts to 0xFF

["Jeff Brasen via groups.io" <jbrasen=nvidia.com@groups.io>]

 The CoreCount, EnabledCore and ThreadCount counts should be set to 0xFF
 if value is greater than 255 per the SMBIOS specification.

Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
---
 .../ProcessorSubClassDxe/ProcessorSubClass.c  | 42 +++++++++++++------
 1 file changed, 30 insertions(+), 12 deletions(-)

diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
index 9050588500..abb4c726de 100644
--- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
+++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
@@ -702,19 +702,37 @@ AddSmbiosProcessorTypeTable (
 
   LegacyVoltage = (UINT8 *)&Type4Record->Voltage;
 
-  *LegacyVoltage                 = MiscProcessorData.Voltage;
-  Type4Record->CurrentSpeed      = MiscProcessorData.CurrentSpeed;
-  Type4Record->MaxSpeed          = MiscProcessorData.MaxSpeed;
-  Type4Record->Status            = ProcessorStatus.Data;
-  Type4Record->L1CacheHandle     = L1CacheHandle;
-  Type4Record->L2CacheHandle     = L2CacheHandle;
-  Type4Record->L3CacheHandle     = L3CacheHandle;
-  Type4Record->CoreCount         = MiscProcessorData.CoreCount;
-  Type4Record->CoreCount2        = MiscProcessorData.CoreCount;
-  Type4Record->EnabledCoreCount  = MiscProcessorData.CoresEnabled;
+  *LegacyVoltage             = MiscProcessorData.Voltage;
+  Type4Record->CurrentSpeed  = MiscProcessorData.CurrentSpeed;
+  Type4Record->MaxSpeed      = MiscProcessorData.MaxSpeed;
+  Type4Record->Status        = ProcessorStatus.Data;
+  Type4Record->L1CacheHandle = L1CacheHandle;
+  Type4Record->L2CacheHandle = L2CacheHandle;
+  Type4Record->L3CacheHandle = L3CacheHandle;
+
+  if (MiscProcessorData.CoreCount > 255) {
+    Type4Record->CoreCount = 0xFF;
+  } else {
+    Type4Record->CoreCount = MiscProcessorData.CoreCount;
+  }
+
+  Type4Record->CoreCount2 = MiscProcessorData.CoreCount;
+
+  if (MiscProcessorData.CoresEnabled > 255) {
+    Type4Record->EnabledCoreCount = 0xFF;
+  } else {
+    Type4Record->EnabledCoreCount = MiscProcessorData.CoresEnabled;
+  }
+
   Type4Record->EnabledCoreCount2 = MiscProcessorData.CoresEnabled;
-  Type4Record->ThreadCount       = MiscProcessorData.ThreadCount;
-  Type4Record->ThreadCount2      = MiscProcessorData.ThreadCount;
+
+  if (MiscProcessorData.ThreadCount > 255) {
+    Type4Record->ThreadCount = 0xFF;
+  } else {
+    Type4Record->ThreadCount = MiscProcessorData.ThreadCount;
+  }
+
+  Type4Record->ThreadCount2 = MiscProcessorData.ThreadCount;
 
   Type4Record->CurrentSpeed  = GetCpuFrequency (ProcessorIndex);
   Type4Record->ExternalClock =
-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115174): https://edk2.groups.io/g/devel/message/115174
Mute This Topic: https://groups.io/mt/104199497/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-