public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>,
	edk2-devel-01 <edk2-devel@lists.01.org>
Subject: Re: [PATCH 0/2] ArmVirtPkg, OvmfPkg: connect Virtio RNG devices again
Date: Fri, 18 May 2018 13:53:28 +0200	[thread overview]
Message-ID: <427d3098-8766-e805-099b-00167b36c032@redhat.com> (raw)
In-Reply-To: <CAKv+Gu_S1dgnO-yQ+fPagAYXDt6nHZ2h8+Ns9NBF8e5tKocnsg@mail.gmail.com>

On 05/18/18 11:09, Ard Biesheuvel wrote:
> On 18 May 2018 at 08:20, Laszlo Ersek <lersek@redhat.com> wrote:
>> Repo:   https://github.com/lersek/edk2.git
>> Branch: connect_vrng_bz1579518
>>
>> This is a fix for another regression from the March 2018 series
>>
>>   [edk2] [PATCH 0/6] OvmfPkg, ArmVirtQemu: leaner platform BDS policy
>>                      for connecting devices
>>
>> Turns out EfiBootManagerConnectAll() used to connect devices one doesn't
>> really think about every day. I stumbled upon this when an aarch64 guest
>> kernel printed
>>
>>> EFI stub: EFI_RNG_PROTOCOL unavailable, no randomness supplied
>>
>> whereas I had just looked at the domain XML and seen the virtio-rng
>> device model in it.
>>
>> Tested extensively as described in
>> <https://bugzilla.redhat.com/show_bug.cgi?id=1579518#c0> and
>> <https://bugzilla.redhat.com/show_bug.cgi?id=1579518#c2>.
>>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>>
>> Thanks,
>> Laszlo
>>
>> Laszlo Ersek (2):
>>   ArmVirtPkg/PlatformBootManagerLib: connect Virtio RNG devices again
>>   OvmfPkg/PlatformBootManagerLib: connect Virtio RNG devices again
>>
> 
> Thanks for spotting that
> 
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Thank you! Commit range 333f32ec23dd..7ebad830d6ab.

Cheers
Laszlo


      reply	other threads:[~2018-05-18 11:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-18  6:20 [PATCH 0/2] ArmVirtPkg, OvmfPkg: connect Virtio RNG devices again Laszlo Ersek
2018-05-18  6:20 ` [PATCH 1/2] ArmVirtPkg/PlatformBootManagerLib: " Laszlo Ersek
2018-05-18  6:20 ` [PATCH 2/2] OvmfPkg/PlatformBootManagerLib: " Laszlo Ersek
2018-05-18  9:09 ` [PATCH 0/2] ArmVirtPkg, OvmfPkg: " Ard Biesheuvel
2018-05-18 11:53   ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=427d3098-8766-e805-099b-00167b36c032@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox