From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web09.25585.1574350951095375583 for ; Thu, 21 Nov 2019 07:42:31 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=NK01tAyE; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574350950; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hpgjWFH8tzkd7KbhbkkQirh44z+zFENRTaJ0biw6aIM=; b=NK01tAyEumqFPwbMmgMiWi006UBU9CQioSrGSPIMDixwSYcGfAvdvqUP3JT8qVDftA8v7U mIfJDNgD6AXmNxjt0msxwdFG1BMg/Rt0MeviU4yUhhXgk39hxLj06AIV8/f5lnyyCEcfi7 1Ti798IXXLDDX7cD6y3RX75o5h3qJL8= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-46-W2Kg0iduMA-PLCeORdCiaQ-1; Thu, 21 Nov 2019 10:42:28 -0500 Received: by mail-wr1-f71.google.com with SMTP id y3so2265790wrm.12 for ; Thu, 21 Nov 2019 07:42:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3nVkCBIRVrTsjhA/F6cZRSF660LplkXMQM0hgrTw3c0=; b=YAYrQaBq3G6IMxBcY6SqyAx1v3SEgY/5HjOj4Kz0nzZSmzZYpGmFe3hbPW+uvxmbG7 2gBm81wejioveZ9UdmWK1ASCogS2d6sVsRveWmX0lxl+0RtWNvJFSGeWRq+N/zMM4N5h imhnf7MHpuYVpS1T7qczmAgHTeIQmcR/5E/6Ti2iQOxs6zumsNUQ7Fs5T5fJtpQEBnNK YX6FoS4SfaJN9w7C2qzvEw7EUdDCEpcNKI1sLYB7TI/ltNaJ/sSglvil93G/MO7IZDO0 pT8vgz9leOBNAsQf/5MWm4b0EmNVptM9VPR/0soUeIud6LTlT78+3MUR1rpg9ojHclvu 4kLw== X-Gm-Message-State: APjAAAUCUevPFuZRNrNVxGwZ2GjP1UqQe6D1ZUnlJxlcI2OU/UgFlhSx lOvFoz29aJjvFPXSldw26EzRW+4xbNC58X3umoL317Zn4ypTnu6IeXDSmtdLpIRdVB4YMbWeou0 VzDLUgsHqINFdtQ== X-Received: by 2002:a1c:7e0e:: with SMTP id z14mr11316996wmc.52.1574350946973; Thu, 21 Nov 2019 07:42:26 -0800 (PST) X-Google-Smtp-Source: APXvYqxDteNTdFKFb1jn7N8ZmhVJn+yd4EwjdM4A9CBgFc2MJFR2Jd/Vx/DrCxRlp2NLarhUDsDagg== X-Received: by 2002:a1c:7e0e:: with SMTP id z14mr11316979wmc.52.1574350946768; Thu, 21 Nov 2019 07:42:26 -0800 (PST) Return-Path: Received: from [192.168.1.35] (131.red-88-21-102.staticip.rima-tde.net. [88.21.102.131]) by smtp.gmail.com with ESMTPSA id o7sm2293686wrv.63.2019.11.21.07.42.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Nov 2019 07:42:26 -0800 (PST) Subject: Re: [edk2-devel] [PATCH v1 15/19] DynamicTablesPkg: Remove erroneous use of EFIAPI To: devel@edk2.groups.io, sami.mujawar@arm.com Cc: Alexei.Fedorov@arm.com, leif.lindholm@linaro.org, Matteo.Carlini@arm.com, nd@arm.com References: <20190823105539.13260-1-sami.mujawar@arm.com> <20190823105539.13260-16-sami.mujawar@arm.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <4287c69b-fbac-6c05-23d2-9673fe502cbe@redhat.com> Date: Thu, 21 Nov 2019 16:42:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20190823105539.13260-16-sami.mujawar@arm.com> X-MC-Unique: W2Kg0iduMA-PLCeORdCiaQ-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 8/23/19 12:55 PM, Sami Mujawar wrote: > The Dynamic Tables Factory protocol has an erroneous > EFIAPI calling convention macro in the function > pointer declaration. >=20 > Remove the erroneous EFIAPI calling convention macro > from the interface declarations. >=20 > Signed-off-by: Sami Mujawar > --- > DynamicTablesPkg/Include/Protocol/DynamicTableFactoryProtocol.h | 11 +-= --------- > 1 file changed, 1 insertion(+), 10 deletions(-) >=20 > diff --git a/DynamicTablesPkg/Include/Protocol/DynamicTableFactoryProtoco= l.h b/DynamicTablesPkg/Include/Protocol/DynamicTableFactoryProtocol.h > index d07d0cac36dedb0568f6f604daa22429565aafd3..ff2331b060019976319fc2707= f65252130a5326c 100644 > --- a/DynamicTablesPkg/Include/Protocol/DynamicTableFactoryProtocol.h > +++ b/DynamicTablesPkg/Include/Protocol/DynamicTableFactoryProtocol.h > @@ -1,6 +1,6 @@ > /** @file > =20 > - Copyright (c) 2017 - 2018, ARM Limited. All rights reserved. > + Copyright (c) 2017 - 2019, ARM Limited. All rights reserved. > =20 > SPDX-License-Identifier: BSD-2-Clause-Patent > =20 > @@ -53,7 +53,6 @@ typedef struct DynamicTableFactoryInfo EDKII_DYNAMIC_TA= BLE_FACTORY_INFO; > **/ > typedef > EFI_STATUS > -EFIAPI > (EFIAPI * EDKII_DYNAMIC_TABLE_FACTORY_GET_ACPI_TABLE_GENERATOR) ( > IN CONST EDKII_DYNAMIC_TABLE_FACTORY_PROTOCOL * CONST This, > IN CONST ACPI_TABLE_GENERATOR_ID GeneratorId, > @@ -73,7 +72,6 @@ EFIAPI > **/ > typedef > EFI_STATUS > -EFIAPI > (EFIAPI * EDKII_DYNAMIC_TABLE_FACTORY_REGISTER_ACPI_TABLE_GENERATOR) ( > IN CONST ACPI_TABLE_GENERATOR * CONST Generator > ); > @@ -89,7 +87,6 @@ EFIAPI > **/ > typedef > EFI_STATUS > -EFIAPI > (EFIAPI * EDKII_DYNAMIC_TABLE_FACTORY_DEREGISTER_ACPI_TABLE_GENERATOR) = ( > IN CONST ACPI_TABLE_GENERATOR * CONST Generator > ); > @@ -109,7 +106,6 @@ EFIAPI > **/ > typedef > EFI_STATUS > -EFIAPI > (EFIAPI * EDKII_DYNAMIC_TABLE_FACTORY_GET_SMBIOS_TABLE_GENERATOR) ( > IN CONST EDKII_DYNAMIC_TABLE_FACTORY_PROTOCOL * CONST This, > IN CONST SMBIOS_TABLE_GENERATOR_ID GeneratorId, > @@ -129,7 +125,6 @@ EFIAPI > **/ > typedef > EFI_STATUS > -EFIAPI > (EFIAPI * EDKII_DYNAMIC_TABLE_FACTORY_REGISTER_SMBIOS_TABLE_GENERATOR) = ( > IN CONST SMBIOS_TABLE_GENERATOR * CONST Generator > ); > @@ -145,7 +140,6 @@ EFIAPI > **/ > typedef > EFI_STATUS > -EFIAPI > (EFIAPI * EDKII_DYNAMIC_TABLE_FACTORY_DEREGISTER_SMBIOS_TABLE_GENERATOR= ) ( > IN CONST SMBIOS_TABLE_GENERATOR * CONST Generator > ); > @@ -165,7 +159,6 @@ EFIAPI > **/ > typedef > EFI_STATUS > -EFIAPI > (EFIAPI * EDKII_DYNAMIC_TABLE_FACTORY_GET_DT_TABLE_GENERATOR) ( > IN CONST EDKII_DYNAMIC_TABLE_FACTORY_PROTOCOL * CONST This, > IN CONST DT_TABLE_GENERATOR_ID GeneratorId, > @@ -185,7 +178,6 @@ EFIAPI > **/ > typedef > EFI_STATUS > -EFIAPI > (EFIAPI * EDKII_DYNAMIC_TABLE_FACTORY_REGISTER_DT_TABLE_GENERATOR) ( > IN CONST DT_TABLE_GENERATOR * CONST Generator > ); > @@ -204,7 +196,6 @@ EFIAPI > **/ > typedef > EFI_STATUS > -EFIAPI > (EFIAPI * EDKII_DYNAMIC_TABLE_FACTORY_DEREGISTER_DT_TABLE_GENERATOR) ( > IN CONST DT_TABLE_GENERATOR * CONST Generator > ); >=20 Reviewed-by: Philippe Mathieu-Daude