From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4A09F9418F7 for ; Thu, 1 Aug 2024 15:19:58 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Y9splRgGYZJ9BsxhdPg8YAfGxMsimx/qrydJtHDQli8=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1722525598; v=1; b=uySP6YMVjLndKrMq83aMHSOKLXSHwh7Ivc985ET16zgcQS/QZzayq3Cu2g5zRXnJtxXl/ZIM f9wprP5dj8CxiqVpfXdguK+4Fw1krezBE0hXL5vLubih1l+QXTGLo/p1BV6sIqCx52On2RAIauB slImksSin2Oy2/J59hw/uuYSQKcHo25Jba79OuRTxDkuh4fcZUDYPX2FiiGW4guEVbXefEu/Yrf lqSODanFImB4/LCZQVGw24fk+7u5+Rgjr7Xp1Ut/8I6ggqV03lr7CeRLzzgumRPlpHeo4oXlM4e telUOZl+RB/s63gUncLtw53agabLVNd473fysRW1HbQ8A== X-Received: by 127.0.0.2 with SMTP id VNlpYY7687511x01dCoqhjxB; Thu, 01 Aug 2024 08:19:56 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.71024.1722525596021768959 for ; Thu, 01 Aug 2024 08:19:56 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2D2DE15A1; Thu, 1 Aug 2024 08:20:21 -0700 (PDT) X-Received: from [192.168.20.57] (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BE7153F5A1; Thu, 1 Aug 2024 08:19:51 -0700 (PDT) Message-ID: <42ab5584-3887-45e4-b08e-d82c8cc822e0@arm.com> Date: Thu, 1 Aug 2024 10:19:50 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec To: Ard Biesheuvel Cc: devel@edk2.groups.io, Leif Lindholm , Abdul Lateef Attar , Abner Chang , Chuong Tran , Graeme Gregory , Marcin Juszkiewicz , Marcin Wojtas , Meenakshi Aggarwal , Narinder Dhillon , Nhi Pham , Paul Grimes , Rebecca Cran , Sami Mujawar , Thomas Abraham , Wenyi Xie , Ling Jia , Peng Xie , Yiqi Shu References: <20240731163334.6979-1-ardb@kernel.org> <841a1869-2cd4-4ba4-aea0-12b2f1b90d86@arm.com> From: "Jeremy Linton" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 01 Aug 2024 08:19:56 -0700 Resent-From: jeremy.linton@arm.com Reply-To: devel@edk2.groups.io,jeremy.linton@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: XNxtXkSDhNjzlr5zhUbQA0kFx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=uySP6YMV; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Hi, On 8/1/24 09:44, Ard Biesheuvel wrote: > On Thu, 1 Aug 2024 at 16:11, Ard Biesheuvel wrote: >> >> On Thu, 1 Aug 2024 at 15:49, Jeremy Linton wrote= : >>> >>> Hi, >>> >>> On 7/31/24 11:33, Ard Biesheuvel wrote: >>>> Switch all ARM platforms that use the SEC drivers in edk2/ArmPlatformP= kg >>>> to the new versions called Sec or PeilessSec - these have been cleaned >>>> up and stripped of obsolete functionality related to multicore boot, >>>> which is not something UEFI should concern itself with. >>>> >>>> This series can be merged once Tianocore/edk2 PR #5997 is merged first= . >>>> After that, ArmPlatformStackLib and the old PrePi / PrePeiCore drivers >>>> can be retired. >>> >>> >>> Hi, >>> >>> Thanks for cleaning this up, but the rpi4 fails with: >>> >>> Decompress GetInfo Failed - Invalid Parameter >>> >>> ASSERT_EFI_ERROR (Status =3D Not Found) >>> ASSERT [PeilessSec] >>> /home/jlinton/rpi2/edk2/ArmPlatformPkg/PeilessSec/PeilessSec.c(158): >>> !(((INTN)(RETURN_STATUS)(Status)) < 0) >>> >> >> Weird. I actually tried RPi4 myself. Maybe I should have tried a clean r= ebuild. >> >> I'll look into it. >=20 > The below should fix it - I'll update all DSCs with this if it works > for you as well. That fixes the problem above. Thanks! I just spent an hour hunting a sd stall heisenbug I've never seen before=20 too, which initially I thought might be related to the set from earlier=20 this week, but it seems doubtful since the controller stalled far to=20 late in the firmware boot for it to be related. Looks like it just=20 glitched out and stopped responding to commands, and I either got=20 impatient and power cycled it to soon, or the reset/recovery logic isn't=20 right, but I don't know since I killed it to quickly and now can't=20 reproduce it. >=20 > --- a/Platform/RaspberryPi/RPi4/RPi4.dsc > +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc > @@ -193,7 +193,6 @@ [LibraryClasses.common.SEC] > MemoryInitPeiLib|Platform/RaspberryPi/Library/MemoryInitPeiLib/Memory= InitPeiLib.inf > PlatformPeiLib|ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf > ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSection= Lib/PrePiExtractGuidedSectionLib.inf > - LzmaDecompressLib|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCus= tomDecompressLib.inf > PrePiLib|EmbeddedPkg/Library/PrePiLib/PrePiLib.inf > HobLib|EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf > PrePiHobListPointerLib|ArmPlatformPkg/Library/PrePiHobListPointerLib/= PrePiHobListPointerLib.inf > @@ -604,6 +603,7 @@ [Components.common] > # > ArmPlatformPkg/PeilessSec/PeilessSec.inf { > > + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecomp= ressLib.inf > SerialPortLib|Platform/RaspberryPi/Library/DualSerialPortLib/Dual= SerialPortLib.inf > } -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120183): https://edk2.groups.io/g/devel/message/120183 Mute This Topic: https://groups.io/mt/107649429/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-