From: "Gupta, Pankaj" <pankaj.gupta@amd.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Dionna Amalie Glaze <dionnaglaze@google.com>,
devel@edk2.groups.io, Gerd Hoffmann <kraxel@redhat.com>,
James Bottomley <jejb@linux.ibm.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
"Min M. Xu" <min.m.xu@intel.com>, Andrew Fish <afish@apple.com>,
"Michael D. Kinney" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH v10 1/4] OvmfPkg: Add memory acceptance event in AmdSevDxe
Date: Fri, 10 Feb 2023 12:34:47 +0100 [thread overview]
Message-ID: <42ac1072-fca0-dba7-cc9d-9121eb272cce@amd.com> (raw)
In-Reply-To: <CAMj1kXE_bgZHv19PT16Jbgt2Md1wcrVu6hxDfCZyVG_pxaorWA@mail.gmail.com>
>> [1]
>> ConvertPages: range 1000000 - 41AEFFF covers multiple entries^M
>> Accepting all memory^M
>> Accepting all memory^M
>
> This looks to me like it is entering the 'accept' path twice, and so
> ExitBootServices() is failing twice, resulting in a failed boot.
Thanks for having a look.
Yes, I was also wondering why its calling "Accepting all memory" twice.
I tried to put some printf in error path of "accept" but does seem
hitting any.
Also, accepting memory which is already accepted (pvalidate in case of
SEV SNP) can be problematic.
Thanks,
Pankaj
next prev parent reply other threads:[~2023-02-10 11:35 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 0:56 [PATCH v10 0/4] Add safe unaccepted memory behavior Dionna Glaze
2023-01-26 0:56 ` [PATCH v10 1/4] OvmfPkg: Add memory acceptance event in AmdSevDxe Dionna Glaze
2023-01-26 10:30 ` Ard Biesheuvel
2023-01-26 16:04 ` Dionna Glaze
2023-02-09 13:35 ` [edk2-devel] " Gupta, Pankaj
2023-02-09 16:52 ` Dionna Glaze
2023-02-09 21:27 ` Dionna Glaze
2023-02-10 8:00 ` Gupta, Pankaj
2023-02-10 11:12 ` Ard Biesheuvel
2023-02-10 11:34 ` Gupta, Pankaj [this message]
2023-02-10 13:56 ` Gupta, Pankaj
2023-02-10 17:05 ` Dionna Glaze
2023-02-13 14:38 ` Gupta, Pankaj
2023-02-13 16:53 ` Dionna Glaze
2023-02-13 17:56 ` Gupta, Pankaj
2023-02-13 18:31 ` Dionna Glaze
2023-02-13 19:33 ` Lendacky, Thomas
2023-02-13 19:33 ` Gupta, Pankaj
2023-02-13 21:44 ` Dionna Glaze
2023-02-14 12:51 ` Gupta, Pankaj
2023-02-14 12:55 ` Gupta, Pankaj
2023-02-14 20:44 ` Dionna Glaze
2023-02-14 20:46 ` Gupta, Pankaj
[not found] ` <1743B21FF9509E5F.2641@groups.io>
2023-02-14 14:00 ` Gupta, Pankaj
2023-02-14 9:12 ` Gerd Hoffmann
2023-02-14 17:28 ` Dionna Glaze
2023-02-14 22:44 ` Lendacky, Thomas
2023-02-15 9:38 ` Gerd Hoffmann
2023-01-26 0:56 ` [PATCH v10 2/4] MdePkg: Introduce the SevMemoryAcceptance protocol Dionna Glaze
2023-01-26 1:24 ` Yao, Jiewen
2023-01-26 17:04 ` Dionna Glaze
2023-01-26 17:19 ` Ard Biesheuvel
2023-01-26 0:56 ` [PATCH v10 3/4] OvmfPkg: Implement AcceptAllUnacceptedMemory in AmdSevDxe Dionna Glaze
2023-01-26 0:56 ` [PATCH v10 4/4] OvmfPkg/PlatformPei: SEV-SNP make >=4GB unaccepted Dionna Glaze
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42ac1072-fca0-dba7-cc9d-9121eb272cce@amd.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox