From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (NAM02-SN1-obe.outbound.protection.outlook.com [40.107.96.40]) by mx.groups.io with SMTP id smtpd.web10.12431.1676028900844792775 for ; Fri, 10 Feb 2023 03:35:01 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=SABX1aki; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.96.40, mailfrom: pankaj.gupta@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T6wUDwCfrnDFClwUX1IbBVuQX9lDuwFdHFfHNyTWEJPw05ZNhzrDc+BDVN0RW72nVGHBvGUbzcVl/TSv+O7gkzs2SzArADOeOGMt1GGJIyWR5dUgVBZdv6oDz4iIiGFENZy4X51O0KqjPc/+i2cCv3be1YG44AwjY5oidDeLpRmir8GSmkTvlGJZPAosuSYJDkn+IqVD2G8kmbEp1bmg511ofjxPRYQJ8FQwYiK1sq4pTEP/5qFdBZJwD0QQlRw89/FTjuutEHU7s4NUJ94DBoxZg/U/0Ek/yQX1WVzyDyciSN5S4zw6Iy9GuYA30DOOcWMDvCE8i8W3U2GC82f6iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2pc8BhkvUOgqYHWzvp6k/iQTw5Estj/HgneWfiXK9ao=; b=VfRmxVNujz/iWIcNoX/3JYlwaMDUsFWSOmOO2IaafUAn1NZUBByiIQugFwDAQ0jsTButsS9OXDNsoaICXF5twxHycY/sEeHqPzhiMcXKASoj4KK7naELq8DJzgahbXd9/7XcPC1/5wtLJWM+jWZLUZ5FsmRVAO3j2zXDSdsDhFM04lAdH6lxHeRypgFcPNtvTyZ/RxrV/K/uxAiTNR/GPcd+MkI3V/nhsydLloXyUifjQ7hA6sBimG3UB+CNlZSbRXJjemIXKIr4X7PjQs2rvRu6xUvyoQP2LXVPSnrr2nSd7Jx4BFAxebd44VWV5dD7ffPVRq4ckivrWyzmqnGKLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2pc8BhkvUOgqYHWzvp6k/iQTw5Estj/HgneWfiXK9ao=; b=SABX1akig1aHzpDb155oWDTgf0bd5ZyMrVY+5sr5hJMwMkQvL5I4sJtZL48Ep63m7/A1IXyGc+Wkfyf9kfgcAgfAezF7hBusWW3ngjQ40jUlP+8BY9jooff1i1odKcStjQc7ZaA8AKB6CFcBXhm7mefgar27Flyub2Hz/M63kds= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB2810.namprd12.prod.outlook.com (2603:10b6:5:41::21) by CH3PR12MB7643.namprd12.prod.outlook.com (2603:10b6:610:152::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17; Fri, 10 Feb 2023 11:34:58 +0000 Received: from DM6PR12MB2810.namprd12.prod.outlook.com ([fe80::b84e:f638:fa40:27ef]) by DM6PR12MB2810.namprd12.prod.outlook.com ([fe80::b84e:f638:fa40:27ef%6]) with mapi id 15.20.6086.017; Fri, 10 Feb 2023 11:34:58 +0000 Message-ID: <42ac1072-fca0-dba7-cc9d-9121eb272cce@amd.com> Date: Fri, 10 Feb 2023 12:34:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [edk2-devel] [PATCH v10 1/4] OvmfPkg: Add memory acceptance event in AmdSevDxe To: Ard Biesheuvel Cc: Dionna Amalie Glaze , devel@edk2.groups.io, Gerd Hoffmann , James Bottomley , Jiewen Yao , Tom Lendacky , "Min M. Xu" , Andrew Fish , "Michael D. Kinney" References: <20230126005647.3019225-1-dionnaglaze@google.com> <20230126005647.3019225-2-dionnaglaze@google.com> <0d8f2b0b-1d62-3db6-34c9-e9ce39838bce@amd.com> From: "Gupta, Pankaj" In-Reply-To: X-ClientProxiedBy: FR0P281CA0138.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::7) To DM6PR12MB2810.namprd12.prod.outlook.com (2603:10b6:5:41::21) Return-Path: Pankaj.Gupta@amd.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB2810:EE_|CH3PR12MB7643:EE_ X-MS-Office365-Filtering-Correlation-Id: 0d8ea311-536f-43b8-09e4-08db0b5ad6bb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: An2rAw9i95fw7f9YiAZXNby3g1u951jWvlGry5UZNoyMwyHLbQ17jWfwHdxvBalUqIAw1ReoHvMUQHmJjHQ37TGSc5/whot10bj74hFqy7CtZGKHNB4jgdhSwe5UT9eEG9p29Upn7mBWvmv1ySWFHFlD4q1jCvbvjIGfEq4fufIyRzoskXCcDM7r+0NoeXGTLrsCgg97BOfIvpJozM/6ZvetRs9ws+xyAPyPJOkAAqmGUSkMMvo+4wfUzF1uPlEUmG2rQIx/+WBUi/RSkR4TTx3UBfAr9j4els0knfr5UE6DJ0LcdxIwO3wP/3nWJoRB/nMtrEVfN2ToueDQJVrAUf29AL59Tj3vPPTE5a9xII5Yrd5sXtcbdC0kWteABqEx/6uFmEGVcxVFPkdTU1Uio3jOHuy0s9AZJwJ/eFWKRoXYHhQqCAwyCN+jVjUBuPTdrbYH/mEGJn/dTEcxpzpwhxXzyhEvJ90KfoBXqtSlieEVl5l6IqtlyTu3sWVCP6Qji8MiX0LhWxwPxSL2tg807G8I/CjOhFM4jU5BFC7pQcO+7RBMqwPF0oaiH9bd+7HH/QQSToBvcJCPr++nMysPOCQuK2gxfw7JwBMY/2a9o81apJx1BgS35+kU01mRVAbPcbxd71GDu+BFcV2Ul9GcqGLl6wSSEpM3pvs7qA/2UAAI4LZ3rhoNorjlbHpd3HlYwqFehnbjvXaHaZPOm5eKCIRf2ZheQKt01LpA8ldV4mo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB2810.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(376002)(39860400002)(136003)(396003)(366004)(346002)(451199018)(66476007)(6916009)(66946007)(4326008)(8676002)(316002)(38100700002)(66556008)(83380400001)(31696002)(54906003)(86362001)(6486002)(31686004)(478600001)(6506007)(186003)(26005)(2906002)(6512007)(36756003)(6666004)(4744005)(5660300002)(41300700001)(8936002)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S1R5OUZVcUwrVkIwdk43VmdyUlNCZkZyK3NWUEFFTEg4ak9LOEZrUHRXOHl3?= =?utf-8?B?clprNjd3WXh4cE5EaUFzWGxSU0RuNUdaL1FoR1l2eTlxYm44ZTM1WnBkUUtW?= =?utf-8?B?TFlPVGR0RXdtTmcwODRheHNBRlpKNGFNaHJMQmM1bFdIMkt1ZHJwMDF3TkhL?= =?utf-8?B?MnpabHBnOVZ5WG9ueHJwNnlLNkVKS1ViNFRVbEJIbUl5OUtxNHFidm5ZK0Ur?= =?utf-8?B?TXdlWkNOWWhqLzIrT21GMGpWdVVLMWQ5alQ5TnZ6bFlubkdDY29tN1JiM3lp?= =?utf-8?B?czVFazkrOWVkcGJ5MDk4bVQyTXV5UnRmbGk2Z0tMRFRFTVpIWGVhTXF6VWty?= =?utf-8?B?Ky81cC94aFJNWWFPTFhsamZQSzVVRHJxNkxlVGlXT0tPR3RNQnUybEFFQjF1?= =?utf-8?B?TnJqK2Z5UkZwMjJtSzZTZmJmaElVbGtUMHpkK25KNTYyeW9xWVl5TkZWQ2Rn?= =?utf-8?B?cFJjSk1BQkI4WXhHUzVCK2QzM09wNVhyWmhPS2s0YmI5YkthZVJoYmtUQ1NI?= =?utf-8?B?V2lKMFlUVnlFeDBOTndvZWxCcXBXbTY0MUxsbUZDUlpyZGhWT1oxdEtvc0RT?= =?utf-8?B?ZHdTQzhQeTNpNStnMGlEeVhzMlFHa2V1ODZLTnhoUnVheTc2d2dlTStYWFJF?= =?utf-8?B?blg2Z3FzRTR3b2JYNCt2Z2tpcVpUY0VSckhPU2lQNTF5dGEzL0NQY0FWU204?= =?utf-8?B?VGFyZGFXeHBJQk1wV0VJQ01Qa0xwRXcwbithb2tQYVM1RmIzTnVNK3NOVFVJ?= =?utf-8?B?VENTZmNRS2tZdnh4VmJmTDUzcHhONHFxMnZ0VFFPakd2eGhkaHFhU21XWFM4?= =?utf-8?B?R3pQZ1RzVk4rMUFjcXExMXhBWTcyZGhmd0Q3VHR2Zk9UVzc4ZHNPNDFmUnZX?= =?utf-8?B?RE9RKzNvdnlZTTZsbWpUTHNLc1gzSHFoenpVNDlkOHg1SDVMaG9hODlqbEQz?= =?utf-8?B?N0ZUWk9oVHJYaGcydDBUM3pjSEpZQ0J4RmRJUTg2STVobk5HTFBOVm5UYXho?= =?utf-8?B?M2NTL0o5ZEZsazA4Q3J3SXVIWjFjd3RZYjNFNE1YUVRBUkVKcjR5eHoySktL?= =?utf-8?B?RTRkNDBIWGQrZDlGSytPYno5L0RiUStwblZaNS9wdzE1RlExcGFuSW0yK2pC?= =?utf-8?B?UjVqbFFtWTNWZC9oeFRBZ2dVcjZtbmNuQjJDUGRmbUU5aGhvY0xEQUVIcEEr?= =?utf-8?B?d1FkSVBoZE90ajZJTzdSYW9CeWJ6SHh5cGZ4ZDNlV04wcUQ0U2NOL2thZDRV?= =?utf-8?B?Ry8xRlhuZ3V2Uy9vSXBId1pqTC9SbVVTemw5ZVNBaExMOWE0V1RZT2RJSUN3?= =?utf-8?B?SzhSUHd5bndici81KzhmOEhoeGZVc0ZmcTIrdFMzREdGRzNaQ1RwVm9EelFZ?= =?utf-8?B?RTVKaEZ3TDdFc0VlZWdzSjhtWHBWQ3F5cTZkV0dKVmMvbUx0NGZBeDBuOGZ4?= =?utf-8?B?L1AvUDUzNTJ4ZHorKzMzZkZuZ0hHaWRvVEZjRHVVSTdVTW1XaHRZRU52M3RB?= =?utf-8?B?ZVFFbjVUQjNhTVEydk1lWnVxRWxDUTYxdW4zOENIQldUNG5TejFxblBPRHRB?= =?utf-8?B?dW5PSkEyeWJkNWw4VXFNejFFMnBEVmpibG9GOStnR01KbTVIaEFOQzM3WHph?= =?utf-8?B?VjB6RjFBdzF4Z09CblFoemkvN3ZCZHhNZFBreGk3RTloaThLaWtnSUd6Ymlv?= =?utf-8?B?RVpibEtKYk05Zkxqd1NHMWxLWWtkK3FlNmFlMHVDQkxmaWNlTTVIZjVWeGM0?= =?utf-8?B?a2xWbkVHaStKTXpZU0ROc2NVYU1MSUdNZzhHenFaVUlxWlpqa3ROUUF5Yk9k?= =?utf-8?B?Y3M2SE9wZU0yZTU1SFBPRk5DUVBDZFpkMWxqaFJzS1pTL1RpdzZxaU1VNmlo?= =?utf-8?B?SDZCQnJNenFkSVMrY0c1eXlMSmNjRmJKajh2N3BPSTZjNTdFS3VaVnpBREh3?= =?utf-8?B?VTRMZGo4ZmhnOC85NWlYVjdzM3ZTRnNBU290b0Jvc1JaSld4UjE0bGE4czRM?= =?utf-8?B?YmU5ekJxdnoxU3J3RmJqQVExQlgzRVVpOHlubjRuTkVtZ0RLMWlnY1VzRWhJ?= =?utf-8?B?N2IyaVhWM3drQWs3czlQTitwK2dWcUlWRno1a1QySVp4UnIwWk5KRzBuNGVo?= =?utf-8?Q?VDWYgN0OPGalH8mxwdKT7gGgZ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0d8ea311-536f-43b8-09e4-08db0b5ad6bb X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2810.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 11:34:58.2944 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: A1yp/fWlL8Vs+shDV93u1yDe8pgXOrf2qB34LDfjC1zg/SbrtY0/ZhSuXwl3hJmUBvflT59+oVf09JbzAl4KkA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7643 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit >> [1] >> ConvertPages: range 1000000 - 41AEFFF covers multiple entries^M >> Accepting all memory^M >> Accepting all memory^M > > This looks to me like it is entering the 'accept' path twice, and so > ExitBootServices() is failing twice, resulting in a failed boot. Thanks for having a look. Yes, I was also wondering why its calling "Accepting all memory" twice. I tried to put some printf in error path of "accept" but does seem hitting any. Also, accepting memory which is already accepted (pvalidate in case of SEV SNP) can be problematic. Thanks, Pankaj