public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
To: Eric Jin <eric.jin@intel.com>, edk2-devel@lists.01.org
Subject: Re: [edk2-test][Patch] uefi-sct/SctPkg:Correct 2 BlueTooth protocol GUID
Date: Mon, 12 Nov 2018 11:36:24 -0600	[thread overview]
Message-ID: <42ca56b5662135586dc5db1cc7793b589967e917.camel@arm.com> (raw)
In-Reply-To: <20181112083736.2136-1-eric.jin@intel.com>

Reviewed-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>

Thanks for the patch.
One minor comment inline, which can be in its own patch later.


On Mon, 2018-11-12 at 16:37 +0800, Eric Jin wrote:
> Correct BlueTooth Io Protocol Guid and
> BlueTooth Config Protocol Guid with the values
> defined in the UEFI spec
> 
> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Jin <eric.jin@intel.com>
> ---
>  .../EfiCompliant/BlackBoxTest/EfiCompliantBBTestPlatform_uefi.c     
> | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/EfiCom
> pliantBBTestPlatform_uefi.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/EfiCom
> pliantBBTestPlatform_uefi.c
> index 17df564..186e44b 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/EfiCom
> pliantBBTestPlatform_uefi.c
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/EfiCom
> pliantBBTestPlatform_uefi.c
> @@ -1,7 +1,7 @@
>  /** @file
>  
>    Copyright 2006 - 2016 Unified EFI, Inc.<BR>
> -  Copyright (c) 2010 - 2016, Intel Corporation. All rights
> reserved.<BR>
> +  Copyright (c) 2010 - 2018, Intel Corporation. All rights
> reserved.<BR>
>  
>    This program and the accompanying materials
>    are licensed and made available under the terms and conditions of
> the BSD License
> @@ -152,9 +152,9 @@ EFI_GUID gEfiBlueToothHcProtocolGuid = {
> 0xb3930571, 0xbeba, 0x4fc5, {0x92, 0x3,
>  
>  EFI_GUID gEfiBlueToothServiceBindingProtocolGuid = { 0x388278d3,
> 0x7b85, 0x42f0, {0xab, 0xa9, 0xfb, 0x4b, 0xfd, 0x69, 0xf5, 0xab }};
The above GUID should have been named as
"gEfiBlueToothIoServiceBindingProtocolGuid" instead of
gEfiBlueToothServiceBindingProtocolGuid to use the name from
specification. but this is not part of the patch anyway, so, ignoring
it for now.
>  
> -EFI_GUID gEfiBlueToothIoProtocolGuid = { 0x388278d3, 0x7b85, 0x42f0,
> {0xab, 0xa9, 0xfb, 0x4b, 0xfd, 0x69, 0xf5, 0xab }};
> +EFI_GUID gEfiBlueToothIoProtocolGuid = { 0x467313de, 0x4e30,
> 0x43f1,{ 0x94, 0x3e, 0x32, 0x3f, 0x89, 0x84, 0x5d, 0xb5 }};
>  
> -EFI_GUID gEfiBlueToothConfigProtocolGuid = { 0xb3930571, 0xbeba,
> 0x4fc5, {0x92, 0x3, 0x94, 0x27, 0x24, 0x2e, 0x6a, 0x43 }};
> +EFI_GUID gEfiBlueToothConfigProtocolGuid = { 0x62960cf3, 0x40ff,
> 0x4263,{0xa7, 0x7c, 0xdf, 0xde, 0xbd, 0x19, 0x1b, 0x4b }};
>  
>  EFI_GUID gEfiEapProtocolGuid = { 0x5d9f96db, 0xe731, 0x4caa, {0xa0,
> 0x0d, 0x72, 0xe1, 0x87, 0xcd, 0x77, 0x62 }};
>  



      reply	other threads:[~2018-11-12 17:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-12  8:37 [edk2-test][Patch] uefi-sct/SctPkg:Correct 2 BlueTooth protocol GUID Eric Jin
2018-11-12 17:36 ` Supreeth Venkatesh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42ca56b5662135586dc5db1cc7793b589967e917.camel@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox