From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.101.70; helo=foss.arm.com; envelope-from=supreeth.venkatesh@arm.com; receiver=edk2-devel@lists.01.org Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id B7E572118EF54 for ; Mon, 12 Nov 2018 09:36:29 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DAFB1A78; Mon, 12 Nov 2018 09:36:28 -0800 (PST) Received: from supven01-VirtualBox (unknown [10.119.49.60]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 89B483F5A0; Mon, 12 Nov 2018 09:36:28 -0800 (PST) Message-ID: <42ca56b5662135586dc5db1cc7793b589967e917.camel@arm.com> From: Supreeth Venkatesh To: Eric Jin , edk2-devel@lists.01.org Date: Mon, 12 Nov 2018 11:36:24 -0600 In-Reply-To: <20181112083736.2136-1-eric.jin@intel.com> References: <20181112083736.2136-1-eric.jin@intel.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Subject: Re: [edk2-test][Patch] uefi-sct/SctPkg:Correct 2 BlueTooth protocol GUID X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Nov 2018 17:36:29 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Reviewed-by: Supreeth Venkatesh Thanks for the patch. One minor comment inline, which can be in its own patch later. On Mon, 2018-11-12 at 16:37 +0800, Eric Jin wrote: > Correct BlueTooth Io Protocol Guid and > BlueTooth Config Protocol Guid with the values > defined in the UEFI spec > > Cc: Supreeth Venkatesh > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Eric Jin > --- > .../EfiCompliant/BlackBoxTest/EfiCompliantBBTestPlatform_uefi.c > | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/EfiCom > pliantBBTestPlatform_uefi.c b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/EfiCom > pliantBBTestPlatform_uefi.c > index 17df564..186e44b 100644 > --- a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/EfiCom > pliantBBTestPlatform_uefi.c > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/EfiCom > pliantBBTestPlatform_uefi.c > @@ -1,7 +1,7 @@ > /** @file > > Copyright 2006 - 2016 Unified EFI, Inc.
> - Copyright (c) 2010 - 2016, Intel Corporation. All rights > reserved.
> + Copyright (c) 2010 - 2018, Intel Corporation. All rights > reserved.
> > This program and the accompanying materials > are licensed and made available under the terms and conditions of > the BSD License > @@ -152,9 +152,9 @@ EFI_GUID gEfiBlueToothHcProtocolGuid = { > 0xb3930571, 0xbeba, 0x4fc5, {0x92, 0x3, > > EFI_GUID gEfiBlueToothServiceBindingProtocolGuid = { 0x388278d3, > 0x7b85, 0x42f0, {0xab, 0xa9, 0xfb, 0x4b, 0xfd, 0x69, 0xf5, 0xab }}; The above GUID should have been named as "gEfiBlueToothIoServiceBindingProtocolGuid" instead of gEfiBlueToothServiceBindingProtocolGuid to use the name from specification. but this is not part of the patch anyway, so, ignoring it for now. > > -EFI_GUID gEfiBlueToothIoProtocolGuid = { 0x388278d3, 0x7b85, 0x42f0, > {0xab, 0xa9, 0xfb, 0x4b, 0xfd, 0x69, 0xf5, 0xab }}; > +EFI_GUID gEfiBlueToothIoProtocolGuid = { 0x467313de, 0x4e30, > 0x43f1,{ 0x94, 0x3e, 0x32, 0x3f, 0x89, 0x84, 0x5d, 0xb5 }}; > > -EFI_GUID gEfiBlueToothConfigProtocolGuid = { 0xb3930571, 0xbeba, > 0x4fc5, {0x92, 0x3, 0x94, 0x27, 0x24, 0x2e, 0x6a, 0x43 }}; > +EFI_GUID gEfiBlueToothConfigProtocolGuid = { 0x62960cf3, 0x40ff, > 0x4263,{0xa7, 0x7c, 0xdf, 0xde, 0xbd, 0x19, 0x1b, 0x4b }}; > > EFI_GUID gEfiEapProtocolGuid = { 0x5d9f96db, 0xe731, 0x4caa, {0xa0, > 0x0d, 0x72, 0xe1, 0x87, 0xcd, 0x77, 0x62 }}; >