From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web11.47592.1598633815330399821 for ; Fri, 28 Aug 2020 09:56:55 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BZnE0D3f; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598633814; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GjyUa148AR+wFHmUHb/1uHD3ZoJhk/GNhiv/NUQpyU0=; b=BZnE0D3fsOacopssqt/dbsgjoaK72vjtPl0Ws38ZWXJ9aKr9FK4xmEbkvdcz8kJKtzsOir UaMfEbJL22dVNZjnZcD/HP/brdzm1T2AP7keIzH/DvL6EmKOwFSjEOnEpDnXY3uyCgwB5t x85W5sc4EphPKO1Nb6zKwL9PsobNiBE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-555-m3cQ0zOTNcSGvU3Herulhg-1; Fri, 28 Aug 2020 12:56:52 -0400 X-MC-Unique: m3cQ0zOTNcSGvU3Herulhg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E20E31074658; Fri, 28 Aug 2020 16:56:50 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-96.ams2.redhat.com [10.36.112.96]) by smtp.corp.redhat.com (Postfix) with ESMTP id 21F8F7A200; Fri, 28 Aug 2020 16:56:46 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH V2 2/2] BaseTools: Factorize GCC flags To: Leif Lindholm Cc: Pierre Gondois , "devel@edk2.groups.io" , "bob.c.feng@intel.com" , "liming.gao@intel.com" , Tomas Pilar , nd , Ard Biesheuvel References: <20200707083522.138944-1-pierre.gondois@arm.com> <20200707083522.138944-3-pierre.gondois@arm.com> <879fda8a-37bd-a902-6028-c879ed37fa28@redhat.com> <22b94ad5-db03-7280-4032-6ebf8dfc1d49@redhat.com> <518916e0-53cc-732b-cf1b-1e1b8d10a3b3@redhat.com> <20200827152511.GX1191@vanye> From: "Laszlo Ersek" Message-ID: <42cb48da-b932-7006-475b-d5259bcd0d8a@redhat.com> Date: Fri, 28 Aug 2020 18:56:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200827152511.GX1191@vanye> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US On 08/27/20 17:25, Leif Lindholm wrote: > On Thu, Aug 27, 2020 at 16:55:11 +0200, Laszlo Ersek wrote: >> On 08/27/20 10:32, Pierre Gondois wrote: >>> Hello Laszlo, >>> I thought Leif wanted to revert this modification. Should I apply >> your requested changes, or should this patch be reverted? >> >> The *other* patch in this series has indeed been reverted: >> >> - original commit: dbd546a32d5a ("BaseTools: Add gcc flag to warn on >> void* pointer arithmetic", 2020-07-21) >> >> - revert: 91e4bcb313f0 ("Revert "BaseTools: Add gcc flag to warn on >> void* pointer arithmetic"", 2020-07-24) >> >> I'm not sure what the intent was ultimately with this patch though. >> (I.e., keep it or revert it.) Personally I'm not calling for a revert; >> I'd just like the "-Os" duplication to be eliminated. Also it doesn't >> need to occur for this stable tag, just eventually. >> >> Leif, please comment! > > I did propose reverting it. But I asked for Ard's feedback on the > reason for why we had the break in the flags-chain, in case he > remembered (and he was on holiday at the time). > > Basically, I'm wondering whether we're better off changing this > behaviour or simply nuking GCC48. I use GCC48 daily -- it's the system compiler on RHEL7. My laptop runs RHEL7 -- I value stability above all. Thanks Laszlo