Re: [PATCH 00/15] Add a plugin LicenseCheck in open ci

["Laszlo Ersek" <lersek@redhat.com>]

On 07/29/20 03:32, Kinney, Michael D wrote:
> Hi Liming,
> 
> There are exception to PatchCheck as well for line endings and tabs.
> 
> Seems like a similar problem, and a single CI plugin could
> support all these cases.

The exceptions for LicenseCheck are individual files that package
maintainers (and contributors too) could customize. The primary use case
is permitting generated files to have no SPDX tag at all. PatchCheck
does not have a customizable exception list; it only considers general
rules that apply to the whole tree.

I did suggest "@file: generated" as a general marker for generated files
(which would opt them out of SPDX enforcement), here:
<https://bugzilla.tianocore.org/show_bug.cgi?id=2833#c1>.

I'm equally happy with an IgnoreFiles stanza in
"OvmfPkg/OvmfPkg.ci.yaml", or a marker like "@file: generated" in some
files under OvmfPkg. What's important to me is that we can control and
update the license checks for OvmfPkg/ files with OvmfPkg/ patches. That
is, in case we need to tweak the license check for some OvmfPkg/ file,
the corresponding patch should need OvmfPkg maintainer approval *only*.
Adding exceptions to PatchCheck has been difficult, as (a) it affects
all of edk2, (b) technically it needs to pass BaseTools review.

With the license check, I'm happy to have the mechanism under BaseTools
and/or CI, but the policy should be per package. Again my sole
motivation at this time is generated files that we need to check in for
whatever reason.

Thanks!
Laszlo