From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [216.205.24.74]) by mx.groups.io with SMTP id smtpd.web12.2406.1596014506969894651 for ; Wed, 29 Jul 2020 02:21:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HvJb1glR; spf=pass (domain: redhat.com, ip: 216.205.24.74, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596014506; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KQ6LZUyZ1Ni+8cJR98mrzjzXDRvKLKjWC98nqIerckc=; b=HvJb1glRA+STshUi6U8eJA2181gMPpBHW4eMyWDGE12K6qKsCX3HpBVH18RBV99wOA98x1 y/36ktexVn6ynfu18hKATUffw6eiopP5HzDanr6e6RLWlmopsToWIF6D4v9fAZ++WRHVMp tLcEMRgX4af/h6PwHLHcSgponVXEyNo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-457-QZMO9Mb3OYqlVsubn6PUHw-1; Wed, 29 Jul 2020 05:21:35 -0400 X-MC-Unique: QZMO9Mb3OYqlVsubn6PUHw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1CC0880046A; Wed, 29 Jul 2020 09:21:33 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-234.ams2.redhat.com [10.36.114.234]) by smtp.corp.redhat.com (Postfix) with ESMTP id 00AF78A16D; Wed, 29 Jul 2020 09:21:28 +0000 (UTC) Subject: Re: [PATCH 00/15] Add a plugin LicenseCheck in open ci To: "Kinney, Michael D" , "Gao, Liming" , "Zhang, Shenglei" , "devel@edk2.groups.io" Cc: Sean Brogan , Bret Barkelew , "Dong, Eric" , "Gao, Zhichao" , "Yao, Jiewen" , Chao Zhang , "Justen, Jordan L" , Maciej Rabeda , "Wu, Jiaxin" , "Fu, Siyuan" , "Wang, Jian J" , "Wu, Hao A" , Andrew Fish , "Ni, Ray" , "Lu, XiaoyuX" , Ard Biesheuvel , Leif Lindholm References: <20200720083709.17264-1-shenglei.zhang@intel.com> From: "Laszlo Ersek" Message-ID: <42dff41e-b38a-cd08-2ed1-35d83385dfac@redhat.com> Date: Wed, 29 Jul 2020 11:21:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 07/29/20 03:32, Kinney, Michael D wrote: > Hi Liming, > > There are exception to PatchCheck as well for line endings and tabs. > > Seems like a similar problem, and a single CI plugin could > support all these cases. The exceptions for LicenseCheck are individual files that package maintainers (and contributors too) could customize. The primary use case is permitting generated files to have no SPDX tag at all. PatchCheck does not have a customizable exception list; it only considers general rules that apply to the whole tree. I did suggest "@file: generated" as a general marker for generated files (which would opt them out of SPDX enforcement), here: . I'm equally happy with an IgnoreFiles stanza in "OvmfPkg/OvmfPkg.ci.yaml", or a marker like "@file: generated" in some files under OvmfPkg. What's important to me is that we can control and update the license checks for OvmfPkg/ files with OvmfPkg/ patches. That is, in case we need to tweak the license check for some OvmfPkg/ file, the corresponding patch should need OvmfPkg maintainer approval *only*. Adding exceptions to PatchCheck has been difficult, as (a) it affects all of edk2, (b) technically it needs to pass BaseTools review. With the license check, I'm happy to have the mechanism under BaseTools and/or CI, but the policy should be per package. Again my sole motivation at this time is generated files that we need to check in for whatever reason. Thanks! Laszlo