From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (EUR03-VE1-obe.outbound.protection.outlook.com [40.107.5.56]) by mx.groups.io with SMTP id smtpd.web12.7635.1657121278169071225 for ; Wed, 06 Jul 2022 08:27:58 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=DU52t0Ca; spf=pass (domain: arm.com, ip: 40.107.5.56, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=V3UBatSi/EfH1UjLJllZAgNB6UmDwHrvjPHvflmybP1ZCpDSopfjcfo9YkGO4bQFFD1Gxl5zBs6ZN4Vn+GuDSqTmyIdu8JjwuE8p9LjDsaaNK0qlVukwUo1wxe2vrE4cYk04VSUfkQ8BRH4eq2APPe++o8DVu+M3QGThGubInSdpk6nl/PtBf0VqtTGhWMSXeUjSnHtkHx6sHaSfXixfjbeF1yfTtI0JrjupBBFU0UxT6+ZN3FVBm+on+yOQmmsT3wNp+vy1KEYPSv5ztdjmdtA0UXMdxVJSC+v3tUpQYypEQepPnxrTb2qBIGs+ZhvZfW2IT0+E8vmnPjgo6e7LxA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z/6x3c6+r0TYH/ETBLUodnQ4YwGNyKdkiB1yR2Eh05Q=; b=QheOJjISvYmd131I8KiyYXHwz0wTw/EYzmU3xOopnAuipiXCD4+sm+AjmzMg46pk31zFAebfOt9UP0kRT9Zf4Ujq+1JLg8U8nAxP5gF8UpCja+V7wPtu6KS7iKdhth5yl7z6rGfcCgBI3jHDPYFVVBCDOtS7athLBEVr+raRJ1bD0bTwWilppsVFdOdcBVz+0dwcGQ1woMeAq4cBP6l5wvjyENVrwQihCrONTLRkOrjN/+iJCVj9O6629CJ/K7jXUgjDtSeCJB7ZxDOvPIubwUBl5/2FMJx4Ik5GIQZdOv+uGVibZ8Gbv1V/+zNbNMV6dtaQ6lQp9AeaYpsDN2ahtw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z/6x3c6+r0TYH/ETBLUodnQ4YwGNyKdkiB1yR2Eh05Q=; b=DU52t0CadPkFiB4AKidPpNazOYNlwdHm+bI8NYFaZzRfGdmafR926gm9n+BF5BX3dWXbApNULPK++D9Fzlq7mpEFkZB94DX8SujgnlrtskSmkls7PXLavjx4oPQUrItN+vh2MuSU9Vw0OBNMfncWyzsYCkpvcswTlbxEaVric1U= Received: from FR0P281CA0088.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::8) by AS8PR08MB7112.eurprd08.prod.outlook.com (2603:10a6:20b:403::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Wed, 6 Jul 2022 15:27:48 +0000 Received: from VE1EUR03FT012.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:1e:cafe::2) by FR0P281CA0088.outlook.office365.com (2603:10a6:d10:1e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 15:27:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT012.mail.protection.outlook.com (10.152.18.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 15:27:47 +0000 Received: ("Tessian outbound e5f49c5d38f9:v122"); Wed, 06 Jul 2022 15:27:47 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 371b614fec21dd60 X-CR-MTA-TID: 64aa7808 Received: from ddd66f8ec592.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9FAF4590-7DA4-4B3A-A7C3-5C4E0CF076CE.1; Wed, 06 Jul 2022 15:27:41 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ddd66f8ec592.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 06 Jul 2022 15:27:41 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cr+mP7xd6tRKA9WaQiGDvsFPIp9tY+chesS1hIeM8GML/x7C8pqvWimprMReBXxge4qldgWtTZqGCw4Cn71NETAK0TQDeM6ZT/IXFBKlyeYsPPkWr82LdL82CzGihQIJCScuzzDYe8P4OyQv8OCdrecp6n1cnkEgk/G/bk9XcdLMoyYKgekBUPGcDbUZT5AIUI3iUCF1PfCwD9pDQIeJNJ3dOa2wULzSrkkwbSv/GFSpwWV4jbue8PQ+9PahW/+bfZsS5SpNwQpBGJeSijQC1kmjqzrEQwANnx2+w3nFAP6RhDy+F4iRy/vtGFrD211U1RBmwfXxUZVtMwFPhGv2mA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z/6x3c6+r0TYH/ETBLUodnQ4YwGNyKdkiB1yR2Eh05Q=; b=gVODUmSpQBcs3HluwOT8M7rbL3F++17VcQM4dpCcl4U9hTDBuZs0juEr+whaoN11vh9xYUJ21jxNo1RDS5otLV16vgitD4xcE3MfEavsIo2FLLI893cepiP1GDuuZUawOdk1s2nGeKVdf+pBlrJWg1wEEV5plZJqCAW34cG6RSNeZOC9ESlNhwqk+GhCxFjf+9rkkMZeMrhJCs36lxqPxd1+YxcL9b3R1DDolKw14tAX22VbHDXrkttg5nqcA+ecDFak6cJhe41oxBMHV61zZZ8B1vtkBzS/mFt30d4B6Z42JvipfGpSA9FpPcGTIokTEqXQ88uQ9WZNgCcJLZBdRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z/6x3c6+r0TYH/ETBLUodnQ4YwGNyKdkiB1yR2Eh05Q=; b=DU52t0CadPkFiB4AKidPpNazOYNlwdHm+bI8NYFaZzRfGdmafR926gm9n+BF5BX3dWXbApNULPK++D9Fzlq7mpEFkZB94DX8SujgnlrtskSmkls7PXLavjx4oPQUrItN+vh2MuSU9Vw0OBNMfncWyzsYCkpvcswTlbxEaVric1U= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DBBPR08MB4363.eurprd08.prod.outlook.com (2603:10a6:10:ce::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.18; Wed, 6 Jul 2022 15:27:36 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::d562:5a52:f638:7fe9]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::d562:5a52:f638:7fe9%4]) with mapi id 15.20.5417.015; Wed, 6 Jul 2022 15:27:36 +0000 Message-ID: <42f974ce-0afb-4e07-7f34-60b02a6cd791@arm.com> Date: Wed, 6 Jul 2022 16:27:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v1 1/1] DynamicTablesPkg: Add support to specify FADT minor revision To: Pierre Gondois , devel@edk2.groups.io, meenakshi.aggarwal@nxp.com, Leif Lindholm CC: Alexei.Fedorov@arm.com, jbrasen@nvidia.com, Jagadeesh.Ujja@arm.com, Deepak.Pandey@arm.com, Chandni.Cherukuri@arm.com, Matteo.Carlini@arm.com, Akanksha.Jain2@arm.com, Ben.Adderson@arm.com, nd@arm.com References: <20220706114009.26492-1-sami.mujawar@arm.com> <6a6a750c-8daa-c383-6972-306bce254a23@arm.com> From: "Sami Mujawar" In-Reply-To: <6a6a750c-8daa-c383-6972-306bce254a23@arm.com> X-ClientProxiedBy: LO4P123CA0523.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2c5::7) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 6d3117fc-4d41-483e-0199-08da5f6414ee X-MS-TrafficTypeDiagnostic: DBBPR08MB4363:EE_|VE1EUR03FT012:EE_|AS8PR08MB7112:EE_ X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ctrQ8Pjpc7CONfJNmSUGvUi3RVpQdDiT+MtTYDqqunvHYkg4k+7JfqBvAyNSV6+3snv9mtdxKk+SxRctwu/CgMvTAPWWgiMEvP9MFPIeskChonCPoSw+ABhhaClgpLj8UP/LRdGxLf7fzczpk+JGgNMG4Sf/2+jnFudc6Ep2QL5nX3Xle/SuIheXC3XQAvCO1YZwZZkWEYPC78zxbiS0acIKxoXbaHI5cjSilyU0lzcL1M2VvTbwSkJPeR3oaB5jscnEVGqkvoQfvYkNtqSirOQeqCKr7fI233+OSBkJowkfwSB7lLYDy6TcrlHkPKfGmdsKHxjDRq78FGPRylPw3hOn5Fk1U/2eUtdM7+ubQ5gEts5oICOlRom1AX05jEHgVDB1BHIvDhIFibA9Mw8ZVnb6AzQDuQo0EV5HoGHUhh/UJsSwRkmcf/qOhvi95n4veu6goy35nxAbhjoBvqtGAFhGcRdVIUUOm+2wsTZmKGOW/fDH6OwN1jLeXP+QAh7Dg4MSdprhe6gikbaPyJMr0817cHAoC/twG6x8y6Mxf/pMfeh90pOZpudKC3wtXuIdmQ9JLQz35heoooZ/SMJYTH/YiVA+aI7OhkrgOXbTVr2UhCuYTTjSq+w5a54W3Arp8qDm+L7kyBa4WxCSBMO+DufKSro4uv/pVxw4Bhg9DaqyFS2am4a8KKoP8c0SQURefGgzyVtL4UI5E/MBOs4pWOtWPmtMzg+EJp7Q3yTcaemU3Dj3sTAcSABxyNwIMq473NTrz6avPmJAjqyACPoyjCEidmCWaPivyNbxdDgWY9ekS1OmIuuWywmNJ8G4EJe4O7pd8hMuGIUIziFJ8Qid0a5+MTP0dIsOVGJnlamJZoc+uWpS1DQl7K+k+elkf4mK X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(396003)(136003)(39860400002)(346002)(366004)(53546011)(6506007)(8936002)(478600001)(5660300002)(2906002)(41300700001)(66476007)(8676002)(4326008)(66556008)(38100700002)(44832011)(36756003)(186003)(966005)(6486002)(110136005)(31686004)(26005)(6512007)(31696002)(86362001)(2616005)(316002)(83380400001)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4363 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 75620adf-7c6c-4e1d-c1d2-08da5f640e0d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FfACeXMW2XucztzWm15CGLY4KrYL/86srM6Y80VEUDgEVB+EjHxkWJk+88PX9X1uXovZs841rFyGIyGJpqVh0UIlARYeS7UKIUhaW55TWiFG092BCNRsEDVTBeBGBqpl9sN/yORzNE3AJPIBkKP9emnJ+bpjqPjC+bV3E3ZTVbiduRUAzYdUcb14Za+rzFvCaaiDj+8nUEv8GDeGk2F2W6Z3GgOy9+WqpunNC5QJCyXcxom07mv4hzseoa6QOfO3Ze39gfT9R9cCRy0bVJ5udvUSd0Y95N5Iuc9/DMB7KjgdvG82ZvtBqid6vFo3B+iRPpDznbgOUGLVWqamrpKXGwgpWxz2oIg5NXPnPAMtTKrqGNvmoeO1Y7lLWnpqjqI8ZhdjWYUtsnwoPGIA4xQ9YxEKfyNIM/7I2clXal63cb2oBRAOtIyaun2v94UQwng933vyVXbR0R+BOY6+ejOzFe5ILmYqwGXQIcSSj4JEuCNgKmBXZXlC0ltTskjtP7g7dtPkSaTnFLv4mJuXekQ1NQ3q6fIIExkB3tLX0qU+4g9gAunrExCxdgoHXqShVSBDf3uf3wrBXb8sW3mMNmXUOkjgFAVdm5/Uxt1Kw5gLh/uRJvLhBUAIxyRzg8Vn6p7gwza7sEs0xI2hDyhQCzl6wCfwx5XX11g/T7vQXhkAtYAYUK+9wkxaLZRqVWA3diOxANpM+VCzIJO7hCmCx7ztFSxM8slS2JDrjg39olhOtl/+IZIyoZWvQ1jxPRxTRHH+GxTb58z5uoDo8Th+lNqlHmwuZ0MAQFz1tiP3caIDm5Mak0XMBJQASkk1nJv2hDIIHvwARV1BLCcy0eIMFCdzxdwlZbNvClDBxGOLSfT0yJh/sjvWUXO/kBjHI2IkDtIV X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(376002)(136003)(396003)(46966006)(36840700001)(40470700004)(36756003)(26005)(2616005)(6506007)(40460700003)(6512007)(47076005)(6486002)(186003)(82740400003)(83380400001)(336012)(31686004)(478600001)(53546011)(40480700001)(2906002)(966005)(44832011)(8676002)(70206006)(70586007)(4326008)(41300700001)(86362001)(82310400005)(8936002)(81166007)(5660300002)(36860700001)(31696002)(356005)(110136005)(316002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 15:27:47.7450 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6d3117fc-4d41-483e-0199-08da5f6414ee X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7112 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Pierre, On 06/07/2022 04:03 pm, Pierre Gondois wrote: > Hello Sami, > The only configuration manager not using ACPI 6.4 tables is at: > Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/Configuratio= nManager.c=20 > > > I think the minor version of its FADT table needs to be updated along=20 > with > this patch. Otherwise: > Thank you for bringing this up. As it stands the NXP platform would be using ACPI 6.4 which is the=20 default case, and this patch will not change that. So, downgrading this=20 to ACPI 6.2 may not be expected. I have copied the NXP package maintainers for further inputs. If needed,=20 I could submit a edk2-platforms patch as required. Regards, Sami Mujawar > Reviewed-by: > > Regards, > Pierre > > On 7/6/22 13:40, Sami Mujawar wrote: >> The CM_STD_OBJ_ACPI_TABLE_INFO.AcpiTableRevision can be used to specify >> the major revision number of the ACPI table that the generator must use. >> Although most ACPI tables only have a major revision number, the FADT >> table additionally has a minor revision number. >> >> The FADT generator currently defaults to setting the latest supported >> ACPI revision for the FADT table i.e. ACPI 6.4. This means that the=20 >> minor >> revision for the FADT table is always set to 4 and there is no provision >> for a user to specify the minor revision to be selected. >> >> Therefore, update CM_STD_OBJ_ACPI_TABLE_INFO to introduce a new field >> MinorRevision which can be used to specify the minor revision for an >> ACPI table. Also update the FADT generator to validate the supported >> FADT revisions ans use the specified minor revision for the FADT table >> if supported. If an unsupported minor revision is specified the FADT >> generator defaults to the latest supported minor revision. >> >> Since the CM_STD_OBJ_ACPI_TABLE_INFO.MinorRevision field is added to >> the end of the structure, it should not break existing platform code. >> >> Signed-off-by: Sami Mujawar >> --- >> The changes can be seen at: >> https://github.com/samimujawar/edk2/tree/2221_support_fadt_minor_rev_v1 >> >> DynamicTablesPkg/Include/StandardNameSpaceObjects.h | 10 ++++++- >> DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c | 29=20 >> ++++++++++++++++++-- >> =C2=A0 2 files changed, 36 insertions(+), 3 deletions(-) >> >> diff --git a/DynamicTablesPkg/Include/StandardNameSpaceObjects.h=20 >> b/DynamicTablesPkg/Include/StandardNameSpaceObjects.h >> index=20 >> 8d0c7da15a73e4910f9099c68f6e5cc2f06c0ecb..8ec3238225abe4fc16a7337c29ecd6= 55590b408f=20 >> 100644 >> --- a/DynamicTablesPkg/Include/StandardNameSpaceObjects.h >> +++ b/DynamicTablesPkg/Include/StandardNameSpaceObjects.h >> @@ -1,6 +1,6 @@ >> =C2=A0 /** @file >> =C2=A0 -=C2=A0 Copyright (c) 2017 - 2019, ARM Limited. All rights reserv= ed. >> +=C2=A0 Copyright (c) 2017 - 2022, Arm Limited. All rights reserved. >> =C2=A0 =C2=A0=C2=A0=C2=A0 SPDX-License-Identifier: BSD-2-Clause-Patent >> =C2=A0 @@ -105,6 +105,14 @@ typedef struct CmAStdObjAcpiTableInfo { >> =C2=A0=C2=A0=C2=A0 /// Generators shall populate this information using = the revision=20 >> of the >> =C2=A0=C2=A0=C2=A0 /// Configuration Manager=20 >> (CM_STD_OBJ_CONFIGURATION_MANAGER_INFO.Revision). >> =C2=A0=C2=A0=C2=A0 UINT32=C2=A0=C2=A0=C2=A0 OemRevision; >> + >> +=C2=A0 /// The minor revision of an ACPI table if required by the table= . >> +=C2=A0 /// Note: If this field is not populated (has value of Zero), th= en=20 >> the >> +=C2=A0 /// Generators shall populate this information based on the late= st=20 >> minor >> +=C2=A0 /// revision of the table that is supported by the generator. >> +=C2=A0 /// e.g. This field can be used to specify the minor revision to= =20 >> be set >> +=C2=A0 /// for the FADT table. >> +=C2=A0 UINT8=C2=A0=C2=A0=C2=A0=C2=A0 MinorRevision; >> =C2=A0 } CM_STD_OBJ_ACPI_TABLE_INFO; >> =C2=A0 =C2=A0 /** A structure used to describe the SMBIOS table generato= rs to=20 >> be invoked. >> diff --git=20 >> a/DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c=20 >> b/DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c >> index=20 >> 96295f539fb0505378e862edeef898be40257cdd..1d10ea55e2395c55291faa3c247e5c= 59e345650c=20 >> 100644 >> --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c >> +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c >> @@ -1,7 +1,7 @@ >> =C2=A0 /** @file >> =C2=A0=C2=A0=C2=A0 FADT Table Generator >> =C2=A0 -=C2=A0 Copyright (c) 2017 - 2021, ARM Limited. All rights reserv= ed. >> +=C2=A0 Copyright (c) 2017 - 2022, Arm Limited. All rights reserved. >> =C2=A0=C2=A0=C2=A0 SPDX-License-Identifier: BSD-2-Clause-Patent >> =C2=A0 =C2=A0=C2=A0=C2=A0 @par Reference(s): >> @@ -167,7 +167,7 @@ EFI_ACPI_6_4_FIXED_ACPI_DESCRIPTION_TABLE=20 >> AcpiFadt =3D { >> =C2=A0=C2=A0=C2=A0 // UINT16=C2=A0=C2=A0=C2=A0=C2=A0 ArmBootArch >> =C2=A0=C2=A0=C2=A0 EFI_ACPI_6_4_ARM_PSCI_COMPLIANT,=C2=A0 // {Template}:= ARM Boot=20 >> Architecture Flags >> =C2=A0=C2=A0=C2=A0 // UINT8=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 MinorRevision >> -=C2=A0 EFI_ACPI_6_4_FIXED_ACPI_DESCRIPTION_TABLE_MINOR_REVISION, >> +=C2=A0 EFI_ACPI_6_4_FIXED_ACPI_DESCRIPTION_TABLE_MINOR_REVISION, //=20 >> {Template} >> =C2=A0=C2=A0=C2=A0 // UINT64=C2=A0=C2=A0=C2=A0=C2=A0 XFirmwareCtrl >> =C2=A0=C2=A0=C2=A0 0, >> =C2=A0=C2=A0=C2=A0 // UINT64=C2=A0=C2=A0=C2=A0=C2=A0 XDsdt >> @@ -546,6 +546,31 @@ BuildFadtTable ( >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 goto error_handler; >> =C2=A0=C2=A0=C2=A0 } >> =C2=A0 +=C2=A0 // Update the MinorRevision for the FADT table if it has = been=20 >> specified >> +=C2=A0 // otherwise default to the latest FADT minor revision supported= . >> +=C2=A0 // Note: >> +=C2=A0 // Bits 0-3 - The low order bits correspond to the minor version= =20 >> of the >> +=C2=A0 //=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 specification version. >> +=C2=A0 // Bits 4-7 - The high order bits correspond to the version of t= he=20 >> ACPI >> +=C2=A0 //=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 specification errata. >> +=C2=A0 if (AcpiTableInfo->MinorRevision !=3D 0) { >> +=C2=A0=C2=A0=C2=A0 if (((AcpiTableInfo->MinorRevision & 0xF) >=3D >> + EFI_ACPI_6_2_FIXED_ACPI_DESCRIPTION_TABLE_MINOR_REVISION) && >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ((AcpiTableInfo->MinorRevisi= on & 0xF) <=3D >> + EFI_ACPI_6_4_FIXED_ACPI_DESCRIPTION_TABLE_MINOR_REVISION)) >> +=C2=A0=C2=A0=C2=A0 { >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 AcpiFadt.MinorVersion =3D AcpiTableInfo-= >MinorRevision; >> +=C2=A0=C2=A0=C2=A0 } else { >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 DEBUG (( >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 DEBUG_WARN, >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "WARNING: FADT: Unsupported = FADT Minor Revision 0x%x=20 >> specified, " \ >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "defaulting to FADT Minor Re= vision 0x%x\n", >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 AcpiTableInfo->MinorRevision= , >> + EFI_ACPI_6_4_FIXED_ACPI_DESCRIPTION_TABLE_MINOR_REVISION >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 )); >> +=C2=A0=C2=A0=C2=A0 } >> +=C2=A0 } >> + >> =C2=A0=C2=A0=C2=A0 // Update PmProfile Info >> =C2=A0=C2=A0=C2=A0 Status =3D FadtAddPmProfileInfo (CfgMgrProtocol); >> =C2=A0=C2=A0=C2=A0 if (EFI_ERROR (Status)) {