From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web10.2188.1575407133540980065 for ; Tue, 03 Dec 2019 13:05:33 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HSmGyd+K; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575407132; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lKz3p/MQO+Yi3JIDJXitj6uqaIB5L+l/h2q6rUYNFC8=; b=HSmGyd+KvRWUMj4heKsrd69IKegZTjS9ua+tjfd2TV1VtNJr7zrh0GEjk5roFROJPXwC7V +tmygMopsJcrHIboyw8Jmwyie15+/o/2BAk8zuOEICMjR5vgwkOW3r/ljaifTIPXvNOuNS E1NxpQ7MWzf/rlxlSca9vPPHgbHpQfA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-194--YKc3DSgNYCjJMH3zwUumg-1; Tue, 03 Dec 2019 16:05:29 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 609DB107ACC4; Tue, 3 Dec 2019 21:05:28 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-183.ams2.redhat.com [10.36.117.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id 65C665D6A7; Tue, 3 Dec 2019 21:05:24 +0000 (UTC) Subject: Re: [PATCH 79/79] UefiCpuPkg/Smm: Fix various typos To: Philippe Mathieu-Daude , devel@edk2.groups.io Cc: Antoine Coeur , Eric Dong , Ray Ni References: <20191203161602.15969-1-philmd@redhat.com> <20191203161602.15969-80-philmd@redhat.com> From: "Laszlo Ersek" Message-ID: <43147c4d-f9a1-ec9b-9ea8-891657c558a8@redhat.com> Date: Tue, 3 Dec 2019 22:05:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20191203161602.15969-80-philmd@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: -YKc3DSgNYCjJMH3zwUumg-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 12/03/19 17:16, Philippe Mathieu-Daude wrote: > From: Antoine Coeur > > Fix various typos in comments and documentation. > > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Reviewed-by: Philippe Mathieu-Daude > Signed-off-by: Philippe Mathieu-Daude > --- > UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h | 4 ++-- > UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.h | 4 ++-- > UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c | 4 ++-- > UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c | 2 +- > UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 4 ++-- > UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c | 4 ++-- > UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm | 2 +- > 7 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h b/UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h > index 39ca304b31e6..dbcd57e0ad42 100644 > --- a/UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h > +++ b/UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h > @@ -338,7 +338,7 @@ SmmCpuFeaturesSetSmmRegister ( > from the save state. > > @retval EFI_SUCCESS The register was read from Save State. > - @retval EFI_INVALID_PARAMTER Buffer is NULL. > + @retval EFI_INVALID_PARAMETER Buffer is NULL. > @retval EFI_UNSUPPORTED This function does not support reading Register. > > **/ > @@ -364,7 +364,7 @@ SmmCpuFeaturesReadSaveStateRegister ( > @param[in] Buffer Upon entry, this holds the new CPU register value. > > @retval EFI_SUCCESS The register was written to Save State. > - @retval EFI_INVALID_PARAMTER Buffer is NULL. > + @retval EFI_INVALID_PARAMETER Buffer is NULL. > @retval EFI_UNSUPPORTED This function does not support writing Register. > **/ > EFI_STATUS > diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.h b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.h > index 018e918360d3..da551cc4a6a6 100644 > --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.h > +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.h > @@ -138,7 +138,7 @@ GetPiResource ( > ); > > /** > - This functin initialize STM configuration table. > + This function initialize STM configuration table. > **/ > VOID > StmSmmConfigurationTableInit ( > @@ -169,7 +169,7 @@ GetStmResource ( > > /** > This function fixes up the address of the global variable or function > - referred in SmiEntry assembly files to be the absoute address. > + referred in SmiEntry assembly files to be the absolute address. > **/ > VOID > EFIAPI > diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c > index 72c2aeca4c13..6a2670d55918 100644 > --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c > +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c > @@ -68,7 +68,7 @@ CommonExceptionHandlerWorker ( > // > ArchRestoreExceptionContext (ExceptionType, SystemContext, ExceptionHandlerData); > // > - // Rlease spin lock for ApicId > + // Release spin lock for ApicId > // > ReleaseSpinLock (&ReservedVectors[ExceptionType].SpinLock); > break; > @@ -230,7 +230,7 @@ InitializeCpuExceptionHandlersWorker ( > IdtEntryCount = (IdtDescriptor.Limit + 1) / sizeof (IA32_IDT_GATE_DESCRIPTOR); > if (IdtEntryCount > CPU_EXCEPTION_NUM) { > // > - // CPU exeption library only setup CPU_EXCEPTION_NUM exception handler at most > + // CPU exception library only setup CPU_EXCEPTION_NUM exception handler at most > // > IdtEntryCount = CPU_EXCEPTION_NUM; > } > diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c > index ec705fc489af..e7977d49b771 100644 > --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c > +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c > @@ -1,5 +1,5 @@ > /** @file > - CPU exception handler library implemenation for SMM modules. > + CPU exception handler library implementation for SMM modules. > > Copyright (c) 2013 - 2017, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent > diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c > index bddb7a219ce4..a00786a8ebef 100644 > --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c > +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c > @@ -540,7 +540,7 @@ SmmCpuFeaturesSetSmmRegister ( > from the save state. > > @retval EFI_SUCCESS The register was read from Save State. > - @retval EFI_INVALID_PARAMTER Buffer is NULL. > + @retval EFI_INVALID_PARAMETER Buffer is NULL. > @retval EFI_UNSUPPORTED This function does not support reading Register. > > **/ > @@ -569,7 +569,7 @@ SmmCpuFeaturesReadSaveStateRegister ( > @param[in] Buffer Upon entry, this holds the new CPU register value. > > @retval EFI_SUCCESS The register was written to Save State. > - @retval EFI_INVALID_PARAMTER Buffer is NULL. > + @retval EFI_INVALID_PARAMETER Buffer is NULL. > @retval EFI_UNSUPPORTED This function does not support writing Register. > **/ > EFI_STATUS > diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c > index 52a376c27db1..f7f8afacffb5 100644 > --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c > +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c > @@ -913,7 +913,7 @@ AddPiResource ( > } > > // > - // Copy EndResource for intialization > + // Copy EndResource for initialization > // > mStmResourcesPtr = (UINT8 *)(UINTN)NewResource; > mStmResourceTotalSize = NewResourceSize; > @@ -1236,7 +1236,7 @@ LoadMonitor ( > /** > This function return BIOS STM resource. > Produced by SmmStm. > - Comsumed by SmmMpService when Init. > + Consumed by SmmMpService when Init. > > @return BIOS STM resource > > diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm b/UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm > index 5ee846e4f9ea..f09d8df1e6bc 100644 > --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm > +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm > @@ -15,7 +15,7 @@ > %include "StuffRsbNasm.inc" > > ; > -; Variables referrenced by C code > +; Variables referenced by C code > ; > > %define MSR_IA32_MISC_ENABLE 0x1A0 > Reviewed-by: Laszlo Ersek