From: "Laszlo Ersek" <lersek@redhat.com>
To: Rebecca Cran <rebecca@bsdio.com>,
devel@edk2.groups.io, leif.lindholm@linaro.org
Cc: Bob Feng <bob.c.feng@intel.com>,
Liming Gao <liming.gao@intel.com>,
Michael Kinney <michael.d.kinney@intel.com>,
Andrew Fish <afish@apple.com>
Subject: Re: [edk2-devel] [PATCH] Simplify edksetup.sh
Date: Mon, 15 Jul 2019 19:48:21 +0200 [thread overview]
Message-ID: <43230384-37ba-a03c-bc46-23b6403088b9@redhat.com> (raw)
In-Reply-To: <720144d6-20d0-bf18-f00c-e0cddfafd0f5@bsdio.com>
On 07/15/19 17:01, Rebecca Cran wrote:
> On 2019-07-15 08:55, Leif Lindholm wrote:
>>
>> For me, the question is more with being able to trivially discern
>> which patch does what. I agree they're all individually trivial, but
>> as a single patch there is enough going on at once that it makes it
>> easier for bugs to slip through review. (And we've had issues with
>> this in the past in edksetup.sh.)
>
>
>
> Thanks, I understand now. I'll resubmit the changes as a series.
I'm sorry, I shouldn't have followed up, but read Leif's response first
-- Leif expressed the same concern that I had, only better, and more
politely. :) My apologies for the snark!
Thanks
Laszlo
next prev parent reply other threads:[~2019-07-15 17:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 21:17 [PATCH] Simplify edksetup.sh Rebecca Cran
2019-07-12 16:05 ` [edk2-devel] " rebecca
2019-07-12 22:21 ` Laszlo Ersek
2019-07-15 14:40 ` rebecca
2019-07-15 14:55 ` Leif Lindholm
2019-07-15 15:01 ` rebecca
2019-07-15 17:48 ` Laszlo Ersek [this message]
2019-07-15 17:45 ` Laszlo Ersek
2019-07-15 22:37 ` rebecca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43230384-37ba-a03c-bc46-23b6403088b9@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox