Re: [PATCH 4/5] OvmfPkg/VirtioNetDxe: map virtio-net transmit request buffer

[Laszlo Ersek <lersek@redhat.com>]

On 09/05/17 14:41, Laszlo Ersek wrote:
> On 09/01/17 13:24, Brijesh Singh wrote:
>> When device is behind the IOMMU, driver is require to pass the device
>> address of transmit buffer for the bus master operations.
>>
>> The patch uses VirtioMapAllBytesInSharedBuffer() to map transmit buffer
>> system physical address to the device address.
>>
>> Since the transmit buffers are returned back to caller in
>> VirtioNetGetStatus() hence we use OrderCollection library interface to
>> save the host to device address mapping. After the buffer is succesfully
>> transmited we do reverse lookup in OrderCollection data structure to get
>> the host address for the transmitted device address.
>>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Tom Lendacky <thomas.lendacky@amd.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
>> ---
>>  OvmfPkg/VirtioNetDxe/VirtioNet.inf      |   1 +
>>  OvmfPkg/VirtioNetDxe/VirtioNet.h        |  19 +++
>>  OvmfPkg/VirtioNetDxe/SnpGetStatus.c     |  30 +++-
>>  OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c | 157 ++++++++++++++++++++
>>  OvmfPkg/VirtioNetDxe/SnpTransmit.c      |  37 ++++-
>>  5 files changed, 232 insertions(+), 12 deletions(-)
> 
> I have some preliminary comments for this patch. This is by no means a
> full review.

(12) The helper functions should be called VirtioNet*, not Virtio*.

Thanks
Laszlo