From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B60EF21EA35BF for ; Tue, 5 Sep 2017 05:41:32 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3BD2940236; Tue, 5 Sep 2017 12:44:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3BD2940236 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-185.rdu2.redhat.com [10.10.120.185]) by smtp.corp.redhat.com (Postfix) with ESMTP id 043827FB6E; Tue, 5 Sep 2017 12:44:19 +0000 (UTC) From: Laszlo Ersek To: Brijesh Singh , edk2-devel@lists.01.org Cc: Jordan Justen , Tom Lendacky , Ard Biesheuvel References: <1504265045-19008-1-git-send-email-brijesh.singh@amd.com> <1504265045-19008-5-git-send-email-brijesh.singh@amd.com> <09699a1f-9bc9-02d1-f7d0-99cd9d42051e@redhat.com> Message-ID: <432582e6-a54f-7c85-1726-17bf419fc541@redhat.com> Date: Tue, 5 Sep 2017 14:44:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <09699a1f-9bc9-02d1-f7d0-99cd9d42051e@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 05 Sep 2017 12:44:21 +0000 (UTC) Subject: Re: [PATCH 4/5] OvmfPkg/VirtioNetDxe: map virtio-net transmit request buffer X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Sep 2017 12:41:32 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/05/17 14:41, Laszlo Ersek wrote: > On 09/01/17 13:24, Brijesh Singh wrote: >> When device is behind the IOMMU, driver is require to pass the device >> address of transmit buffer for the bus master operations. >> >> The patch uses VirtioMapAllBytesInSharedBuffer() to map transmit buffer >> system physical address to the device address. >> >> Since the transmit buffers are returned back to caller in >> VirtioNetGetStatus() hence we use OrderCollection library interface to >> save the host to device address mapping. After the buffer is succesfully >> transmited we do reverse lookup in OrderCollection data structure to get >> the host address for the transmitted device address. >> >> Cc: Ard Biesheuvel >> Cc: Jordan Justen >> Cc: Tom Lendacky >> Cc: Laszlo Ersek >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Brijesh Singh >> --- >> OvmfPkg/VirtioNetDxe/VirtioNet.inf | 1 + >> OvmfPkg/VirtioNetDxe/VirtioNet.h | 19 +++ >> OvmfPkg/VirtioNetDxe/SnpGetStatus.c | 30 +++- >> OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c | 157 ++++++++++++++++++++ >> OvmfPkg/VirtioNetDxe/SnpTransmit.c | 37 ++++- >> 5 files changed, 232 insertions(+), 12 deletions(-) > > I have some preliminary comments for this patch. This is by no means a > full review. (12) The helper functions should be called VirtioNet*, not Virtio*. Thanks Laszlo