Re: [edk2-devel] [PATCH] NanhuDev:Add BOSC NanhuDev platform

["Ran Wang" <wangran@bosc.ac.cn>]

Add Leif and Michael to cc list

Hi Sunil,

On 2024/3/14 13:28, Sunil V L wrote:
> Hi Ran,
> 
> On Mon, Mar 11, 2024 at 12:29:53PM +0800, Ran Wang wrote:
>> Hi Sunil,
>>
>> On 2024/3/8 19:44, Sunil V L wrote:
>>> On Fri, Mar 08, 2024 at 12:31:26AM -0800, WangYang wrote:
>>>> Hi,Sunil V L
>>>>
>>>>       How about this status.
>>>>
>>>>
>>>>> -----原始邮件-----
>>>>> 发件人: WangYang <wangyang@bosc.ac.cn>
>>>>> 发送时间: 2024-02-28 14:34:11 (星期三)
>>>>> 收件人: devel@edk2.groups.io, sunilvl@ventanamicro.com
>>>>> 抄送: "Yang Wang" <wangyang@bosc.ac.cn>, "Ran Wang" <wangran@bosc.ac.cn>, "YunFeng Yang" <yangyunfeng@bosc.ac.cn>, "YaXing Guo" <guoyaxing@bosc.ac.cn>, "Bamvor Jian ZHANG" <zhangjian@bosc.ac.cn>
>>>>> 主题: [edk2-devel] [PATCH] NanhuDev:Add BOSC NanhuDev platform
>>>>>
>>>>> This commit adds the initial support for BOSC's
>>>>> nanhu platform which provides up to 2 RISC-V RV64
>>>>> processor cores.
>>>>>
>>> Somehow I missed this when you sent first. What do you mean by "initial
>>> support" here?
>>>
>>
>> The "initial" means so far we only support minimal system (CPU + UART), will
>> integrate more periphrals in the future.
>>
> Okay. Can you boot an OS with this minimal support? Why not add full
> support itself? Since the structure needs to be reviewed, it would be
> better to have complete picture IMO.
> 

Currently we could boot Linux kernel image which is integraed as a FV 
(declared in *.fdf, but not inclued in this patch). I guess this 
solution cannot be accepted by upstream, right?.

Or we could also add an PCIE controller driver patch to load kernel from 
NVME card.

Regards,
Ran

>>> Looks like you are following old integrated opensbi approach.
>>> If so, I recommend you to look at payload design. You can see Sophgo
>>> board as reference.
>>
>> Thanks for advices, so we need to rebase our work on
>> Silicon/Sophgo/SG2042Pkg/Sec/Sec* rather than
>> RISC-V/PlatformPkg/Universal/Sec/Riscv64/Sec*, right?
>>
> Yes. It is better to use edk2 as a payload for opensbi.
> 
>>> Also, please remember to CC all maintainers as per Maintainers.txt.
>>
>> Does the "all maintainers" mean all mentioned in Maintainers.txt, or just
>> RISC-V related?
>>
> You need to copy the overall maintainers for edk2-platforms repo (Mike
> and Leif). They need to approve the structure for your platforms. Then
> you can copy RISC-V maintainers. Add one patch to update the maintainers
> for your platform as well.
> 
> Thanks,
> Sunil



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116856): https://edk2.groups.io/g/devel/message/116856
Mute This Topic: https://groups.io/mt/104619268/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-