From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web11.14410.1583341208404464274 for ; Wed, 04 Mar 2020 09:00:08 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Qn/UERUO; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583341207; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WNfBq1m+5XOP5YZxrxiov+DytixkXS3B5uqkGJLQS2o=; b=Qn/UERUOVNjD00wPPxEFIyaFJGli6nAi/UF9bViTM1cNzcVBuVtp5tfgYZfNVxZdhQqQTB euqoLvsxdoEu0rfJhBD8VdENRWW9/NtW7O2EmvnjusMEwsMY+TX8AmABH80WJbSJUk75JQ Y/xVACnOmFh1Jrc4Aa9ISzD7h8qmWqU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-279-GnscsU2_MwW76mHGMDAewg-1; Wed, 04 Mar 2020 12:00:02 -0500 X-MC-Unique: GnscsU2_MwW76mHGMDAewg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8837E18C35B4; Wed, 4 Mar 2020 17:00:01 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-59.ams2.redhat.com [10.36.117.59]) by smtp.corp.redhat.com (Postfix) with ESMTP id 831F461075; Wed, 4 Mar 2020 17:00:00 +0000 (UTC) Subject: Re: [PATCH v2] UefiCpuPkg/MpInitLib: ECC issue. To: GuoMinJ , devel@edk2.groups.io Cc: Eric Dong , Ray Ni References: From: "Laszlo Ersek" Message-ID: <433ed593-10f3-ecce-166b-02473a6682af@redhat.com> Date: Wed, 4 Mar 2020 17:59:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 03/04/20 12:39, GuoMinJ wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2553 > > The comment haven't indicate the output attribute. > > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: GuoMinJ > --- > UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 2 +- > UefiCpuPkg/Library/MpInitLib/MpLib.h | 2 +- > UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c > index a987c32109..096d1c9b4b 100644 > --- a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c > +++ b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c > @@ -821,7 +821,7 @@ MpInitLibEnableDisableAP ( > This funtion will try to invoke platform specific microcode shadow logic to > relocate microcode update patches into memory. > > - @param[in] CpuMpData The pointer to CPU MP Data structure. > + @param[in, out] CpuMpData The pointer to CPU MP Data structure. > > @retval EFI_SUCCESS Shadow microcode success. > @retval EFI_OUT_OF_RESOURCES No enough resource to complete the operation. > diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/MpInitLib/MpLib.h > index 455cb3f09a..06556197c3 100644 > --- a/UefiCpuPkg/Library/MpInitLib/MpLib.h > +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h > @@ -658,7 +658,7 @@ GetProcessorNumber ( > This funtion will try to invoke platform specific microcode shadow logic to > relocate microcode update patches into memory. > > - @param[in] CpuMpData The pointer to CPU MP Data structure. > + @param[in, out] CpuMpData The pointer to CPU MP Data structure. > > @retval EFI_SUCCESS Shadow microcode success. > @retval EFI_OUT_OF_RESOURCES No enough resource to complete the operation. > diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c > index 17b60903c5..a548fed23f 100644 > --- a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c > +++ b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c > @@ -644,7 +644,7 @@ MpInitLibEnableDisableAP ( > This funtion will try to invoke platform specific microcode shadow logic to > relocate microcode update patches into memory. > > - @param[in] CpuMpData The pointer to CPU MP Data structure. > + @param[in, out] CpuMpData The pointer to CPU MP Data structure. > > @retval EFI_SUCCESS Shadow microcode success. > @retval EFI_OUT_OF_RESOURCES No enough resource to complete the operation. > Reviewed-by: Laszlo Ersek