* [PATCH v2] UefiCpuPkg/MpInitLib: ECC issue.
@ 2020-03-04 11:39 GuoMinJ
2020-03-04 14:35 ` [edk2-devel] " Dong, Eric
2020-03-04 16:59 ` Laszlo Ersek
0 siblings, 2 replies; 3+ messages in thread
From: GuoMinJ @ 2020-03-04 11:39 UTC (permalink / raw)
To: devel; +Cc: GuoMinJ, Eric Dong, Ray Ni, Laszlo Ersek
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2553
The comment haven't indicate the output attribute.
Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
---
UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 2 +-
UefiCpuPkg/Library/MpInitLib/MpLib.h | 2 +-
UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
index a987c32109..096d1c9b4b 100644
--- a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
+++ b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
@@ -821,7 +821,7 @@ MpInitLibEnableDisableAP (
This funtion will try to invoke platform specific microcode shadow logic to
relocate microcode update patches into memory.
- @param[in] CpuMpData The pointer to CPU MP Data structure.
+ @param[in, out] CpuMpData The pointer to CPU MP Data structure.
@retval EFI_SUCCESS Shadow microcode success.
@retval EFI_OUT_OF_RESOURCES No enough resource to complete the operation.
diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/MpInitLib/MpLib.h
index 455cb3f09a..06556197c3 100644
--- a/UefiCpuPkg/Library/MpInitLib/MpLib.h
+++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h
@@ -658,7 +658,7 @@ GetProcessorNumber (
This funtion will try to invoke platform specific microcode shadow logic to
relocate microcode update patches into memory.
- @param[in] CpuMpData The pointer to CPU MP Data structure.
+ @param[in, out] CpuMpData The pointer to CPU MP Data structure.
@retval EFI_SUCCESS Shadow microcode success.
@retval EFI_OUT_OF_RESOURCES No enough resource to complete the operation.
diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
index 17b60903c5..a548fed23f 100644
--- a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
+++ b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
@@ -644,7 +644,7 @@ MpInitLibEnableDisableAP (
This funtion will try to invoke platform specific microcode shadow logic to
relocate microcode update patches into memory.
- @param[in] CpuMpData The pointer to CPU MP Data structure.
+ @param[in, out] CpuMpData The pointer to CPU MP Data structure.
@retval EFI_SUCCESS Shadow microcode success.
@retval EFI_OUT_OF_RESOURCES No enough resource to complete the operation.
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib: ECC issue.
2020-03-04 11:39 [PATCH v2] UefiCpuPkg/MpInitLib: ECC issue GuoMinJ
@ 2020-03-04 14:35 ` Dong, Eric
2020-03-04 16:59 ` Laszlo Ersek
1 sibling, 0 replies; 3+ messages in thread
From: Dong, Eric @ 2020-03-04 14:35 UTC (permalink / raw)
To: devel@edk2.groups.io, newexplorerj@gmail.com; +Cc: Ni, Ray, Laszlo Ersek
Reviewed-by: Eric Dong <eric.dong@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of GuoMinJ
Sent: Wednesday, March 4, 2020 7:39 PM
To: devel@edk2.groups.io
Cc: GuoMinJ <newexplorerj@gmail.com>; Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Laszlo Ersek <lersek@redhat.com>
Subject: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib: ECC issue.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2553
The comment haven't indicate the output attribute.
Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
---
UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 2 +-
UefiCpuPkg/Library/MpInitLib/MpLib.h | 2 +-
UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
index a987c32109..096d1c9b4b 100644
--- a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
+++ b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
@@ -821,7 +821,7 @@ MpInitLibEnableDisableAP (
This funtion will try to invoke platform specific microcode shadow logic to
relocate microcode update patches into memory.
- @param[in] CpuMpData The pointer to CPU MP Data structure.
+ @param[in, out] CpuMpData The pointer to CPU MP Data structure.
@retval EFI_SUCCESS Shadow microcode success.
@retval EFI_OUT_OF_RESOURCES No enough resource to complete the operation.
diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/MpInitLib/MpLib.h
index 455cb3f09a..06556197c3 100644
--- a/UefiCpuPkg/Library/MpInitLib/MpLib.h
+++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h
@@ -658,7 +658,7 @@ GetProcessorNumber (
This funtion will try to invoke platform specific microcode shadow logic to
relocate microcode update patches into memory.
- @param[in] CpuMpData The pointer to CPU MP Data structure.
+ @param[in, out] CpuMpData The pointer to CPU MP Data structure.
@retval EFI_SUCCESS Shadow microcode success.
@retval EFI_OUT_OF_RESOURCES No enough resource to complete the operation.
diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
index 17b60903c5..a548fed23f 100644
--- a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
+++ b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
@@ -644,7 +644,7 @@ MpInitLibEnableDisableAP (
This funtion will try to invoke platform specific microcode shadow logic to
relocate microcode update patches into memory.
- @param[in] CpuMpData The pointer to CPU MP Data structure.
+ @param[in, out] CpuMpData The pointer to CPU MP Data structure.
@retval EFI_SUCCESS Shadow microcode success.
@retval EFI_OUT_OF_RESOURCES No enough resource to complete the operation.
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] UefiCpuPkg/MpInitLib: ECC issue.
2020-03-04 11:39 [PATCH v2] UefiCpuPkg/MpInitLib: ECC issue GuoMinJ
2020-03-04 14:35 ` [edk2-devel] " Dong, Eric
@ 2020-03-04 16:59 ` Laszlo Ersek
1 sibling, 0 replies; 3+ messages in thread
From: Laszlo Ersek @ 2020-03-04 16:59 UTC (permalink / raw)
To: GuoMinJ, devel; +Cc: Eric Dong, Ray Ni
On 03/04/20 12:39, GuoMinJ wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2553
>
> The comment haven't indicate the output attribute.
>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
> ---
> UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 2 +-
> UefiCpuPkg/Library/MpInitLib/MpLib.h | 2 +-
> UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
> index a987c32109..096d1c9b4b 100644
> --- a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
> +++ b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
> @@ -821,7 +821,7 @@ MpInitLibEnableDisableAP (
> This funtion will try to invoke platform specific microcode shadow logic to
> relocate microcode update patches into memory.
>
> - @param[in] CpuMpData The pointer to CPU MP Data structure.
> + @param[in, out] CpuMpData The pointer to CPU MP Data structure.
>
> @retval EFI_SUCCESS Shadow microcode success.
> @retval EFI_OUT_OF_RESOURCES No enough resource to complete the operation.
> diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/MpInitLib/MpLib.h
> index 455cb3f09a..06556197c3 100644
> --- a/UefiCpuPkg/Library/MpInitLib/MpLib.h
> +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h
> @@ -658,7 +658,7 @@ GetProcessorNumber (
> This funtion will try to invoke platform specific microcode shadow logic to
> relocate microcode update patches into memory.
>
> - @param[in] CpuMpData The pointer to CPU MP Data structure.
> + @param[in, out] CpuMpData The pointer to CPU MP Data structure.
>
> @retval EFI_SUCCESS Shadow microcode success.
> @retval EFI_OUT_OF_RESOURCES No enough resource to complete the operation.
> diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
> index 17b60903c5..a548fed23f 100644
> --- a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
> +++ b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
> @@ -644,7 +644,7 @@ MpInitLibEnableDisableAP (
> This funtion will try to invoke platform specific microcode shadow logic to
> relocate microcode update patches into memory.
>
> - @param[in] CpuMpData The pointer to CPU MP Data structure.
> + @param[in, out] CpuMpData The pointer to CPU MP Data structure.
>
> @retval EFI_SUCCESS Shadow microcode success.
> @retval EFI_OUT_OF_RESOURCES No enough resource to complete the operation.
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-04 17:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-04 11:39 [PATCH v2] UefiCpuPkg/MpInitLib: ECC issue GuoMinJ
2020-03-04 14:35 ` [edk2-devel] " Dong, Eric
2020-03-04 16:59 ` Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox