public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Jeff Booher-Kaeding <Jeff.Booher-Kaeding@arm.com>
To: shrishail <shrishail.patil@microchip.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "eric.jin@intel.com" <eric.jin@intel.com>,
	Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>
Subject: Re: [edk2-test][PATCH V2 2/3] Adding HII to IHVSCT
Date: Mon, 5 Aug 2019 21:21:37 +0000	[thread overview]
Message-ID: <438b5f78345635da3f63012acaefc510ca0abfab.camel@arm.com> (raw)
In-Reply-To: <20190801070326.1852-4-shrishail.patil@microchip.com>

Reviewed-by: Jeff Booher-Kaeding <Jeff.Booher-Kaeding@arm.com>

On Thu, 2019-08-01 at 12:33 +0530, shrishail wrote:
> From: Shrishail Patil <Shrishail.Patil@microchip.com>
>
> Adding HII Config Access Protocol to IHVSCT
> This patch contains the changes to build/compilation Changes.
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shrishail patil <shrishail.patil@microchip.com>
> ---
> uefi-sct/SctPkg/CommonGenFramework.bat | 2 +-
> uefi-sct/SctPkg/CommonGenFramework.sh  | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/uefi-sct/SctPkg/CommonGenFramework.bat b/uefi-
> sct/SctPkg/CommonGenFramework.bat
> index 5c614eaa..8e75d8a8 100644
> --- a/uefi-sct/SctPkg/CommonGenFramework.bat
> +++ b/uefi-sct/SctPkg/CommonGenFramework.bat
> @@ -279,7 +279,7 @@ rem  copy
> %ProcessorType%\IhvUsbHcTest.efi                         %Framework%\
> T
>    copy
> %ProcessorType%\IhvUsb2HcTest.efi                        %Framework%\
> Test\ > NUL
>    copy
> %ProcessorType%\IhviScsiInitiatorNameBBTest.efi          %Framework%\
> Test\ > NUL
>    copy
> %ProcessorType%\IhvStorageSecurityCommandBBTest.efi      %Framework%\
> Test\ > NUL
> -
> +  copy
> %ProcessorType%\IhvHIIConfigAccessBBTest.efi             %Framework%\
> Test\ > NUL
nit: sections not sepertated
>    rem *********************************************
>    rem Copy the UEFI 2.1 Test Cases for IHV
>    rem *********************************************
> diff --git a/uefi-sct/SctPkg/CommonGenFramework.sh b/uefi-
> sct/SctPkg/CommonGenFramework.sh
> index c422034a..f0d1527b 100755
> --- a/uefi-sct/SctPkg/CommonGenFramework.sh
> +++ b/uefi-sct/SctPkg/CommonGenFramework.sh
> @@ -312,7 +312,7 @@ then
>    cp
> $ProcessorType/IhvUsb2HcTest.efi                        $Framework/Te
> st/ > NUL
>    cp
> $ProcessorType/IhviScsiInitiatorNameBBTest.efi          $Framework/Te
> st/ > NUL
>    cp
> $ProcessorType/IhvStorageSecurityCommandBBTest.efi      $Framework/Te
> st/ > NUL
> -
> +  cp
> $ProcessorType/IhvHIIConfigAccessBBTest.efi             $Framework/Te
> st/ > NUL
nit: sections not seperated
>    # *********************************************
>    # Copy the UEFI 2.1 Test Cases for IHV
>    # *********************************************
> --
> 2.22.0.windows.1
>
>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

  reply	other threads:[~2019-08-05 21:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-01  7:03 [edk2-test][PATCH V2 1/3] Adding FMP to IHVSCT shrishail
2019-08-01  7:03 ` [edk2-test][PATCH V2 1/3] Adding HII Config Access Protocol shrishail
2019-08-05 21:15   ` Jeff Booher-Kaeding
2019-08-01  7:03 ` [edk2-test][PATCH V2 2/3] Adding FMP to IHVSCT shrishail
2019-08-05 21:23   ` Jeff Booher-Kaeding
2019-08-01  7:03 ` [edk2-test][PATCH V2 2/3] Adding HII " shrishail
2019-08-05 21:21   ` Jeff Booher-Kaeding [this message]
2019-08-01  7:03 ` [edk2-test][PATCH V2 3/3] Adding FMP " shrishail
2019-08-05 21:23   ` Jeff Booher-Kaeding
2019-08-01  7:03 ` [edk2-test][PATCH V2 3/3] Adding HII " shrishail
2019-08-05 21:19   ` Jeff Booher-Kaeding
2019-08-05 21:08 ` [edk2-test][PATCH V2 1/3] Adding FMP " Jeff Booher-Kaeding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=438b5f78345635da3f63012acaefc510ca0abfab.camel@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox