From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (EUR03-AM7-obe.outbound.protection.outlook.com [40.107.105.59]) by mx.groups.io with SMTP id smtpd.web11.22941.1669132120665270123 for ; Tue, 22 Nov 2022 07:48:41 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=qtmRZfAs; spf=pass (domain: arm.com, ip: 40.107.105.59, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fim0DUEe5wzIW0/tVNfEYn7R+bDx+6tx0HZ9rAWqSwM=; b=qtmRZfAsCvjY+QjFzPFUJ9iHFUKHe4r293SgJ60msY3srYdQlgsdwq3Dfgs2T8CPf8u1RiPcoI+KjWcnb77F7V9rvDAl8JoRE2jAeITvECIwvw0MUXi2GlFbzO1LMr9CEUnizIUIcujA6jMLxJJcPAeIVFBhz53QLB+jtpws6Qk= Received: from ZR0P278CA0198.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:44::12) by PAXPR08MB7670.eurprd08.prod.outlook.com (2603:10a6:102:244::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Tue, 22 Nov 2022 15:48:35 +0000 Received: from VI1EUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:910:44:cafe::63) by ZR0P278CA0198.outlook.office365.com (2603:10a6:910:44::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15 via Frontend Transport; Tue, 22 Nov 2022 15:48:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT041.mail.protection.outlook.com (100.127.145.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Tue, 22 Nov 2022 15:48:34 +0000 Received: ("Tessian outbound 58faf9791229:v130"); Tue, 22 Nov 2022 15:48:34 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 0e00319290a189b1 X-CR-MTA-TID: 64aa7808 Received: from 5ceb9d4bc440.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 54928428-30CE-4809-A8BF-CD3D864C6E0F.1; Tue, 22 Nov 2022 15:48:27 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5ceb9d4bc440.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 22 Nov 2022 15:48:27 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V/WKHDKQEFWVS7JyjNgpS+dXACeojAQwm4Qu8y8cHkE9dH9PqpQ/9vXiRUxMi2K54rM93XxzPCKtN23R+aG5tgbSumfw3Fznn/lG4WwFK+aE6rDsxtkMo/T9SjOE1mfOLoS90uQRrAUk7U16MkWvKnOWbOZ0uUtYwJRwUj/VxoxXddktYKQyw9zT943CZmm+0znLmwWIzGIjmSHK67PDCMjJhKyUAnC2xnLlAxu+gKCXdh3/Lq0g7S3cdOpr+ZSq9LuXnAIYRoIqT/Ywl2hXCOK14N8mUgkLXFg4gKxLyHXVLl/QpTGyFMTC7ebdRGoq2ld1eoWeI3CDUY+mljp1lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fim0DUEe5wzIW0/tVNfEYn7R+bDx+6tx0HZ9rAWqSwM=; b=OHR8m8Yjz4nH2gyl2lkvUHHG/b6snwF5LmMZhIqKwBZGxVomMD5dcPIzOWkhISv1swmqkb98kwVb9OovUNzHW4at+pPzTPoay0vdawCYPMCIQ5U0oU/U313Fq2BBrsaGIa0rzmIuOD9BaB3Vop5DfygdsQcQr3h9dDSQHOAHJN7GKpT8CrOqIpQfyYDbHIVI2aIT7BFW9F98ybVv8NFd93OKGbnv7QK+IJ4+YXJzu5l7wI2dZL/NGn28yc62lfKIpEVzNgHD3YC80/iuNz8GoPg89F3rSqA/z0DHDGfi92TgFhF80878a+62Xz9CM7NhxsBhe4r9y8vEZjSnSKWfJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fim0DUEe5wzIW0/tVNfEYn7R+bDx+6tx0HZ9rAWqSwM=; b=qtmRZfAsCvjY+QjFzPFUJ9iHFUKHe4r293SgJ60msY3srYdQlgsdwq3Dfgs2T8CPf8u1RiPcoI+KjWcnb77F7V9rvDAl8JoRE2jAeITvECIwvw0MUXi2GlFbzO1LMr9CEUnizIUIcujA6jMLxJJcPAeIVFBhz53QLB+jtpws6Qk= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DB9PR08MB8203.eurprd08.prod.outlook.com (2603:10a6:10:39e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Tue, 22 Nov 2022 15:48:26 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::eca2:349c:4dbf:7f10]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::eca2:349c:4dbf:7f10%9]) with mapi id 15.20.5857.017; Tue, 22 Nov 2022 15:48:25 +0000 Message-ID: <439675da-662c-6825-6471-5c5c2f6fa0ed@arm.com> Date: Tue, 22 Nov 2022 15:48:24 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 3/3] CloudHv:arm: add kernel load driver into dsc/fdf To: Jianyong Wu , devel@edk2.groups.io Cc: ardb+tianocore@kernel.org, justin.he@arm.com, "nd@arm.com" References: <20220916024620.114084-1-jianyong.wu@arm.com> <20220916024620.114084-4-jianyong.wu@arm.com> From: "Sami Mujawar" In-Reply-To: <20220916024620.114084-4-jianyong.wu@arm.com> X-ClientProxiedBy: LO6P265CA0030.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ff::20) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|DB9PR08MB8203:EE_|VI1EUR03FT041:EE_|PAXPR08MB7670:EE_ X-MS-Office365-Filtering-Correlation-Id: e390ad85-8fef-41b7-fa05-08dacca10388 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: eRRfiUfIbuT5p2+zkRWAfC5CsQeE8HK6gmjP2tG+6hurIep0Tdce7XZ/0o56WY/c0e26AJxJUU0a7Ks3ma/YuzyqSsX79EhBrV6L58+PDffsuiTn7t0xJKdV9oKDzwG54H8yteTrD4mzgZpIu8YeRBYHqHDp21y5WsQ+39cBUyqvRR+IucwSWNpFN4rGrHePTVpFAtUPjDYymQdAU52epZGSrlXEueokxp6udrYEFW1gbNwU7npnxpm9yCiPAwVFsSRxPXvPMZTOl8N5LEgQSzGXcMWeTY2iS+OKUWZROk6N88gjVtcgebpMWYvkMr7KUo5YvwhUPgtmynAEA2etrl+U7crdqxtDdtkQRRfIfLnJssyPR/6RTbuFV8bIAlnfYhXw5Vh8blVBJ2XlWuEBFuc3q4F+jhn1B7b0ziBRGuHR3qkWZbk/muXHOhoDesofRXtESii4hSW+z/ePvr3xIpfHsY6k1pB9VDkU1OJ8GW9uQpRa52HY6v9AvqBryMroLWjh87nFAn9qwep9AZFWMllhQTDPTrlrXpY+njilcznAK2LIZKE4cOYtIOctpGmU3jasavOdwFymDoZl5kjUi3pykFWTez/ZqVDnHJTFhuEPUMsjWOeulBlK7EjWXMnHKpgUFKz/eGdnfYKAcNJptW/DfsZlo4V7YQEyFQYCXwRQPQB9FvIIVx5WJwHdFcx9BHLpHhUo5JNKr2siI85mC1mDYyhTtZxisroanAb9MXA= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(39860400002)(376002)(396003)(366004)(451199015)(44832011)(5660300002)(66476007)(66946007)(6512007)(66556008)(26005)(8936002)(53546011)(6506007)(33964004)(316002)(186003)(2616005)(8676002)(41300700001)(83380400001)(4326008)(36756003)(38100700002)(2906002)(31696002)(86362001)(478600001)(6486002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8203 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 03d03911-092f-4656-a785-08dacca0fe18 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: U2OaXLS350nYPzcE+focOmyHwciDng01AoeV5DxvbEPLp0oCkSmIwo/eqeRajLgIiKZgjdUCEmKfFg6R26clYtECe1XTXf4aVfgJRiHnz1KpY8DrMWmTK4hIAGuvSOO4II6+xPuQIjQ+ugRkj1c6UhbpVhdzGSxM1fnsg4W7xIrZU45Zn+Y4k6tgkolntc+OGXQl60TlN+d8laLxygVNT7wZ/G83JJ7/AGEl0FVe/KohDSU5Q6Lld+56kRBBvodXmEEIqE006XcTkAJDOu/eCDPiw9BtYfDtkMMHGgZ47VWh/srZXr0ok85gIEHF2Fwz8xiA/rd+4yBeO4lcylzhEyUv7O5RWG3+pMZjhSy2MMSFSuhIqo68WqpBCREO8sNIMetvgayvo40MGUryz/xiH45mgmF6lHIxSYkfGyhLIURvOC2/S8CJYf0OLDiof7nIb+JK5vpcnKGR6aBxaHEwqX7pZ/CaOeeWW2LGXiYMiIIXOTuUWdYqlS3GBHWziiVJ9lRqDJq6PBeqyu9Gq2SqfiIEBRHKmf4aSBxgJYvaWf4Wi9aay3rBVd8wtJlNeUl9QEc+49TOj4UkCM+0hW80raVLUWeU/mA9rQbgCL65YUrAEGku5NaGQ+SQoSlsEPma9zSAl2j4YDcGzor+D+TXt77ijVtvx9cxXnnc/WFePVSHxFJHOLWdVy8zKigyhqiMwD8rmnQLQSOkrZAGmE05w+FQAbZFg/zXx+9qr6/9Pbw= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(376002)(136003)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(6486002)(6506007)(6512007)(53546011)(47076005)(26005)(186003)(36756003)(2616005)(2906002)(478600001)(33964004)(336012)(40460700003)(40480700001)(82740400003)(83380400001)(31696002)(86362001)(356005)(81166007)(36860700001)(82310400005)(8936002)(41300700001)(31686004)(70206006)(44832011)(70586007)(8676002)(4326008)(5660300002)(316002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2022 15:48:34.6049 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e390ad85-8fef-41b7-fa05-08dacca10388 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7670 Content-Type: multipart/alternative; boundary="------------vorTXnPHGjv0hF0GqBP0qJcM" --------------vorTXnPHGjv0hF0GqBP0qJcM Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Jianyong, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 16/09/2022 03:46 am, Jianyong Wu wrote: > As CloudHv kernel load fs driver is implemented, add it into dsc/fdf. > > Signed-off-by: Jianyong Wu > --- > ArmVirtPkg/ArmVirtCloudHv.dsc | 8 +++++++- > ArmVirtPkg/ArmVirtCloudHv.fdf | 1 + > .../CloudHvKernelLoaderFsDxe/CloudHvKernelLoaderFsDxe.inf | 1 - > 3 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/ArmVirtPkg/ArmVirtCloudHv.dsc b/ArmVirtPkg/ArmVirtCloudHv.dsc > index 7ca7a391d9..92ccd4ef12 100644 > --- a/ArmVirtPkg/ArmVirtCloudHv.dsc > +++ b/ArmVirtPkg/ArmVirtCloudHv.dsc > @@ -37,13 +37,15 @@ > # Virtio Support > VirtioLib|OvmfPkg/Library/VirtioLib/VirtioLib.inf > VirtioMmioDeviceLib|OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceLib.inf > + QemuFwCfgLib|OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibMmio.inf [SAMI] How does this work for CloudHv? > + QemuLoadImageLib|OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.inf > > ArmPlatformLib|ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf > > TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf > - PlatformBootManagerLib|ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > + PlatformBootManagerLib|ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf [SAMI] I believe this brings the dependency on QemuBootOrderLib which requires QemuFwCfgLib. Is there a way to to implement QemuBootOrderLibNull to remove the dependency on QemuFwCfgLib? The QemuBootOrderLib APIs ConnectDevicesFromQem(),StoreQemuBootOrder(),SetBootOrderFromQemu () and GetFrontPageTimeoutFromQemu ()  could return something like EFI_UNSUPPORTED in QemuBootOrderLibNull. Can you check, please? [/SAMI] > PlatformBmPrintScLib|OvmfPkg/Library/PlatformBmPrintScLib/PlatformBmPrintScLib.inf > CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf > FrameBufferBltLib|MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf > @@ -330,6 +332,10 @@ > NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf > NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf > } > + ArmVirtPkg/CloudHvKernelLoaderFsDxe/CloudHvKernelLoaderFsDxe.inf { > + > + NULL|OvmfPkg/Library/BlobVerifierLibNull/BlobVerifierLibNull.inf > + } > > # > # SCSI Bus and Disk Driver > diff --git a/ArmVirtPkg/ArmVirtCloudHv.fdf b/ArmVirtPkg/ArmVirtCloudHv.fdf > index 81c539590a..15b9c13c59 100644 > --- a/ArmVirtPkg/ArmVirtCloudHv.fdf > +++ b/ArmVirtPkg/ArmVirtCloudHv.fdf > @@ -180,6 +180,7 @@ READ_LOCK_STATUS = TRUE > INF MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthManagerDxe.inf > INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > INF MdeModulePkg/Application/UiApp/UiApp.inf > + INF ArmVirtPkg/CloudHvKernelLoaderFsDxe/CloudHvKernelLoaderFsDxe.inf > > # > # SCSI Bus and Disk Driver > diff --git a/ArmVirtPkg/CloudHvKernelLoaderFsDxe/CloudHvKernelLoaderFsDxe.inf b/ArmVirtPkg/CloudHvKernelLoaderFsDxe/CloudHvKernelLoaderFsDxe.inf > index b7aa6ebb4e..f7b53d0747 100644 > --- a/ArmVirtPkg/CloudHvKernelLoaderFsDxe/CloudHvKernelLoaderFsDxe.inf > +++ b/ArmVirtPkg/CloudHvKernelLoaderFsDxe/CloudHvKernelLoaderFsDxe.inf > @@ -24,7 +24,6 @@ > EmbeddedPkg/EmbeddedPkg.dec > MdePkg/MdePkg.dec > OvmfPkg/OvmfPkg.dec > - UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec [SAMI] This should be part of patch 1/1. > > [LibraryClasses] > BaseLib --------------vorTXnPHGjv0hF0GqBP0qJcM Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi Jianyong,

Please find my response inline marked [SAMI].

Regards,

Sami Mujawar

On 16/09/2022 03:46 am, Jianyong Wu wrote:
As CloudHv kernel load fs driver is implemented, add it into dsc/fdf.

Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
---
 ArmVirtPkg/ArmVirtCloudHv.dsc                             | 8 +++++++-
 ArmVirtPkg/ArmVirtCloudHv.fdf                             | 1 +
 .../CloudHvKernelLoaderFsDxe/CloudHvKernelLoaderFsDxe.inf | 1 -
 3 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/ArmVirtPkg/ArmVirtCloudHv.dsc b/ArmVirtPkg/ArmVirtCloudHv.dsc
index 7ca7a391d9..92ccd4ef12 100644
--- a/ArmVirtPkg/ArmVirtCloudHv.dsc
+++ b/ArmVirtPkg/ArmVirtCloudHv.dsc
@@ -37,13 +37,15 @@
   # Virtio Support
   VirtioLib|OvmfPkg/Library/VirtioLib/VirtioLib.inf
   VirtioMmioDeviceLib|OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceLib.inf
+  QemuFwCfgLib|OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibMmio.inf
[SAMI] How does this work for CloudHv? 
+  QemuLoadImageLib|OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.inf
 
   ArmPlatformLib|ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf
 
   TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf
   CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
   BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf
-  PlatformBootManagerLib|ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
+  PlatformBootManagerLib|ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf

[SAMI] I believe this brings the dependency on QemuBootOrderLib which requires QemuFwCfgLib. Is there a way to to implement QemuBootOrderLibNull to remove the dependency on QemuFwCfgLib? The QemuBootOrderLib APIs  ConnectDevicesFromQem(), StoreQemuBootOrder(), SetBootOrderFromQemu () and GetFrontPageTimeoutFromQemu ()  could return something like EFI_UNSUPPORTED in QemuBootOrderLibNull.

Can you check, please?

[/SAMI]

   PlatformBmPrintScLib|OvmfPkg/Library/PlatformBmPrintScLib/PlatformBmPrintScLib.inf
   CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf
   FrameBufferBltLib|MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf
@@ -330,6 +332,10 @@
       NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf
       NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf
   }
+  ArmVirtPkg/CloudHvKernelLoaderFsDxe/CloudHvKernelLoaderFsDxe.inf {
+    <LibraryClasses>
+      NULL|OvmfPkg/Library/BlobVerifierLibNull/BlobVerifierLibNull.inf
+  }
 
   #
   # SCSI Bus and Disk Driver
diff --git a/ArmVirtPkg/ArmVirtCloudHv.fdf b/ArmVirtPkg/ArmVirtCloudHv.fdf
index 81c539590a..15b9c13c59 100644
--- a/ArmVirtPkg/ArmVirtCloudHv.fdf
+++ b/ArmVirtPkg/ArmVirtCloudHv.fdf
@@ -180,6 +180,7 @@ READ_LOCK_STATUS   = TRUE
   INF MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthManagerDxe.inf
   INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
   INF MdeModulePkg/Application/UiApp/UiApp.inf
+  INF ArmVirtPkg/CloudHvKernelLoaderFsDxe/CloudHvKernelLoaderFsDxe.inf
 
   #
   # SCSI Bus and Disk Driver
diff --git a/ArmVirtPkg/CloudHvKernelLoaderFsDxe/CloudHvKernelLoaderFsDxe.inf b/ArmVirtPkg/CloudHvKernelLoaderFsDxe/CloudHvKernelLoaderFsDxe.inf
index b7aa6ebb4e..f7b53d0747 100644
--- a/ArmVirtPkg/CloudHvKernelLoaderFsDxe/CloudHvKernelLoaderFsDxe.inf
+++ b/ArmVirtPkg/CloudHvKernelLoaderFsDxe/CloudHvKernelLoaderFsDxe.inf
@@ -24,7 +24,6 @@
   EmbeddedPkg/EmbeddedPkg.dec
   MdePkg/MdePkg.dec
   OvmfPkg/OvmfPkg.dec
-  UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec
[SAMI] This should be part of patch 1/1.
 
 [LibraryClasses]
   BaseLib
--------------vorTXnPHGjv0hF0GqBP0qJcM--