From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: philmd@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Mon, 23 Sep 2019 09:03:51 -0700 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3100820260 for ; Mon, 23 Sep 2019 16:03:51 +0000 (UTC) Received: by mail-wr1-f70.google.com with SMTP id z8so5035805wrs.14 for ; Mon, 23 Sep 2019 09:03:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ATW0t6ysrI2gJTZEYmOG0K0eRx7OyVMl1KeSsxtWXXk=; b=G/MhjA+SzNmG0d3/8cZT2hvGhBvj9Qn00mIZYFXln8PZMdzfbzBrUqIdR42Hq7QfoT QZ4LGLnXmrsJAYJM5cWmP3VzmSNDvK8yhfhwK6EUwcMPta8zEcCEynx9hKoQj/8bx0DK cUEwuOxef9HRzkY++9inAQ1Cg4Zpe23u7GoNzAhTYOKGisXQOe7NXu9B/hB8RYmXggDo I9g8D4wwZ04cV9lx4SRhTmPAdpatTpa1z6ULobmptZ+Ia4hp48HamVTNIBqbRUp4XKN6 svvQmFNiA/VbbgyitRcIxflIb/WmYYf/vUF05uIL4kRqWSTr8+yB6d/tPJvtW8Di22g1 Jflw== X-Gm-Message-State: APjAAAU69TcqMKe9fmKWsJgNzcUqx1eQ4iqoalqQx/EzhSbMWNjCaokc MVgNMN7J30EdQyR4JsUBG291/emy3YkZrTGbnMgVRB91SuBwqghipV6t2aXN4mjlrRzGay2jAAd RzJq07BzkGneChw== X-Received: by 2002:adf:fe0f:: with SMTP id n15mr102629wrr.343.1569254629881; Mon, 23 Sep 2019 09:03:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqweUTyxWw1ri13TKLUC7bxctTd+j3rm0zqmExzdEQPDN6dBIoJxyKNxxYAV/SZtqI3tXa+YgA== X-Received: by 2002:adf:fe0f:: with SMTP id n15mr102605wrr.343.1569254629648; Mon, 23 Sep 2019 09:03:49 -0700 (PDT) Received: from [192.168.1.115] (240.red-88-21-68.staticip.rima-tde.net. [88.21.68.240]) by smtp.gmail.com with ESMTPSA id t8sm11139211wrx.76.2019.09.23.09.03.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Sep 2019 09:03:48 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH 20/35] NetworkPkg/Ip4Dxe: fix NetLibDestroyServiceChild() call To: devel@edk2.groups.io, lersek@redhat.com Cc: Jiaxin Wu , Siyuan Fu References: <20190917194935.24322-1-lersek@redhat.com> <20190917194935.24322-21-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: <43c9182e-1f77-716f-dbd1-92512eb208e4@redhat.com> Date: Mon, 23 Sep 2019 18:03:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190917194935.24322-21-lersek@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 9/17/19 9:49 PM, Laszlo Ersek wrote: > Both NetLibDestroyServiceChild() and EFI_SERVICE_BINDING_DESTROY_CHILD > take an EFI_HANDLE for the "ChildHandle" parameter, not an (EFI_HANDLE*). > > This patch fixes a real bug. > > Cc: Jiaxin Wu > Cc: Siyuan Fu > Signed-off-by: Laszlo Ersek > --- > > Notes: > possibly only build-tested > > NetworkPkg/Ip4Dxe/Ip4If.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/NetworkPkg/Ip4Dxe/Ip4If.c b/NetworkPkg/Ip4Dxe/Ip4If.c > index 44b8d9fc8faf..53a333037f94 100644 > --- a/NetworkPkg/Ip4Dxe/Ip4If.c > +++ b/NetworkPkg/Ip4Dxe/Ip4If.c > @@ -592,7 +592,7 @@ Ip4SetAddress ( > Interface->Controller, > Interface->Image, > &gEfiArpServiceBindingProtocolGuid, > - &Interface->ArpHandle > + Interface->ArpHandle > ); > > Interface->ArpHandle = NULL; > @@ -657,7 +657,7 @@ ON_ERROR: > Interface->Controller, > Interface->Image, > &gEfiArpServiceBindingProtocolGuid, > - &Interface->ArpHandle > + Interface->ArpHandle I'm surprise this one never triggered unexpected behaviors, it looks easy to reach. Reviewed-by: Philippe Mathieu-Daude > ); > > return Status; >