From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 03 Oct 2019 04:05:21 -0700 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 53C7A10C0928; Thu, 3 Oct 2019 11:05:21 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-154.rdu2.redhat.com [10.10.120.154]) by smtp.corp.redhat.com (Postfix) with ESMTP id 90D6819C69; Thu, 3 Oct 2019 11:05:20 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 18/35] NetworkPkg/DxeNetLib: fix type typo in NetLibGetMacAddress() From: "Laszlo Ersek" To: Jiaxin Wu , Siyuan Fu Cc: edk2-devel-groups-io Reply-To: devel@edk2.groups.io, lersek@redhat.com References: <20190917194935.24322-1-lersek@redhat.com> <20190917194935.24322-19-lersek@redhat.com> <7d0793cc-4c91-56c6-e3cb-08d28a6fbe4f@redhat.com> Message-ID: <43e41bf7-02ff-cd8c-e8f7-74c1918e8c7e@redhat.com> Date: Thu, 3 Oct 2019 13:05:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <7d0793cc-4c91-56c6-e3cb-08d28a6fbe4f@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.66]); Thu, 03 Oct 2019 11:05:21 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Pinging NetworkPkg maintainers again. Please? Thanks Laszlo On 09/26/19 14:14, Laszlo Ersek wrote: > Jiaxin, Siyuan, > > can you please review this patch? > > Thanks > Laszlo > > On 09/17/19 21:49, Laszlo Ersek wrote: >> NetLibGetSnpHandle() returns an EFI_HANDLE, not an (EFI_HANDLE*). >> NetLibGetMacAddress() only uses the return value ("SnpHandle") for a >> NULL-check. Fix the type of "SnpHandle". >> >> This patch is a no-op. >> >> Cc: Jiaxin Wu >> Cc: Siyuan Fu >> Signed-off-by: Laszlo Ersek >> --- >> >> Notes: >> lightly tested: MAC strings are displayed in UiApp >> >> NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c >> index 8e2f720666ea..a39c20be3d34 100644 >> --- a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c >> +++ b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c >> @@ -2182,7 +2182,7 @@ NetLibGetMacAddress ( >> EFI_SIMPLE_NETWORK_MODE SnpModeData; >> EFI_MANAGED_NETWORK_PROTOCOL *Mnp; >> EFI_SERVICE_BINDING_PROTOCOL *MnpSb; >> - EFI_HANDLE *SnpHandle; >> + EFI_HANDLE SnpHandle; >> EFI_HANDLE MnpChildHandle; >> >> ASSERT (MacAddress != NULL); >> > > > >