Re: [edk2-devel] [PATCH] RISC-V/PlatformPkg: Fix compilation breakage in OpenSBI

["Loic Devulder" <ldevulder@suse.com>]

[-- Attachment #1: Type: text/plain, Size: 1357 bytes --]

On Thu, Mar 25, 2021 at 01:46 AM, Abner Chang wrote:

> 
> Hi Loic,
> The current edk2 RISC-V is incorporated with opensbi v0.8, please check
> below link
> https://github.com/riscv/riscv-uefi-edk2-docs

Yes, I think this is the version I used. In fact I followed https://github.com/tianocore/edk2-platforms#submodules to add the needed submodule.

> 
> We have to update below library with the latest opensbi with your changes,
> 
> https://github.com/tianocore/edk2-platforms/tree/master/Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib
> 
> 
> I believe your changes don't impact the build and the functionalities
> because we don't use those parameters in edk2.

Sounds like yes. I tested in qemu without any issue, but that was not a full regression test ;-)

> 
> However, this change should be adopted with Edk2OpenSbiLib upgrade.
> Daniel is currently working on edk2 RISC-V OVMF and also updated opensbi
> to the latest version. However there is a compatible issue when switching
> mode and we are fixing it now.
> We can share more information with you if you would like to know.

So if this fix will be included in Daniel's changes that fine. I just wanted to share the fix if anyone else had issue and also check if the issue was not on my side, I'm a newbie on edk2 and on RISC-V :D

> 
> 
> Thanks
> Abner

[-- Attachment #2: Type: text/html, Size: 1814 bytes --]