From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [edk2-devel] [PATCH] RISC-V/PlatformPkg: Fix compilation breakage in OpenSBI To: Abner Chang ,devel@edk2.groups.io From: "Loic Devulder" X-Originating-Location: Rouen, Normandy, FR (176.129.16.149) X-Originating-Platform: Linux Chrome 88 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Thu, 25 Mar 2021 03:01:23 -0700 References: In-Reply-To: Message-ID: <4418.1616666483143981258@groups.io> Content-Type: multipart/alternative; boundary="mdZMVR0tHqZV91GbseKi" --mdZMVR0tHqZV91GbseKi Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 25, 2021 at 01:46 AM, Abner Chang wrote: >=20 > Hi Loic, > The current edk2 RISC-V is incorporated with opensbi v0.8, please check > below link > https://github.com/riscv/riscv-uefi-edk2-docs Yes, I think this is the version I used. In fact I followed https://github= .com/tianocore/edk2-platforms#submodules to add the needed submodule. >=20 > We have to update below library with the latest opensbi with your change= s, >=20 > https://github.com/tianocore/edk2-platforms/tree/master/Silicon/RISC-V/P= rocessorPkg/Library/RiscVOpensbiLib >=20 >=20 > I believe your changes don't impact the build and the functionalities > because we don't use those parameters in edk2. Sounds like yes. I tested in qemu without any issue, but that was not a fu= ll regression test ;-) >=20 > However, this change should be adopted with Edk2OpenSbiLib upgrade. > Daniel is currently working on edk2 RISC-V OVMF and also updated opensbi > to the latest version. However there is a compatible issue when switchin= g > mode and we are fixing it now. > We can share more information with you if you would like to know. So if this fix will be included in Daniel's changes that fine. I just want= ed to share the fix if anyone else had issue and also check if the issue wa= s not on my side, I'm a newbie on edk2 and on RISC-V :D >=20 >=20 > Thanks > Abner --mdZMVR0tHqZV91GbseKi Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 25, 2021 at 01:46 AM, Abner Chang wrote:
Hi Loic,
The current edk2 RISC-V is incorporated with ope= nsbi v0.8, please check below link
https://github.co= m/riscv/riscv-uefi-edk2-docs
Yes, I think this is the version I used. In fact I followed https://github.com/tianocore/edk2-platforms#submodules=  to add the needed submodule.

We have to update below library with the latest opensbi with y= our changes,
https://github.com/tianocore/edk2-platforms/tree/mas= ter/Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib

I b= elieve your changes don't impact the build and the functionalities because = we don't use those parameters in edk2.
Sounds like yes. I tested in qemu without any issue, but that was not a fu= ll regression test ;-)

However, this change should be adopted with Edk2OpenSbiLib upg= rade.
Daniel is currently working on edk2 RISC-V OVMF and also updated= opensbi to the latest version. However there is a compatible issue when sw= itching mode and we are fixing it now.
We can share more information w= ith you if you would like to know.
So if this fix will be included in Daniel's changes that fine. I just want= ed to share the fix if anyone else had issue and also check if the issue wa= s not on my side, I'm a newbie on edk2 and on RISC-V :D


Thanks
Abner
--mdZMVR0tHqZV91GbseKi--