From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5EEBCD80C7F for ; Mon, 1 Apr 2024 22:42:41 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=YxWP7jwN40dFpUzV0If0w0RlwZ3+IWVNG8nwrdzhuFw=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1712011359; v=1; b=zU/Yr0t789tMzeRBje015M8FrLBru51Wy2qgjv/M19c4a+N9H4WC8kxW9yzT7NYOuDuIsnfx xt4k8m1cudd5ovkCrDLTTkfe8lYLr0uKiMqIbdLXgnmdbV/jqr04uzZ+6+fktJ9Bo4Z/MhqnneB xbqMcpjUiQmMm/jfQu0dl14KLS6w+Ozc4v1DuWjP8g+2HLTyZPcUTALDsnLlozSpAMUr0ES1IZE fHoG2m+JJzFpO6DoAqlswrGuYa/rwuBiQsTjXWbi/KO76KiXEEaH6vxGe6X0PW8W7lTxjBY8Z5x XnQJcs2y7CDcLmRx1wQJJctH4/scxCCO7Ik+W2XbMjm+w== X-Received: by 127.0.0.2 with SMTP id xzEMYY7687511x0oOGrq0iXR; Mon, 01 Apr 2024 15:42:39 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.51702.1712011359105031093 for ; Mon, 01 Apr 2024 15:42:39 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A819F12FC; Mon, 1 Apr 2024 15:43:10 -0700 (PDT) X-Received: from [10.119.37.1] (unknown [10.119.37.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 599133F7B4; Mon, 1 Apr 2024 15:42:38 -0700 (PDT) Message-ID: <443e44f9-2fb3-415a-9315-9eda8a304cc5@arm.com> Date: Mon, 1 Apr 2024 17:42:37 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v3 1/3] ShellPkg: UefiShellDebug1CommandsLib: Dumping RT Properties in Dmem.c To: devel@edk2.groups.io, sam.kaynor@arm.com Cc: Ray Ni , Zhichao Gao References: <20240401134518.743481-1-Sam.Kaynor@arm.com> <20240401134518.743481-2-Sam.Kaynor@arm.com> From: "Stuart Yoder" In-Reply-To: <20240401134518.743481-2-Sam.Kaynor@arm.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 01 Apr 2024 15:42:39 -0700 Reply-To: devel@edk2.groups.io,stuart.yoder@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ls0QadiraovbWlAGVdxqeMNcx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="zU/Yr0t7"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none) Hi Sam, See comments below... > +SHELL_STATUS > +DisplayRtProperties ( > + IN UINT64 Address > + ) > +{ > + EFI_RT_PROPERTIES_TABLE *RtPropertiesTable; > + UINT32 RtServices; > + SHELL_STATUS ShellStatus; > + EFI_STATUS Status; > + > + ShellStatus =3D SHELL_SUCCESS; > + > + RtPropertiesTable =3D (EFI_RT_PROPERTIES_TABLE *)Address; > + > + RtServices =3D (UINT32)RtPropertiesTable->RuntimeServicesSupported; You are using the Address variable here without checking if it is NULL or not. Add a check like the other verbose functions in the patch series. > diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1C= ommandsLib.uni b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug= 1CommandsLib.uni > index 4041f0cd483e..299b0ba44f31 100644 > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Commands= Lib.uni > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Commands= Lib.uni One things I see missing is that you don't have the help message for the Dmem command updated to include the new -verbose option. Update the help message in UefiShellDebug1CommandsLib.uni in patch 1 of the series. Thanks, Stuart -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117298): https://edk2.groups.io/g/devel/message/117298 Mute This Topic: https://groups.io/mt/105264289/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-