Re: [PATCH 0/4] OvmfPkg: simply use the Bochs interface for vmsvga

[yuchenlin <yuchenlin@synology.com>]

On 2018-11-02 03:02, Philippe Mathieu-Daudé wrote:
> Hi Yu-chen Lin,
> 
> On 24/10/18 8:40, yuchenlin@synology.com wrote:
>> From: yuchenlin <yuchenlin@synology.com>
>> 
>> In this series, replace the original vmsvga driver to Bochs
>> interface.
> 
> This is the 'v2' of your previous patch 'OvmfPkg: initialize bochs
> when initializing vmsvga':
> https://lists.01.org/pipermail/edk2-devel/2018-October/031235.html
> 
> Keeping different versions and referencing previous series helps when 
> reviewing.
> 

Sorry for that.
I will add v2 (or v3?) next time.

Thanks,
yuchenlin

>> 
>> Simply revert vmsvga driver implementation. After it, use Bochs
>> interface for initializing vmsvga.
>> 
>> Because of the PCI BARs difference between std vga and vmsvga.
>> We can not simply recognize the "QEMU VMWare SVGA" as the
>> QEMU_VIDEO_BOCHS_MMIO variant.
>> 
>> BAR  |    std vga     |  vmsvga
>> ---------------------------------
>> 0    |   Framebuffer  | I/O space
>> 1    |   Reserved     | Framebuffer
>> 2    |   MMIO         | FIFO
>> 
>> To overcome this problem, we remain variant QEMU_VIDEO_VMWARE_SVGA,
>> and use it for:
>> 
>> (1) Get framebuffer from correct PCI BAR
>> (2) Prevent using BAR2 for MMIO
>> 
>> We have tested on qemu before and after commit 104bd1dc70 and all 
>> worked.
> 
> Did you also test against QEMU v2.9.1?
> 

No, but I tested it in QEMU v2.9.0.

Thanks,
yuchenlin

>> 
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: yuchenlin <yuchenlin@synology.com>
>> 
>> yuchenlin (4):
>>    Revert "OvmfPkg/QemuVideoDxe: VMWare SVGA device support"
>>    Revert "OvmfPkg/QemuVideoDxe: Helper functions for unaligned port
>>      I/O."
>>    Revert "OvmfPkg/QemuVideoDxe: list "UnalignedIoInternal.h" in the 
>> INF
>>      file"
>>    OvmfPkg: simply use the Bochs interface for vmsvga
>> 
>>   OvmfPkg/QemuVideoDxe/Driver.c                 | 137 ++-------------
>>   OvmfPkg/QemuVideoDxe/Gop.c                    |  68 +-------
>>   OvmfPkg/QemuVideoDxe/Initialize.c             | 157 
>> ------------------
>>   OvmfPkg/QemuVideoDxe/Qemu.h                   |  27 ---
>>   OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf         |   7 -
>>   OvmfPkg/QemuVideoDxe/UnalignedIoGcc.c         |  70 --------
>>   OvmfPkg/QemuVideoDxe/UnalignedIoIcc.c         |  80 ---------
>>   OvmfPkg/QemuVideoDxe/UnalignedIoInternal.h    |  59 -------
>>   OvmfPkg/QemuVideoDxe/UnalignedIoMsc.c         |  78 ---------
>>   OvmfPkg/QemuVideoDxe/UnalignedIoUnsupported.c |  66 --------
>>   10 files changed, 17 insertions(+), 732 deletions(-)
>>   delete mode 100644 OvmfPkg/QemuVideoDxe/UnalignedIoGcc.c
>>   delete mode 100644 OvmfPkg/QemuVideoDxe/UnalignedIoIcc.c
>>   delete mode 100644 OvmfPkg/QemuVideoDxe/UnalignedIoInternal.h
>>   delete mode 100644 OvmfPkg/QemuVideoDxe/UnalignedIoMsc.c
>>   delete mode 100644 OvmfPkg/QemuVideoDxe/UnalignedIoUnsupported.c
>>