From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=59.124.61.242; helo=synology.com; envelope-from=yuchenlin@synology.com; receiver=edk2-devel@lists.01.org Received: from synology.com (synology.com [59.124.61.242]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 817D521188C2C for ; Thu, 1 Nov 2018 19:12:59 -0700 (PDT) Received: from _ (localhost [127.0.0.1]) by synology.com (Postfix) with ESMTPA id 5EA5824645E8; Fri, 2 Nov 2018 10:12:57 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synology.com; s=123; t=1541124777; bh=Vn6CE2qP3KRWy56oFAbA6kS5W9//IOpgPIDNH9onDwU=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=EOvJADparMcE7iArL/yIN2BxjQxqIhNAEQ2y79OCF1V0PZzesYrbMBj/Ygdk9FO3T aMyIFjpU/wFptYkIzfNInze/mXo6xUwu3Z3H9wRLyfcflHNVtSlicqSKNNZeJmlc3f 3Lttm3mErYkiSxo9Eu7a/5R/khkD1OpznC8NaW2w= MIME-Version: 1.0 Date: Fri, 02 Nov 2018 10:12:57 +0800 From: yuchenlin To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= Cc: edk2-devel@lists.01.org, phil@philjordan.eu, jordan.l.justen@intel.com, anthony.perard@citrix.com, lersek@redhat.com In-Reply-To: References: <20181024064008.26535-1-yuchenlin@synology.com> Message-ID: <4442dbe4144402f98e619c2f9931987e@synology.com> X-Sender: yuchenlin@synology.com User-Agent: Roundcube Webmail/1.1.2 X-Synology-MCP-Status: no X-Synology-Spam-Flag: no X-Synology-Spam-Status: score=0, required 6, WHITELIST_FROM_ADDRESS 0 X-Synology-Virus-Status: no Subject: Re: [PATCH 0/4] OvmfPkg: simply use the Bochs interface for vmsvga X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Nov 2018 02:13:00 -0000 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2018-11-02 03:02, Philippe Mathieu-Daudé wrote: > Hi Yu-chen Lin, > > On 24/10/18 8:40, yuchenlin@synology.com wrote: >> From: yuchenlin >> >> In this series, replace the original vmsvga driver to Bochs >> interface. > > This is the 'v2' of your previous patch 'OvmfPkg: initialize bochs > when initializing vmsvga': > https://lists.01.org/pipermail/edk2-devel/2018-October/031235.html > > Keeping different versions and referencing previous series helps when > reviewing. > Sorry for that. I will add v2 (or v3?) next time. Thanks, yuchenlin >> >> Simply revert vmsvga driver implementation. After it, use Bochs >> interface for initializing vmsvga. >> >> Because of the PCI BARs difference between std vga and vmsvga. >> We can not simply recognize the "QEMU VMWare SVGA" as the >> QEMU_VIDEO_BOCHS_MMIO variant. >> >> BAR | std vga | vmsvga >> --------------------------------- >> 0 | Framebuffer | I/O space >> 1 | Reserved | Framebuffer >> 2 | MMIO | FIFO >> >> To overcome this problem, we remain variant QEMU_VIDEO_VMWARE_SVGA, >> and use it for: >> >> (1) Get framebuffer from correct PCI BAR >> (2) Prevent using BAR2 for MMIO >> >> We have tested on qemu before and after commit 104bd1dc70 and all >> worked. > > Did you also test against QEMU v2.9.1? > No, but I tested it in QEMU v2.9.0. Thanks, yuchenlin >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: yuchenlin >> >> yuchenlin (4): >> Revert "OvmfPkg/QemuVideoDxe: VMWare SVGA device support" >> Revert "OvmfPkg/QemuVideoDxe: Helper functions for unaligned port >> I/O." >> Revert "OvmfPkg/QemuVideoDxe: list "UnalignedIoInternal.h" in the >> INF >> file" >> OvmfPkg: simply use the Bochs interface for vmsvga >> >> OvmfPkg/QemuVideoDxe/Driver.c | 137 ++------------- >> OvmfPkg/QemuVideoDxe/Gop.c | 68 +------- >> OvmfPkg/QemuVideoDxe/Initialize.c | 157 >> ------------------ >> OvmfPkg/QemuVideoDxe/Qemu.h | 27 --- >> OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf | 7 - >> OvmfPkg/QemuVideoDxe/UnalignedIoGcc.c | 70 -------- >> OvmfPkg/QemuVideoDxe/UnalignedIoIcc.c | 80 --------- >> OvmfPkg/QemuVideoDxe/UnalignedIoInternal.h | 59 ------- >> OvmfPkg/QemuVideoDxe/UnalignedIoMsc.c | 78 --------- >> OvmfPkg/QemuVideoDxe/UnalignedIoUnsupported.c | 66 -------- >> 10 files changed, 17 insertions(+), 732 deletions(-) >> delete mode 100644 OvmfPkg/QemuVideoDxe/UnalignedIoGcc.c >> delete mode 100644 OvmfPkg/QemuVideoDxe/UnalignedIoIcc.c >> delete mode 100644 OvmfPkg/QemuVideoDxe/UnalignedIoInternal.h >> delete mode 100644 OvmfPkg/QemuVideoDxe/UnalignedIoMsc.c >> delete mode 100644 OvmfPkg/QemuVideoDxe/UnalignedIoUnsupported.c >>