From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81])
 by mx.groups.io with SMTP id smtpd.web09.10717.1582734052233349690
 for <devel@edk2.groups.io>;
 Wed, 26 Feb 2020 08:20:52 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aeHNXlNQ;
 spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1582734051;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=szekzFoFXMoBInGKbeI1kyN6WcWnFR4MyZOV7OtX+AY=;
	b=aeHNXlNQ2ab9lOY07yE404OMnd37HMQ1S+/P9JtggScBpt8DHelAAeuKMgFSRJBUvIg0EV
	Lc36bY4DjTR21VrgIMcxuiefrBiJrPtAIY69kzSt4J/fnjE50sxPrBeIRXbPRSx/N6kUHd
	ARMRkmYxPHi74Z7hzhtlZn/DoymDQkU=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-15-qeUWVwy7O9mH1VZbCQ1dww-1; Wed, 26 Feb 2020 11:20:47 -0500
X-MC-Unique: qeUWVwy7O9mH1VZbCQ1dww-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 38869107B76D;
	Wed, 26 Feb 2020 16:20:46 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-185.ams2.redhat.com [10.36.116.185])
	by smtp.corp.redhat.com (Postfix) with ESMTP id C7F335DA2C;
	Wed, 26 Feb 2020 16:20:44 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib
To: "Duran, Leo" <leo.duran@amd.com>, "Ni, Ray" <ray.ni@intel.com>,
 "devel@edk2.groups.io" <devel@edk2.groups.io>, "Wu, Hao A"
 <hao.a.wu@intel.com>, "Fu, Siyuan" <siyuan.fu@intel.com>
Cc: "Dong, Eric" <eric.dong@intel.com>
References: <1582659566-9893-1-git-send-email-leo.duran@amd.com>
 <aad8a707-98e2-58e7-6b8b-01e2346964a5@redhat.com>
 <734D49CCEBEEF84792F5B80ED585239D5C4542DA@SHSMSX104.ccr.corp.intel.com>
 <BN6PR12MB1922399E3AD30CDE5AE36A80F9EA0@BN6PR12MB1922.namprd12.prod.outlook.com>
 <BN6PR12MB19227C6161676E3D74706610F9EA0@BN6PR12MB1922.namprd12.prod.outlook.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <444c59ea-70dc-0edd-d680-add054dad2c5@redhat.com>
Date: Wed, 26 Feb 2020 17:20:43 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <BN6PR12MB19227C6161676E3D74706610F9EA0@BN6PR12MB1922.namprd12.prod.outlook.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

On 02/26/20 16:46, Duran, Leo wrote:
> BTW,
> 
> I also considered adding a flag to CPU_MP_DATA to make the usage of PlatformId a bit more explicit.
> E.g., something like CpuMpData->CpuData[ProcessorNumber].IsValidPlatformId... So the init code would look like this:
> 
>   //
>   // NOTE: PlatformId is not relevant on AMD platforms.
>   //
>   if (StandardSignatureIsAuthenticAMD ()) {
>     CpuMpData->CpuData[ProcessorNumber].IsValidPlatformId = FALSE;
>   else {
>     PlatformIdMsr.Uint64 = AsmReadMsr64 (MSR_IA32_PLATFORM_ID);
>     CpuMpData->CpuData[ProcessorNumber].PlatformId = (UINT8)PlatformIdMsr.Bits.PlatformId;
>     CpuMpData->CpuData[ProcessorNumber].IsValidPlatformId = TRUE;
>   }
> 
> This way "IsValidPlatformId" could be checked prior to using "PlatformId".
> Anyway, that seemed a bit overkill, so I opted against it... thoughts?

I think a global flag is justified; in the above approach,
"IsValidPlatformId" would not vary across "ProcessorNumber", so it does
look like useless generality.

Thanks
Laszlo