From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 162A221CF3B7E for ; Mon, 3 Jul 2017 10:28:38 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ADBD378EA1; Mon, 3 Jul 2017 17:30:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com ADBD378EA1 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=lersek@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com ADBD378EA1 Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-25.phx2.redhat.com [10.3.116.25]) by smtp.corp.redhat.com (Postfix) with ESMTP id 13BA06F99D; Mon, 3 Jul 2017 17:30:12 +0000 (UTC) To: Leif Lindholm Cc: Ard Biesheuvel , Ruiyu Ni , edk2-devel@lists.01.org, Hao Wu , "Jordan Justen (Intel address)" , Andrew Fish References: <20170629083221.485184-1-ruiyu.ni@intel.com> <60ac3e5e-12b6-4bd5-6f7f-a7101b7c7edb@redhat.com> <20170703120943.GD26676@bivouac.eciton.net> From: Laszlo Ersek Message-ID: <446b5575-b2f8-52d0-a372-2b2c8990dc8b@redhat.com> Date: Mon, 3 Jul 2017 19:30:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170703120943.GD26676@bivouac.eciton.net> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 03 Jul 2017 17:30:14 +0000 (UTC) Subject: Re: [PATCH 0/3] MdeModulePkg/ResetSystem: Implement ResetNotification protocol X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jul 2017 17:28:38 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/03/17 14:09, Leif Lindholm wrote: > On Sat, Jul 01, 2017 at 11:04:08PM +0200, Laszlo Ersek wrote: >> Ard, Leif, >> >> On 06/29/17 10:32, Ruiyu Ni wrote: >>> Ruiyu Ni (3): >>> MdePkg: Add ResetNotification protocol definition >>> MdeModulePkg/ResetSystem: Remove unnecessary global variable >>> MdeModulePkg/ResetSystem: Implement ResetNotification protocol >>> >>> .../Universal/ResetSystemRuntimeDxe/ResetSystem.c | 146 +++++++++++++++++++-- >>> .../Universal/ResetSystemRuntimeDxe/ResetSystem.h | 21 ++- >>> .../ResetSystemRuntimeDxe.inf | 5 +- >>> MdePkg/Include/Protocol/ResetNotification.h | 86 ++++++++++++ >>> MdePkg/MdePkg.dec | 3 + >>> 5 files changed, 247 insertions(+), 14 deletions(-) >>> create mode 100644 MdePkg/Include/Protocol/ResetNotification.h >>> >> >> I think we should >> - either port this feature (patch 3/3) to EmbeddedPkg/ResetRuntimeDxe, >> - or else rebase all platforms that consume EmbeddedPkg/ResetRuntimeDxe >> to MdeModulePkg/Universal/ResetSystemRuntimeDxe, and delete >> EmbeddedPkg/ResetRuntimeDxe from the tree. >> >> What do you guys think? > > I think deleting the EmbeddedPkg one, and making the current consumers > implement ResetSystemLib instead of EfiResetSystemLib would be an > improvement. Looks like you and Ard agree this is the best way forward. (I also agree, I just wasn't sure if it would be your shared preference, due to the conversion of dependent platforms possibly needing a lot of work.) Ard, do you want me to file a BZ for the ArmVirtPkg conversion? (I can't volunteer to actually do the conversion right now; my plate is full.) Thanks, Laszlo