From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5357BD8102D for ; Fri, 29 Sep 2023 16:00:56 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=+5DI5Egd3xshG3f8ySJWZd1m2QX0g3yTXSGz4jD4n5Q=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1696003255; v=1; b=CuYkLndn7oy/+MHC/4nDhHCyYFsvVcBG8lw9qqR2frMFj2FGADXsOfa26povMqIs0oiOB57n a//a/fDRY0sHZEqQPyAoDv7mHLw8ml7JCmgUI0NgOu/Whk30UxL07qO6S1FSbGGRNnbElNJETXg ajkt+7H1HxXSutmwURBYa61A= X-Received: by 127.0.0.2 with SMTP id oZ7MYY7687511xxxzsJCHppB; Fri, 29 Sep 2023 09:00:55 -0700 X-Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mx.groups.io with SMTP id smtpd.web10.13233.1695977682440456361 for ; Fri, 29 Sep 2023 01:54:42 -0700 X-Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 4DD383F4E0 for ; Fri, 29 Sep 2023 08:54:40 +0000 (UTC) X-Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-323334992fbso5583786f8f.1 for ; Fri, 29 Sep 2023 01:54:40 -0700 (PDT) X-Gm-Message-State: w9dTks9357OFWjIJXwV6JkdCx7686176AA= X-Received: by 2002:a5d:568e:0:b0:31f:e5cf:6724 with SMTP id f14-20020a5d568e000000b0031fe5cf6724mr3002078wrv.46.1695977679576; Fri, 29 Sep 2023 01:54:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEN7hQzhm8xuDuGFx/+s7Ga1anBLLjrCeEi1REAfTelWTb70JMakWReXel14MX4EpN65GM+0w== X-Received: by 2002:a5d:568e:0:b0:31f:e5cf:6724 with SMTP id f14-20020a5d568e000000b0031fe5cf6724mr3002061wrv.46.1695977679218; Fri, 29 Sep 2023 01:54:39 -0700 (PDT) X-Received: from [192.168.123.94] (ip-178-202-040-247.um47.pools.vodafone-ip.de. [178.202.40.247]) by smtp.gmail.com with ESMTPSA id o13-20020adfeacd000000b00317f3fd21b7sm21327218wrn.80.2023.09.29.01.54.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Sep 2023 01:54:38 -0700 (PDT) Message-ID: <4487065a-ac8f-4a73-a3e5-b7069df9e7d3@canonical.com> Date: Fri, 29 Sep 2023 10:54:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list To: John Chew Cc: Sunil V L , Li Yong , Leif Lindholm , Ard Biesheuvel , Abner Chang , Daniel Schaefer , devel@edk2.groups.io References: <20230929020222.2010-1-yuinyee.chew@starfivetech.com> From: Heinrich Schuchardt In-Reply-To: <20230929020222.2010-1-yuinyee.chew@starfivetech.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,heinrich.schuchardt@canonical.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=CuYkLndn; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=canonical.com (policy=none) On 9/29/23 04:02, John Chew wrote: > Update Gigadevice norflash list: > gd25q16, gd25q32, gd25q64, gd25lq64c, gd25q128, gd25lq128, gd25q256 >=20 > Add Silicon Kaiser norflash list: > sk25lp128 >=20 > Cc: Sunil V L > Cc: Li Yong > Cc: Heinrich Schuchardt > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Abner Chang > Cc: Daniel Schaefer > Signed-off-by: John Chew > --- > EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) >=20 > diff --git a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c b/Embe= ddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c > index e16c1c6a14..422fdac851 100644 > --- a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c > +++ b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c > @@ -1,6 +1,7 @@ > /** @file > * > * Copyright (c) 2017 Marvell International Ltd. > +* Copyright (c) 2023 StarFive, Technology Co., Ltd. All rights reserved= .
> * > * SPDX-License-Identifier: BSD-2-Clause-Patent > * > @@ -33,12 +34,20 @@ STATIC CONST NOR_FLASH_INFO NorFlashIds[] =3D { > { L"en25q128b", { 0x1c, 0x30, 0x18 }, 3, 256, 64 * 1024, 256, = 0 }, > { L"en25s64", { 0x1c, 0x38, 0x17 }, 3, 256, 64 * 1024, 128, = 0 }, > /* GIGADEVICE */ > - { L"gd25q64b", { 0xc8, 0x40, 0x17 }, 3, 256, 64 * 1024, 128, N= OR_FLASH_ERASE_4K }, > + { L"gd25q16", { 0xc8, 0x40, 0x15 }, 3, 256, 64 * 1024, 32, N= OR_FLASH_ERASE_4K }, > + { L"gd25q32", { 0xc8, 0x40, 0x16 }, 3, 256, 64 * 1024, 64, N= OR_FLASH_ERASE_4K }, > { L"gd25lq32", { 0xc8, 0x60, 0x16 }, 3, 256, 64 * 1024, 64, = NOR_FLASH_ERASE_4K }, > + { L"gd25q64b", { 0xc8, 0x40, 0x17 }, 3, 256, 64 * 1024, 128, N= OR_FLASH_ERASE_4K }, Linux calls this gd25q64 but probably we don't want to change the=20 displayed name. > + { L"gd25lq64c", { 0xc8, 0x60, 0x17 }, 3, 256, 64 * 1024, 128, N= OR_FLASH_ERASE_4K }, > + { L"gd25q128", { 0xc8, 0x40, 0x18 }, 3, 256, 64 * 1024, 256, N= OR_FLASH_ERASE_4K }, > + { L"gd25lq128", { 0xc8, 0x60, 0x18 }, 3, 256, 64 * 1024, 256, N= OR_FLASH_ERASE_4K }, Linux calls this gd25lq128d. > + { L"gd25q256", { 0xc8, 0x40, 0x19 }, 3, 256, 64 * 1024, 512, N= OR_FLASH_ERASE_4K }, Except for the two labels the changes match=20 drivers/mtd/spi-nor/gigadevice.c in Linux. > /* ISSI */ > { L"is25lp032", { 0x9d, 0x60, 0x16 }, 3, 256, 64 * 1024, 64, = 0 }, > { L"is25lp064", { 0x9d, 0x60, 0x17 }, 3, 256, 64 * 1024, 128, = 0 }, > { L"is25lp128", { 0x9d, 0x60, 0x18 }, 3, 256, 64 * 1024, 256, = 0 }, > + /* XINKAI / SILICON KAISER */ > + { L"sk25lp128", { 0x27, 0x70, 0x18 }, 3, 256, 64 * 1024, 256, N= OR_FLASH_ERASE_4K }, This matches https://lore.kernel.org/all/20230726214401.929533-1-jonas@kwiboo.se/ Acked-by: Heinrich Schuchardt > /* MACRONIX */ > { L"mx25l2006e", { 0xc2, 0x20, 0x12 }, 3, 256, 64 * 1024, 4, = 0 }, > { L"mx25l4005", { 0xc2, 0x20, 0x13 }, 3, 256, 64 * 1024, 8, = 0 }, -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109210): https://edk2.groups.io/g/devel/message/109210 Mute This Topic: https://groups.io/mt/101660590/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-