From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9A05521E87974 for ; Thu, 14 Sep 2017 12:01:05 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 66B358B134; Thu, 14 Sep 2017 19:04:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 66B358B134 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-80.rdu2.redhat.com [10.10.121.80]) by smtp.corp.redhat.com (Postfix) with ESMTP id E7D2517A8A; Thu, 14 Sep 2017 19:04:02 +0000 (UTC) To: Brijesh Singh , edk2-devel@lists.01.org Cc: Jordan Justen , Tom Lendacky , Ard Biesheuvel References: <20170914110822.112540-1-brijesh.singh@amd.com> <20170914110822.112540-4-brijesh.singh@amd.com> From: Laszlo Ersek Message-ID: <449062af-9006-4ab8-6de0-ce58f4157214@redhat.com> Date: Thu, 14 Sep 2017 21:04:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170914110822.112540-4-brijesh.singh@amd.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Thu, 14 Sep 2017 19:04:04 +0000 (UTC) Subject: Re: [PATCH v3 3/8] OvmfPkg/VirtioNetDxe: alloc RxBuf using AllocateSharedPages() X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Sep 2017 19:01:05 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/14/17 13:08, Brijesh Singh wrote: > When device is behind the IOMMU, VirtioNetDxe is required to use the > device address in bus master operations. RxBuf is allocated using > AllocatePool() which returns the system physical address. > > The patch uses VIRTIO_DEVICE_PROTOCOL.AllocateSharedPages() to allocate > the RxBuf and map with VirtioMapAllBytesInSharedBuffer() so that we can > obtain the device address for RxBuf. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Tom Lendacky > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Brijesh Singh > --- > OvmfPkg/VirtioNetDxe/VirtioNet.h | 4 + > OvmfPkg/VirtioNetDxe/SnpInitialize.c | 78 +++++++++++++++----- > OvmfPkg/VirtioNetDxe/SnpReceive.c | 5 +- > OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c | 7 +- > OvmfPkg/VirtioNetDxe/TechNotes.txt | 2 +- > 5 files changed, 75 insertions(+), 21 deletions(-) Reviewed-by: Laszlo Ersek