public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	"Yao, Jiewen" <jiewen.yao@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@ml01.01.org>,
	"Gao, Liming" <liming.gao@intel.com>,
	"Zeng, Star" <star.zeng@intel.com>,
	"Tian, Feng" <feng.tian@intel.com>,
	"Ni, Ruiyu" <ruiyu.ni@intel.com>,
	"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>
Subject: Re: [PATCH] MdeModulePkg/PciBusDxe: make BAR degradation dependent on OPROM presence
Date: Mon, 12 Sep 2016 15:48:51 +0200	[thread overview]
Message-ID: <449c21bc-ddfc-697a-bc25-7daa05485b6c@redhat.com> (raw)
In-Reply-To: <CAKv+Gu_r=68SBKaj6NpHH2zNtm=MXJ6ibJ_Aypo6nO2Gdasd1g@mail.gmail.com>

On 09/12/16 15:16, Ard Biesheuvel wrote:
> On 12 September 2016 at 14:15, Yao, Jiewen <jiewen.yao@intel.com> wrote:
>> HI Ard
>> We should not let MdeModulePkg depend on IntelFrameworkPkg.
>> You patch violates the dependency rule.
>> I suggest we figure out other solution to resolve the problem.
>>
> 
> Yes, please. And please keep us informed about any solutions you come up with.

* One idea is to parse the PCI expansion ROM in order to see what image
types are contained within. If there is no (Code type == 0x00) image in
the oprom, then the oprom is useless for legacy boot anyway, so it
shouldn't trigger degradation.

Unfortunately, this wouldn't help a lot in practice, since it's surely
going to be years before hw vendors migrate to pure UEFI oproms on their
graphics and network cards. :(

* Another idea is to check a dynamic PCD that the platform can set. New
PCDs are frowned upon in MdeModulePkg however, so I don't expect this to
be a popular fix.

Thanks
Laszlo


  parent reply	other threads:[~2016-09-12 13:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-12 13:06 [PATCH] MdeModulePkg/PciBusDxe: make BAR degradation dependent on OPROM presence Ard Biesheuvel
2016-09-12 13:15 ` Yao, Jiewen
2016-09-12 13:16   ` Ard Biesheuvel
2016-09-12 13:41     ` Ni, Ruiyu
2016-09-12 13:46       ` Ard Biesheuvel
2016-09-12 13:48     ` Laszlo Ersek [this message]
2016-09-13  5:46       ` Ni, Ruiyu
2016-09-13  7:43         ` Ard Biesheuvel
2016-09-13 14:56           ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=449c21bc-ddfc-697a-bc25-7daa05485b6c@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox