Hi Pranav,

This patch looks good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar


On 19/05/2021 09:22 AM, Pranav Madhu wrote:
> Add the RD-N2-Cfg1 platform identification values including the part
> number and configuration number. This information will be used in
> populating the SMBIOS tables.
>
> Signed-off-by: Pranav Madhu <pranav.madhu@arm.com>
> ---
>   Platform/ARM/SgiPkg/Include/SgiPlatform.h             | 7 ++++++-
>   Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c | 8 +++++++-
>   2 files changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/Platform/ARM/SgiPkg/Include/SgiPlatform.h b/Platform/ARM/SgiPkg/Include/SgiPlatform.h
> index 4999c9870b49..dddb58832d73 100644
> --- a/Platform/ARM/SgiPkg/Include/SgiPlatform.h
> +++ b/Platform/ARM/SgiPkg/Include/SgiPlatform.h
> @@ -39,6 +39,10 @@
>   #define RD_V1_CONF_ID                             0x1
>   #define RD_V1_MC_CONF_ID                          0x2
>   
> +// RD-N2-Cfg1 Platform Identification values
> +#define RD_N2_CFG1_PART_NUM                       0x7B6
> +#define RD_N2_CFG1_CONF_ID                        0x1
> +
>   // RD-N2 Platform Identification values
>   #define RD_N2_PART_NUM                            0x7B7
>   #define RD_N2_CONF_ID                             0x1
> @@ -77,7 +81,8 @@ typedef enum {
>     RdE1Edge,
>     RdV1,
>     RdV1Mc,
> -  RdN2
> +  RdN2,
> +  RdN2Cfg1
>   } ARM_RD_PRODUCT_ID;
>   
>   // Arm ProductId look-up table
> diff --git a/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c b/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c
> index f27c949dbc24..a982e3d403fa 100644
> --- a/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c
> +++ b/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c
> @@ -66,7 +66,13 @@ STATIC CONST SGI_PRODUCT_ID_LOOKUP SgiProductIdLookup[] = {
>       RD_N2_PART_NUM,
>       RD_N2_CONF_ID,
>       0
> -  }
> +  },
> +  {
> +    RdN2Cfg1,
> +    RD_N2_CFG1_PART_NUM,
> +    RD_N2_CFG1_CONF_ID,
> +    0
> +  },
>   };
>   
>   EFI_BOOT_MODE