From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.59]) by mx.groups.io with SMTP id smtpd.web12.23665.1621865685044815512 for ; Mon, 24 May 2021 07:14:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=D/MmP+Nl; spf=pass (domain: arm.com, ip: 40.107.21.59, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jx9relI1H43L/MwTni94LOLOI2IWt2fTnBcEcMWq59U=; b=D/MmP+NlaiL97rQeLxwywOUdbb5vYQldBAPFgeQ7pndc+H7YppGiHPfUwdKcuJgQWu/cosLVsgYYYZEsYjFo8m+Gk8W1/IfqYiepbVshdrS0fs87vFbhJfH2/xXW6a2VYzU+Ujl++iOubwNwusvOZaKN9evKBAG1ZIZfCJMj0Ak= Received: from AM5PR1001CA0005.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:2::18) by AS8PR08MB6485.eurprd08.prod.outlook.com (2603:10a6:20b:318::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.23; Mon, 24 May 2021 14:14:42 +0000 Received: from VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:2:cafe::7f) by AM5PR1001CA0005.outlook.office365.com (2603:10a6:206:2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.23 via Frontend Transport; Mon, 24 May 2021 14:14:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT055.mail.protection.outlook.com (10.152.19.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Mon, 24 May 2021 14:14:41 +0000 Received: ("Tessian outbound 6c8a2be3c2e7:v92"); Mon, 24 May 2021 14:14:41 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: bf967fa28ea80bc3 X-CR-MTA-TID: 64aa7808 Received: from 0824ec5b9463.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5BEDF8C6-5EF7-4622-BDC3-3B5D980A35ED.1; Mon, 24 May 2021 14:14:35 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0824ec5b9463.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 24 May 2021 14:14:35 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ch3XC9nYn0oMiCvAnEj2RLzYOibeL6u82BdMTji5y4FL8lBfk43ZIVXaibRfMsnz21gkDjqHjHliV7y1FVgLk2XTzP7jm3oOsN+UkOlfosGOstkFEPHmHQ4peBCNahsjBTe2y+H0ofOd/IXWTtziehzqhlBp9gY0/SyDWYM06GdzdmR5tlH15Bmdj0+uxjbtjYHUYoMyp0ejfybHet2WykRuFiKgqA1x5gKzW4mNq3anSYq9m7CzCX6GCdRq9ltv09iJkULI3z3EoBywy5GkLjAjknHFZvyc7FWlXjmgDKHTXnKYplVfnz7F2EReD68zKtO9zxENPffJAfRH3rq3SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jx9relI1H43L/MwTni94LOLOI2IWt2fTnBcEcMWq59U=; b=QJpRUZMiD4jWPffQjssHXyuthxtgfUJOesZAwIiPmgSulbz+iFJ9jZXdPUt7/p7kjfwsqkOTnepTxJBBIG0gKvkTKyd1BJ1EqnXg63MQYXbBsSMtYRMsVPS6QJWLZoBi9XsLWtBiMv6XHtevx81VXkhodWNgxEBeNsQzqwuP9EccIVwsGJ40+sIcbgTxk0enTQ815ItoTLmrPL4ygJOYRA2IjtCTBRhKu82TbNtDpr/gaVifZ7aws+rjh1HlRKxmVjNrfhFzyoHcNRjbfnId2mBBH+wj80zCanMFgfhUKOZqme2oBe0L3sx3RTLYCmwOmRUJZRFnivsdKdnvG+rOWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jx9relI1H43L/MwTni94LOLOI2IWt2fTnBcEcMWq59U=; b=D/MmP+NlaiL97rQeLxwywOUdbb5vYQldBAPFgeQ7pndc+H7YppGiHPfUwdKcuJgQWu/cosLVsgYYYZEsYjFo8m+Gk8W1/IfqYiepbVshdrS0fs87vFbhJfH2/xXW6a2VYzU+Ujl++iOubwNwusvOZaKN9evKBAG1ZIZfCJMj0Ak= Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AS8PR08MB6437.eurprd08.prod.outlook.com (2603:10a6:20b:33b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.23; Mon, 24 May 2021 14:14:34 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::80cb:878d:c8f1:2688]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::80cb:878d:c8f1:2688%7]) with mapi id 15.20.4150.027; Mon, 24 May 2021 14:14:34 +0000 Subject: Re: [edk2-platforms][PATCH V1 5/6] Platform/Sgi: Define RD-N2-Cfg1 platform id values To: Pranav Madhu , devel@edk2.groups.io Cc: Ard Biesheuvel , nd@arm.com References: <20210519082247.3003-1-pranav.madhu@arm.com> <20210519082247.3003-6-pranav.madhu@arm.com> From: "Sami Mujawar" Message-ID: <44d37558-ec62-4bf7-e22b-5634010bd43f@arm.com> Date: Mon, 24 May 2021 15:14:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20210519082247.3003-6-pranav.madhu@arm.com> X-Originating-IP: [217.140.106.52] X-ClientProxiedBy: LO3P265CA0017.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:bb::22) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.1.196.43] (217.140.106.52) by LO3P265CA0017.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:bb::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.23 via Frontend Transport; Mon, 24 May 2021 14:14:33 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e24f4e87-ce0a-4bc4-2810-08d91ebe4641 X-MS-TrafficTypeDiagnostic: AS8PR08MB6437:|AS8PR08MB6485: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:1227;OLM:1227; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: nV0njvssrCunhjYbujek2PWP5DfSrRbFRwhnfn/XDiJMJajEH9OgjsZofHBbLFkcudYcxwQpPBLr2Nx/zFxcf5geUOPtogQ57sl5VxFdb17OjzINGqust3FGjwvCjddxgFdIBQtJ9HQ5jXqDCOYu5JrOA7wo3llpUdEsJ84VdwL9Rn9NviyIZOMoX53/1HqwvYXIua0KJ9uIZWx8zByWEtE1uUjcFzlj6yBV+vJ6O28pNZLig8oHPxu5kKDKXSFR3iHg+J6Q3VRHfX7G5U7qfa+iqstj7h9VWCDcAs3pR0+ThaotJeRRmE67fxnMj8CKZ4/sdKUqF9M/SIcjoIOwHRVJAThC0YSngKX7T4ou8GPge1ogbLn3QjAYCfybSmgxSK8eRyp7MwpmvaHRz9vQW0xGuz8PyxPaZZL5tSCoUC/NyRRKQGKmr88kdaYqpkdDIaqkZUEsPqg0CjDhWJi0d75D9WjU4hlyF46cT0+0rVOUWuo58z2C8twuI+s3O1jDB1Qu5spxg362C86m8RPcIrtpjNrdkr6LmMfpFwLKHMZVXpTrgDKw9XbsyUaOYfTsvCbksAG/DtS3q9syQOC/zU/Id6Lbza5P3OFOIQVBDgAVegF5GpJKXfL9Pez+UuKF5kCDyqnPRy6GvGNtV48/elRmkZrhCY+zUPr7kL1/IyQMbPWlzHZOwkswgMcA0e8bWycUMRLDFWPBF7Jb1AL/mSgsra2p/0FbQ17ewnQHzqE= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(39860400002)(366004)(136003)(376002)(396003)(8676002)(2616005)(52116002)(956004)(31696002)(53546011)(44832011)(83380400001)(33964004)(8936002)(26005)(86362001)(38100700002)(38350700002)(478600001)(2906002)(6486002)(5660300002)(66946007)(36756003)(66556008)(316002)(31686004)(186003)(16576012)(66476007)(16526019)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?cXBSQWhwSVBXRERvYThwWnlkazJySnZsYU9idmlWZWRXcDh3UTk2MWU0UVAw?= =?utf-8?B?UVBOU2NCNS90RGZOeU5ZaXdQZTh0VUV6TG9OSm5lQmV1ZmcvTEZwZTBHQ3FJ?= =?utf-8?B?YTlxR29TYkoyQlRjZWhuK2Z0aFhqcy80ZDcwZFUwSjlVYXlQVUFTdFJUaDRp?= =?utf-8?B?Zkx3SUFCT25MSDRJT2RDbmxvK2NVNHVZK0dCREtXVjZvdHhYc1lJWHUzMm8x?= =?utf-8?B?cnBNZWluVWFTWTR4bFZ4a0ZiZUZYTDRaR2hQbHQ4TFVsWGw1WUM2VTV4eDIx?= =?utf-8?B?RGErbmtqcUREQ3owbGNvWVlCcXlyL1J6eUxwWTVHRXdjM2xuRldFSnFZeTBT?= =?utf-8?B?VXAvNk03NTZVQUpvMUVxYWlpM0g3SERTcmRTQjRMU3FTV2xkdi9TTzJCdldt?= =?utf-8?B?T2FMUmxBbnFPQW9sWkVvblNsdXNmb0dyb1VlZmdxMitNYi9NWlc5S2JkaCtV?= =?utf-8?B?RklXVnV1aTc4cVU0cDhCanNqTlhHQmJwOUJnWkw1Sy9ZU3JXanpuMC92UGVP?= =?utf-8?B?alYwc29pUm5JajVmRDZsSE43L3J0TmN0Y0ZKeGE5L0pOSGhaS2VwMW5iWk5z?= =?utf-8?B?b3A4bnNWZy9sYk13L3NOV0JLdU5jejVGRzc1VTQ5Vmc0NVkwaWZ2di9pbnpG?= =?utf-8?B?NkZJUmZ6ODFtV1Y4TjlXWjV0SUlodzd5MEU4MDNidW9wRDlQb2s5ZXZxeDhM?= =?utf-8?B?U2JyMWRSdURnaHRKQkVxVGU0OE9QeEtRRUNxZzJlSGtKc25GaDBUaldGeVZF?= =?utf-8?B?Ykp2TFU1NWl1Z2Z0ZTZNRStwSG13S0hrd3RiU0UxQ1dCYi9pdXl2LzhDUWh4?= =?utf-8?B?ZFBiakIwYWV2VU1ranpDUmcrTm9xdzNyVk0wcFBZZlZSZS9LdmZFdW1xQ3Aw?= =?utf-8?B?TXprOU1pRldUVVZITU03czZ6Z3ZNRytoKzBJRlZyMCtadzgxL2tQbXdNd0xJ?= =?utf-8?B?eHY2S0FrOXdhVm9XK0NuSUFhWk5FYWJtaDRRaVZ1NHl0MCtJSkU3Qkc1UHpT?= =?utf-8?B?QjZINUlOVEwwNFlHbkpUVnlyMlVSZlo5QlVKbzhLK3BWclhwVXlzUFA3c1NP?= =?utf-8?B?bENEZDBWQW5yU0phdWtPRlhkMm1meXRpeGFXQ1BGTWc2QVlpa2JlS0pPRGFU?= =?utf-8?B?MFdRN0Nka2lRai8wcE9BbmQwbE9rcCs3REc5ajE0Y2kwdzVLaGVGYkJycUt1?= =?utf-8?B?bkxGQXJqeWYraExTT1F5Y2JBeHdSR3k0VzZ5RFFEbk02bUVJODhJamJpSmdK?= =?utf-8?B?bXJMZmdpdWZhOVd1dTBtL0ZlNUhUQm9XL1NBcUlmTmQ5MkdmMlFtQWdTV2xW?= =?utf-8?B?aFQvNlBMVENsM0JZV0UyNDg2QVRIRG9aZ0ZzYWtxZEVZdE5RSk1yWGdaekh6?= =?utf-8?B?dGUzWEdYNytKT01qV3pCOS8wWmpjRmxYVHZXSVp0a1FiZEdpd0E5MHlvVWJk?= =?utf-8?B?TXRHK1hCVXVKaW5wMDRiUHM0ZFE1d2w2VnBlK01Na2d5WFd1T2pKV0hCSGNr?= =?utf-8?B?Yi8wNU52bDB3WHMwTy9NS0pIQ2hRblZBQUFLYlBob0k1aHVoRUY5dnM5RHdy?= =?utf-8?B?YURTZFJDQUpWd1krSWE3YWRNSkdkS1hyYTcvV0FnYnJFZng0c2hEY0hMZjZo?= =?utf-8?B?Q2RzamVZQS9iL09JNE5UZ2hDSG94ZW1nRWxhSlBtMm5xZWdkSVdhUi9FelM0?= =?utf-8?B?ZEs4L3lzQjNCU1JhcFRaaGtDeEd6QWFCR0UzQjYrTW9nYmZLeW5BWnBSWXdF?= =?utf-8?Q?ZiS7PjaS4LMQkvlKisE61WyNQr5aUSX0e4JXJbn?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6437 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 694d5514-6a72-4a1a-6438-08d91ebe4168 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q2BzuifLZXBkg/EdgYWlubFyNidYGe7a+VOysmVdEiPob0PPAJIgAH/o94ll9R0nbH5kjTzYepdRHXWA8s15Uqam79Y2uKseRRmx6CvDPsI1D6oRTwk7hg/+zaFmj/SQOZHKXNBOeTPova8xWgHfCVmN6W63E2v+dsdUhpMd7WvdZRs61d6byO7auPSw5QuGeSjnNppVfboslSOEJftK1Kwn8nJtX4Dnxsd5ploE8hrhAXajgHzl/MUegj22V8d7hegAFaqJ+WEl4vg8/dH7WT825AWyrAswnsIcMJGiaUaXalo1BkGjtjX51X/qtxd99jwEYoPFFQuoEGbICcZ4+yGDDR4usLlFERgZ+fRiTGLRIq9CGUOZpjYN77svXMm8LsC7ptndsuIdMJH9SBz590FZMWWdoF844SuROFu1agYEF0GEJyNU+ScGEOTCDR+8Wfa2MXASlQ0/7ufc9GYLMnCJduCTtEECNj/BaPL/RUtFgl5WRNoFK+Yg33nKa5poSDUepodnniIxMXagktWcP7REt88bCZO8gdmWM0GVE0CAEtQ+DN+bs4+OJ2m+hv8OEnLVEZs4uOEgoziNcjqsOfBh/2/YqIn3JWAQ9U+tsNUE1aTwCz3tmZBaoWbzJxe81cHFKyz7AloPZ/hMDRw3rh9ocyVU8xSmow+4AoJ2zR+7lFPyrLXs+x9wVqlQxduL X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(396003)(346002)(376002)(136003)(39860400002)(36840700001)(46966006)(81166007)(53546011)(31696002)(44832011)(16526019)(33964004)(6486002)(186003)(336012)(31686004)(86362001)(82310400003)(82740400003)(356005)(956004)(8676002)(16576012)(2616005)(316002)(8936002)(26005)(2906002)(70206006)(478600001)(36860700001)(70586007)(83380400001)(47076005)(4326008)(36756003)(5660300002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2021 14:14:41.9641 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e24f4e87-ce0a-4bc4-2810-08d91ebe4641 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6485 Content-Type: multipart/alternative; boundary="------------2CC267838C39564DDE07AE3C" Content-Language: en-GB --------------2CC267838C39564DDE07AE3C Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hi Pranav, This patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 19/05/2021 09:22 AM, Pranav Madhu wrote: > Add the RD-N2-Cfg1 platform identification values including the part > number and configuration number. This information will be used in > populating the SMBIOS tables. > > Signed-off-by: Pranav Madhu > --- > Platform/ARM/SgiPkg/Include/SgiPlatform.h | 7 ++++++- > Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c | 8 +++++++- > 2 files changed, 13 insertions(+), 2 deletions(-) > > diff --git a/Platform/ARM/SgiPkg/Include/SgiPlatform.h b/Platform/ARM/SgiPkg/Include/SgiPlatform.h > index 4999c9870b49..dddb58832d73 100644 > --- a/Platform/ARM/SgiPkg/Include/SgiPlatform.h > +++ b/Platform/ARM/SgiPkg/Include/SgiPlatform.h > @@ -39,6 +39,10 @@ > #define RD_V1_CONF_ID 0x1 > #define RD_V1_MC_CONF_ID 0x2 > > +// RD-N2-Cfg1 Platform Identification values > +#define RD_N2_CFG1_PART_NUM 0x7B6 > +#define RD_N2_CFG1_CONF_ID 0x1 > + > // RD-N2 Platform Identification values > #define RD_N2_PART_NUM 0x7B7 > #define RD_N2_CONF_ID 0x1 > @@ -77,7 +81,8 @@ typedef enum { > RdE1Edge, > RdV1, > RdV1Mc, > - RdN2 > + RdN2, > + RdN2Cfg1 > } ARM_RD_PRODUCT_ID; > > // Arm ProductId look-up table > diff --git a/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c b/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c > index f27c949dbc24..a982e3d403fa 100644 > --- a/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c > +++ b/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c > @@ -66,7 +66,13 @@ STATIC CONST SGI_PRODUCT_ID_LOOKUP SgiProductIdLookup[] = { > RD_N2_PART_NUM, > RD_N2_CONF_ID, > 0 > - } > + }, > + { > + RdN2Cfg1, > + RD_N2_CFG1_PART_NUM, > + RD_N2_CFG1_CONF_ID, > + 0 > + }, > }; > > EFI_BOOT_MODE --------------2CC267838C39564DDE07AE3C Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit

Hi Pranav,

This patch looks good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar


On 19/05/2021 09:22 AM, Pranav Madhu wrote:
Add the RD-N2-Cfg1 platform identification values including the part
number and configuration number. This information will be used in
populating the SMBIOS tables.

Signed-off-by: Pranav Madhu <pranav.madhu@arm.com>
---
 Platform/ARM/SgiPkg/Include/SgiPlatform.h             | 7 ++++++-
 Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c | 8 +++++++-
 2 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/Platform/ARM/SgiPkg/Include/SgiPlatform.h b/Platform/ARM/SgiPkg/Include/SgiPlatform.h
index 4999c9870b49..dddb58832d73 100644
--- a/Platform/ARM/SgiPkg/Include/SgiPlatform.h
+++ b/Platform/ARM/SgiPkg/Include/SgiPlatform.h
@@ -39,6 +39,10 @@
 #define RD_V1_CONF_ID                             0x1
 #define RD_V1_MC_CONF_ID                          0x2
 
+// RD-N2-Cfg1 Platform Identification values
+#define RD_N2_CFG1_PART_NUM                       0x7B6
+#define RD_N2_CFG1_CONF_ID                        0x1
+
 // RD-N2 Platform Identification values
 #define RD_N2_PART_NUM                            0x7B7
 #define RD_N2_CONF_ID                             0x1
@@ -77,7 +81,8 @@ typedef enum {
   RdE1Edge,
   RdV1,
   RdV1Mc,
-  RdN2
+  RdN2,
+  RdN2Cfg1
 } ARM_RD_PRODUCT_ID;
 
 // Arm ProductId look-up table
diff --git a/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c b/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c
index f27c949dbc24..a982e3d403fa 100644
--- a/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c
+++ b/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c
@@ -66,7 +66,13 @@ STATIC CONST SGI_PRODUCT_ID_LOOKUP SgiProductIdLookup[] = {
     RD_N2_PART_NUM,
     RD_N2_CONF_ID,
     0
-  }
+  },
+  {
+    RdN2Cfg1,
+    RD_N2_CFG1_PART_NUM,
+    RD_N2_CFG1_CONF_ID,
+    0
+  },
 };
 
 EFI_BOOT_MODE

--------------2CC267838C39564DDE07AE3C--