public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Eric Dong <eric.dong@intel.com>,
	edk2-devel@ml01.01.org, michael.d.kinney@intel.com,
	liming.gao@intel.com
Subject: Re: [Patch 0/2] MdePkg DevicePathLib: Check buffer length before use.
Date: Wed, 12 Oct 2016 16:14:07 +0200	[thread overview]
Message-ID: <44d8c0c5-7387-e85f-0e62-b66cf2410485@redhat.com> (raw)
In-Reply-To: <1476275967-10888-1-git-send-email-eric.dong@intel.com>

On 10/12/16 14:39, Eric Dong wrote:
> In IsDevicePathValid API, code should validate the device path
> buffer not exceed the input MaxSize before reference the path
> info. This patched series add this check.
> 
> Eric Dong (2):
>   MdePkg UefiDevicePathLib: Validate buffer length before use buffer.
>   MdePkg UefiDevicePathLibDevicePathProtocol: Validate before use.
> 
>  .../UefiDevicePathLib/DevicePathUtilities.c        | 25 ++++++++++++++++------
>  .../UefiDevicePathLib.c                            | 24 +++++++++++++++------
>  2 files changed, 35 insertions(+), 14 deletions(-)
> 

Just a syntactic remark: you don't need the backslash (\) after the
trailing logical-and (&&) operators.

Thanks
Laszlo


  parent reply	other threads:[~2016-10-12 14:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-12 12:39 [Patch 0/2] MdePkg DevicePathLib: Check buffer length before use Eric Dong
2016-10-12 12:39 ` [Patch 1/2] MdePkg UefiDevicePathLib: Validate buffer length before use buffer Eric Dong
2016-10-12 12:39 ` [Patch 2/2] MdePkg UefiDevicePathLibDevicePathProtocol: Validate before use Eric Dong
2016-10-12 14:14 ` Laszlo Ersek [this message]
2016-10-14  1:36 ` [Patch 0/2] MdePkg DevicePathLib: Check buffer length " Ni, Ruiyu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44d8c0c5-7387-e85f-0e62-b66cf2410485@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox