[PATCH v1 1/1] OvmfPkg/CI: Revert SMP mode

[PATCH v1 1/1] OvmfPkg/CI: Revert SMP mode

[Michael Kubacki]

From: Michael Kubacki <michael.kubacki@microsoft.com>

This is causing excessive boot times in the VS2019 IA32/X64 Full
run to shell tasks (> 2 minutes) and blocking all edk2 CI.

This patch removes the change so it can be root caused separately
without blocking other patches unrelated to OVMF.

Reverts f92a9dce10281c103b04d6b38283e0ff1d677b91

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 OvmfPkg/PlatformCI/PlatformBuildLib.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/OvmfPkg/PlatformCI/PlatformBuildLib.py b/OvmfPkg/PlatformCI/PlatformBuildLib.py
index 1ff85fdc24bb..64fca48a7d1d 100644
--- a/OvmfPkg/PlatformCI/PlatformBuildLib.py
+++ b/OvmfPkg/PlatformCI/PlatformBuildLib.py
@@ -196,7 +196,6 @@ class PlatformBuilder( UefiBuilder, BuildSettingsManager):
         args  = "-debugcon stdio"                                           # write messages to stdio
         args += " -global isa-debugcon.iobase=0x402"                        # debug messages out thru virtual io port
         args += " -net none"                                                # turn off network
-        args += " -smp 4"
         args += f" -drive file=fat:rw:{VirtualDrive},format=raw,media=disk" # Mount disk with startup.nsh
 
         if (self.env.GetValue("QEMU_HEADLESS").upper() == "TRUE"):
-- 
2.40.0.windows.1

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/CI: Revert SMP mode

[Michael D Kinney]

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael Kubacki
> Sent: Friday, March 31, 2023 9:11 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Yao, Jiewen <jiewen.yao@intel.com>; Justen, Jordan L
> <jordan.l.justen@intel.com>; Gerd Hoffmann <kraxel@redhat.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: [edk2-devel] [PATCH v1 1/1] OvmfPkg/CI: Revert SMP mode
> 
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> This is causing excessive boot times in the VS2019 IA32/X64 Full
> run to shell tasks (> 2 minutes) and blocking all edk2 CI.
> 
> This patch removes the change so it can be root caused separately
> without blocking other patches unrelated to OVMF.
> 
> Reverts f92a9dce10281c103b04d6b38283e0ff1d677b91
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>  OvmfPkg/PlatformCI/PlatformBuildLib.py | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/OvmfPkg/PlatformCI/PlatformBuildLib.py b/OvmfPkg/PlatformCI/PlatformBuildLib.py
> index 1ff85fdc24bb..64fca48a7d1d 100644
> --- a/OvmfPkg/PlatformCI/PlatformBuildLib.py
> +++ b/OvmfPkg/PlatformCI/PlatformBuildLib.py
> @@ -196,7 +196,6 @@ class PlatformBuilder( UefiBuilder, BuildSettingsManager):
>          args  = "-debugcon stdio"                                           # write messages to stdio
>          args += " -global isa-debugcon.iobase=0x402"                        # debug messages out thru virtual io port
>          args += " -net none"                                                # turn off network
> -        args += " -smp 4"
>          args += f" -drive file=fat:rw:{VirtualDrive},format=raw,media=disk" # Mount disk with startup.nsh
> 
>          if (self.env.GetValue("QEMU_HEADLESS").upper() == "TRUE"):
> --
> 2.40.0.windows.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#102321): https://edk2.groups.io/g/devel/message/102321
> Mute This Topic: https://groups.io/mt/97976680/1643496
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [michael.d.kinney@intel.com]
> -=-=-=-=-=-=
> 

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/CI: Revert SMP mode

[Ard Biesheuvel]

On Fri, 31 Mar 2023 at 18:11, Michael Kubacki
<mikuback@linux.microsoft.com> wrote:
>
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> This is causing excessive boot times in the VS2019 IA32/X64 Full
> run to shell tasks (> 2 minutes) and blocking all edk2 CI.
>
> This patch removes the change so it can be root caused separately
> without blocking other patches unrelated to OVMF.
>
> Reverts f92a9dce10281c103b04d6b38283e0ff1d677b91
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>  OvmfPkg/PlatformCI/PlatformBuildLib.py | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/OvmfPkg/PlatformCI/PlatformBuildLib.py b/OvmfPkg/PlatformCI/PlatformBuildLib.py
> index 1ff85fdc24bb..64fca48a7d1d 100644
> --- a/OvmfPkg/PlatformCI/PlatformBuildLib.py
> +++ b/OvmfPkg/PlatformCI/PlatformBuildLib.py
> @@ -196,7 +196,6 @@ class PlatformBuilder( UefiBuilder, BuildSettingsManager):
>          args  = "-debugcon stdio"                                           # write messages to stdio
>          args += " -global isa-debugcon.iobase=0x402"                        # debug messages out thru virtual io port
>          args += " -net none"                                                # turn off network
> -        args += " -smp 4"
>          args += f" -drive file=fat:rw:{VirtualDrive},format=raw,media=disk" # Mount disk with startup.nsh
>
>          if (self.env.GetValue("QEMU_HEADLESS").upper() == "TRUE"):

Thanks for the fixed

Queued up as #4220

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/CI: Revert SMP mode

[Ni, Ray]

Anyone knows why the job status is "queued" for all the CI jobs?

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael
> D Kinney
> Sent: Saturday, April 1, 2023 12:13 AM
> To: devel@edk2.groups.io; mikuback@linux.microsoft.com
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Yao, Jiewen
> <jiewen.yao@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>;
> Gerd Hoffmann <kraxel@redhat.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/CI: Revert SMP mode
> 
> Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> 
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Michael Kubacki
> > Sent: Friday, March 31, 2023 9:11 AM
> > To: devel@edk2.groups.io
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Yao, Jiewen
> <jiewen.yao@intel.com>; Justen, Jordan L
> > <jordan.l.justen@intel.com>; Gerd Hoffmann <kraxel@redhat.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>
> > Subject: [edk2-devel] [PATCH v1 1/1] OvmfPkg/CI: Revert SMP mode
> >
> > From: Michael Kubacki <michael.kubacki@microsoft.com>
> >
> > This is causing excessive boot times in the VS2019 IA32/X64 Full
> > run to shell tasks (> 2 minutes) and blocking all edk2 CI.
> >
> > This patch removes the change so it can be root caused separately
> > without blocking other patches unrelated to OVMF.
> >
> > Reverts f92a9dce10281c103b04d6b38283e0ff1d677b91
> >
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> > ---
> >  OvmfPkg/PlatformCI/PlatformBuildLib.py | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/OvmfPkg/PlatformCI/PlatformBuildLib.py
> b/OvmfPkg/PlatformCI/PlatformBuildLib.py
> > index 1ff85fdc24bb..64fca48a7d1d 100644
> > --- a/OvmfPkg/PlatformCI/PlatformBuildLib.py
> > +++ b/OvmfPkg/PlatformCI/PlatformBuildLib.py
> > @@ -196,7 +196,6 @@ class PlatformBuilder( UefiBuilder,
> BuildSettingsManager):
> >          args  = "-debugcon stdio"                                           # write messages to
> stdio
> >          args += " -global isa-debugcon.iobase=0x402"                        # debug
> messages out thru virtual io port
> >          args += " -net none"                                                # turn off network
> > -        args += " -smp 4"
> >          args += f" -drive file=fat:rw:{VirtualDrive},format=raw,media=disk" #
> Mount disk with startup.nsh
> >
> >          if (self.env.GetValue("QEMU_HEADLESS").upper() == "TRUE"):
> > --
> > 2.40.0.windows.1
> >
> >
> >
> > -=-=-=-=-=-=
> > Groups.io Links: You receive all messages sent to this group.
> > View/Reply Online (#102321):
> https://edk2.groups.io/g/devel/message/102321
> > Mute This Topic: https://groups.io/mt/97976680/1643496
> > Group Owner: devel+owner@edk2.groups.io
> > Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [michael.d.kinney@intel.com]
> > -=-=-=-=-=-=
> >
> 
> 
> 
> 
> 

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/CI: Revert SMP mode

[Michael Kubacki]

There were a couple issues that lengthened the execution time of build 
agents and a number of changes were queued around the same time a few 
hours ago leading to longer queue times.

I know you're trying to reduce the UefiCpuPkg unit test time in your 
patch, that's currently causing UefiCpuPkg host test jobs to take over 
an hour.

Please share if you see anything else.

Thanks,
Michael

On 3/31/2023 12:59 PM, Ni, Ray wrote:
> 
> Anyone knows why the job status is "queued" for all the CI jobs?
> 
>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael
>> D Kinney
>> Sent: Saturday, April 1, 2023 12:13 AM
>> To: devel@edk2.groups.io; mikuback@linux.microsoft.com
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Yao, Jiewen
>> <jiewen.yao@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>;
>> Gerd Hoffmann <kraxel@redhat.com>; Kinney, Michael D
>> <michael.d.kinney@intel.com>
>> Subject: Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/CI: Revert SMP mode
>>
>> Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
>>
>>
>>> -----Original Message-----
>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
>> Michael Kubacki
>>> Sent: Friday, March 31, 2023 9:11 AM
>>> To: devel@edk2.groups.io
>>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Yao, Jiewen
>> <jiewen.yao@intel.com>; Justen, Jordan L
>>> <jordan.l.justen@intel.com>; Gerd Hoffmann <kraxel@redhat.com>;
>> Kinney, Michael D <michael.d.kinney@intel.com>
>>> Subject: [edk2-devel] [PATCH v1 1/1] OvmfPkg/CI: Revert SMP mode
>>>
>>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>>
>>> This is causing excessive boot times in the VS2019 IA32/X64 Full
>>> run to shell tasks (> 2 minutes) and blocking all edk2 CI.
>>>
>>> This patch removes the change so it can be root caused separately
>>> without blocking other patches unrelated to OVMF.
>>>
>>> Reverts f92a9dce10281c103b04d6b38283e0ff1d677b91
>>>
>>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>>> ---
>>>   OvmfPkg/PlatformCI/PlatformBuildLib.py | 1 -
>>>   1 file changed, 1 deletion(-)
>>>
>>> diff --git a/OvmfPkg/PlatformCI/PlatformBuildLib.py
>> b/OvmfPkg/PlatformCI/PlatformBuildLib.py
>>> index 1ff85fdc24bb..64fca48a7d1d 100644
>>> --- a/OvmfPkg/PlatformCI/PlatformBuildLib.py
>>> +++ b/OvmfPkg/PlatformCI/PlatformBuildLib.py
>>> @@ -196,7 +196,6 @@ class PlatformBuilder( UefiBuilder,
>> BuildSettingsManager):
>>>           args  = "-debugcon stdio"                                           # write messages to
>> stdio
>>>           args += " -global isa-debugcon.iobase=0x402"                        # debug
>> messages out thru virtual io port
>>>           args += " -net none"                                                # turn off network
>>> -        args += " -smp 4"
>>>           args += f" -drive file=fat:rw:{VirtualDrive},format=raw,media=disk" #
>> Mount disk with startup.nsh
>>>
>>>           if (self.env.GetValue("QEMU_HEADLESS").upper() == "TRUE"):
>>> --
>>> 2.40.0.windows.1
>>>
>>>
>>>
>>> -=-=-=-=-=-=
>>> Groups.io Links: You receive all messages sent to this group.
>>> View/Reply Online (#102321):
>> https://edk2.groups.io/g/devel/message/102321
>>> Mute This Topic: https://groups.io/mt/97976680/1643496
>>> Group Owner: devel+owner@edk2.groups.io
>>> Unsubscribe: https://edk2.groups.io/g/devel/unsub
>> [michael.d.kinney@intel.com]
>>> -=-=-=-=-=-=
>>>
>>
>>
>>
>>
>>
> 
> 
> 
> 
> 
>