From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61])
 by mx.groups.io with SMTP id smtpd.web12.14114.1595516134021877859
 for <devel@edk2.groups.io>;
 Thu, 23 Jul 2020 07:55:34 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QHLJ4TfJ;
 spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1595516133;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=KJve14/M80azJWZsryTm9R5cT8ZO32JF0Xd5A5+jj2Q=;
	b=QHLJ4TfJRrwE4BZGCvqC43s2lGF2Y1iVbJBxw4UmfxpNMRinr7xlMA8e4yzc1gNk0ohqPC
	c/4JnerQOLboxnpfeK3ynqywPmRibzJklBtSMnm1ZllT6RErUEY2lYkQDjODTcc2bHeTOQ
	0Pjn1OavOu1QVogmpUIBsAdUAPQNh/o=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-450-DWAPMTckPMu6ahkffA_xxA-1; Thu, 23 Jul 2020 10:55:27 -0400
X-MC-Unique: DWAPMTckPMu6ahkffA_xxA-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D0B80800486;
	Thu, 23 Jul 2020 14:55:25 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-52.ams2.redhat.com [10.36.114.52])
	by smtp.corp.redhat.com (Postfix) with ESMTP id D93BA8BEE2;
	Thu, 23 Jul 2020 14:55:24 +0000 (UTC)
Subject: Re: [PATCH v2 1/2] ArmVirtPkg: enable HttpDynamiCommand
To: Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>,
 devel@edk2.groups.io
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>, Leif Lindholm <leif@nuviainc.com>
References: <20200722205434.4348-1-vladimir.olovyannikov@broadcom.com>
 <20200722205434.4348-2-vladimir.olovyannikov@broadcom.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <44ecf699-0ec6-22f0-063b-5578d0cf01bb@redhat.com>
Date: Thu, 23 Jul 2020 16:55:24 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Firefox/52.0 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20200722205434.4348-2-vladimir.olovyannikov@broadcom.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

On 07/22/20 22:54, Vladimir Olovyannikov wrote:
> Enable HttpDynamicCommand (http Shell command)
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2857
> 
> Signed-off-by: Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>
> ---
>  ArmVirtPkg/ArmVirt.dsc.inc           | 4 ++++
>  ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 1 +
>  ArmVirtPkg/ArmVirtXen.fdf            | 1 +
>  3 files changed, 6 insertions(+)
> 
> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
> index cf44fc73890b..f39f7e903ff9 100644
> --- a/ArmVirtPkg/ArmVirt.dsc.inc
> +++ b/ArmVirtPkg/ArmVirt.dsc.inc
> @@ -377,6 +377,10 @@ [Components.common]
>      <PcdsFixedAtBuild>
>        gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
>    }
> +  ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.inf {
> +    <PcdsFixedAtBuild>
> +      gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
> +  }
>    OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf {
>      <PcdsFixedAtBuild>
>        gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
> diff --git a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
> index a2f4bd62c846..6eade7e50ff7 100644
> --- a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
> +++ b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
> @@ -103,6 +103,7 @@ [FV.FvMain]
>    #
>    INF ShellPkg/Application/Shell/Shell.inf
>    INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
> +  INF ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.inf
>    INF OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf
>  
>    #
> diff --git a/ArmVirtPkg/ArmVirtXen.fdf b/ArmVirtPkg/ArmVirtXen.fdf
> index f708878f4965..8fbbc2313aff 100644
> --- a/ArmVirtPkg/ArmVirtXen.fdf
> +++ b/ArmVirtPkg/ArmVirtXen.fdf
> @@ -182,6 +182,7 @@ [FV.FvMain]
>    #
>    INF ShellPkg/Application/Shell/Shell.inf
>    INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
> +  INF ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.inf
>    INF OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf
>  
>    #
> 

Tested-by: Laszlo Ersek <lersek@redhat.com>