Re: [edk2-devel] [edk2-stable202402][Patch 1/1] MdePkg: Add SynchronizationLib to MdeLibs.dsc.inc

["Leif Lindholm" <quic_llindhol@quicinc.com>]

On 2024-02-06 18:38, Michael D Kinney wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4675
> 
> Add library mapping for the SynchrnizationLib to MdeLibs.dsc.inc

Typo: SynchrnizationLib

> to resolve build failures in the FmpDevicePkg and NetworkPkg for
> missing library mapping.
> 
> The following email details why this was missed by EDK II CI
> 
> * https://edk2.groups.io/g/devel/message/115185
> 
> Local builds of all packages that use -D CONTINUOUS_INTEGRATION
> were performed to verify that this change resolves the missing
> library mapping.

Hmm...
I agree with this as a patch for 202402
Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>

But I think this exposes a serious antipattern.
Have a look at the SecurityPkg.dsc for CONTINUOUS_INTEGRATION.
The only reason that doesn't break is because SynchronizationLib is
explicitly imported there (which we should really drop after this
addition, but not before the stable tag).

Meanwhile, that same exact CONTINUOUS_INTEGRATION stanza is duplicated 
five times in that single file. There must be a better way of doing
this, after the stable tag.

/
     Leif

> Cc: Andrew Fish <afish@apple.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Wei6 Xu <wei6.xu@intel.com>
> Cc: Saloni Kasbekar <saloni.kasbekar@intel.com>
> Cc: Zachary Clark-williams <zachary.clark-williams@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>   MdePkg/MdeLibs.dsc.inc | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/MdePkg/MdeLibs.dsc.inc b/MdePkg/MdeLibs.dsc.inc
> index deb35c1a185c..d782dbf4ffc6 100644
> --- a/MdePkg/MdeLibs.dsc.inc
> +++ b/MdePkg/MdeLibs.dsc.inc
> @@ -17,3 +17,4 @@ [LibraryClasses]
>     CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf
>     SmmCpuRendezvousLib|MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.inf
>     SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
> +  SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115234): https://edk2.groups.io/g/devel/message/115234
Mute This Topic: https://groups.io/mt/104203786/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-