From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E1D6B7803E6 for ; Wed, 7 Feb 2024 09:37:27 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=s44Ojoh1ODFlSOG9SMSl0+wzkOeOOIAXjMvXc9Tc0ZE=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:CC:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1707298646; v=1; b=oXxO1HPxMvjq1c7U3c9zycvVf2ki+P8fS3FTin31+d+DRoRvtsD9ktd0STMrfPhXNgozRqc6 E72jq2NAX9PDlkzU68o5KRW+3zRPKBt0i4uCKYnvrn24en2gkGPEzOvmBhh80jsSak5jf0JZCgF GgnZWagCVuSBUNr+u+lJPPdg= X-Received: by 127.0.0.2 with SMTP id BvByYY7687511xXRLT4IouLK; Wed, 07 Feb 2024 01:37:26 -0800 X-Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web11.16775.1707298645702575616 for ; Wed, 07 Feb 2024 01:37:25 -0800 X-Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 4176cYOj022976; Wed, 7 Feb 2024 09:37:14 GMT X-Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3w3x41s1rj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 07 Feb 2024 09:37:13 +0000 (GMT) X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 4179bDfo018505 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 7 Feb 2024 09:37:13 GMT X-Received: from [10.111.132.177] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Wed, 7 Feb 2024 01:37:09 -0800 Message-ID: <44ffdbe2-0f09-4a2e-8d24-7a38ee075226@quicinc.com> Date: Wed, 7 Feb 2024 10:37:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [edk2-stable202402][Patch 1/1] MdePkg: Add SynchronizationLib to MdeLibs.dsc.inc To: Michael D Kinney , CC: Andrew Fish , Liming Gao , Zhiguang Liu , Wei6 Xu , Saloni Kasbekar , Zachary Clark-williams References: <20240206183825.1020-1-michael.d.kinney@intel.com> From: "Leif Lindholm" In-Reply-To: <20240206183825.1020-1-michael.d.kinney@intel.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-ORIG-GUID: hJxzYDR05_Xfdf7X0yyPsXq-RykwKaXn X-Proofpoint-GUID: hJxzYDR05_Xfdf7X0yyPsXq-RykwKaXn Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: O9aPmc9G6YslogEiLveroVOcx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=oXxO1HPx; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 2024-02-06 18:38, Michael D Kinney wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4675 >=20 > Add library mapping for the SynchrnizationLib to MdeLibs.dsc.inc Typo: SynchrnizationLib > to resolve build failures in the FmpDevicePkg and NetworkPkg for > missing library mapping. >=20 > The following email details why this was missed by EDK II CI >=20 > * https://edk2.groups.io/g/devel/message/115185 >=20 > Local builds of all packages that use -D CONTINUOUS_INTEGRATION > were performed to verify that this change resolves the missing > library mapping. Hmm... I agree with this as a patch for 202402 Reviewed-by: Leif Lindholm But I think this exposes a serious antipattern. Have a look at the SecurityPkg.dsc for CONTINUOUS_INTEGRATION. The only reason that doesn't break is because SynchronizationLib is explicitly imported there (which we should really drop after this addition, but not before the stable tag). Meanwhile, that same exact CONTINUOUS_INTEGRATION stanza is duplicated=20 five times in that single file. There must be a better way of doing this, after the stable tag. / Leif > Cc: Andrew Fish > Cc: Leif Lindholm > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Wei6 Xu > Cc: Saloni Kasbekar > Cc: Zachary Clark-williams > Signed-off-by: Michael D Kinney > --- > MdePkg/MdeLibs.dsc.inc | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/MdePkg/MdeLibs.dsc.inc b/MdePkg/MdeLibs.dsc.inc > index deb35c1a185c..d782dbf4ffc6 100644 > --- a/MdePkg/MdeLibs.dsc.inc > +++ b/MdePkg/MdeLibs.dsc.inc > @@ -17,3 +17,4 @@ [LibraryClasses] > CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf > SmmCpuRendezvousLib|MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRend= ezvousLibNull.inf > SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf > + SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchroni= zationLib.inf -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115234): https://edk2.groups.io/g/devel/message/115234 Mute This Topic: https://groups.io/mt/104203786/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-