[edk2-devel] [edk2-stable202402][Patch 1/1] MdePkg: Add SynchronizationLib to MdeLibs.dsc.inc

[edk2-devel] [edk2-stable202402][Patch 1/1] MdePkg: Add SynchronizationLib to MdeLibs.dsc.inc

[Michael D Kinney]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4675

Add library mapping for the SynchrnizationLib to MdeLibs.dsc.inc
to resolve build failures in the FmpDevicePkg and NetworkPkg for
missing library mapping.

The following email details why this was missed by EDK II CI

* https://edk2.groups.io/g/devel/message/115185

Local builds of all packages that use -D CONTINUOUS_INTEGRATION
were performed to verify that this change resolves the missing
library mapping.

Cc: Andrew Fish <afish@apple.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Wei6 Xu <wei6.xu@intel.com>
Cc: Saloni Kasbekar <saloni.kasbekar@intel.com>
Cc: Zachary Clark-williams <zachary.clark-williams@intel.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 MdePkg/MdeLibs.dsc.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MdePkg/MdeLibs.dsc.inc b/MdePkg/MdeLibs.dsc.inc
index deb35c1a185c..d782dbf4ffc6 100644
--- a/MdePkg/MdeLibs.dsc.inc
+++ b/MdePkg/MdeLibs.dsc.inc
@@ -17,3 +17,4 @@ [LibraryClasses]
   CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf
   SmmCpuRendezvousLib|MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.inf
   SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
+  SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf
-- 
2.40.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115188): https://edk2.groups.io/g/devel/message/115188
Mute This Topic: https://groups.io/mt/104203786/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-stable202402][Patch 1/1] MdePkg: Add SynchronizationLib to MdeLibs.dsc.inc

[Michael D Kinney]

PR: https://github.com/tianocore/edk2/pull/5353

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael
> D Kinney
> Sent: Tuesday, February 6, 2024 10:38 AM
> To: devel@edk2.groups.io
> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm
> <quic_llindhol@quicinc.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Liu, Zhiguang <zhiguang.liu@intel.com>; Xu, Wei6 <wei6.xu@intel.com>;
> Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, Zachary
> <zachary.clark-williams@intel.com>
> Subject: [edk2-devel] [edk2-stable202402][Patch 1/1] MdePkg: Add
> SynchronizationLib to MdeLibs.dsc.inc
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4675
> 
> Add library mapping for the SynchrnizationLib to MdeLibs.dsc.inc
> to resolve build failures in the FmpDevicePkg and NetworkPkg for
> missing library mapping.
> 
> The following email details why this was missed by EDK II CI
> 
> * https://edk2.groups.io/g/devel/message/115185
> 
> Local builds of all packages that use -D CONTINUOUS_INTEGRATION
> were performed to verify that this change resolves the missing
> library mapping.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Wei6 Xu <wei6.xu@intel.com>
> Cc: Saloni Kasbekar <saloni.kasbekar@intel.com>
> Cc: Zachary Clark-williams <zachary.clark-williams@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  MdePkg/MdeLibs.dsc.inc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MdePkg/MdeLibs.dsc.inc b/MdePkg/MdeLibs.dsc.inc
> index deb35c1a185c..d782dbf4ffc6 100644
> --- a/MdePkg/MdeLibs.dsc.inc
> +++ b/MdePkg/MdeLibs.dsc.inc
> @@ -17,3 +17,4 @@ [LibraryClasses]
>    CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf
> 
> SmmCpuRendezvousLib|MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendez
> vousLibNull.inf
>    SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
> +
> SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchroniz
> ationLib.inf
> --
> 2.40.1.windows.1
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115189): https://edk2.groups.io/g/devel/message/115189
Mute This Topic: https://groups.io/mt/104203786/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-stable202402][Patch 1/1] MdePkg: Add SynchronizationLib to MdeLibs.dsc.inc

[Leif Lindholm]

On 2024-02-06 18:38, Michael D Kinney wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4675
> 
> Add library mapping for the SynchrnizationLib to MdeLibs.dsc.inc

Typo: SynchrnizationLib

> to resolve build failures in the FmpDevicePkg and NetworkPkg for
> missing library mapping.
> 
> The following email details why this was missed by EDK II CI
> 
> * https://edk2.groups.io/g/devel/message/115185
> 
> Local builds of all packages that use -D CONTINUOUS_INTEGRATION
> were performed to verify that this change resolves the missing
> library mapping.

Hmm...
I agree with this as a patch for 202402
Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>

But I think this exposes a serious antipattern.
Have a look at the SecurityPkg.dsc for CONTINUOUS_INTEGRATION.
The only reason that doesn't break is because SynchronizationLib is
explicitly imported there (which we should really drop after this
addition, but not before the stable tag).

Meanwhile, that same exact CONTINUOUS_INTEGRATION stanza is duplicated 
five times in that single file. There must be a better way of doing
this, after the stable tag.

/
     Leif

> Cc: Andrew Fish <afish@apple.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Wei6 Xu <wei6.xu@intel.com>
> Cc: Saloni Kasbekar <saloni.kasbekar@intel.com>
> Cc: Zachary Clark-williams <zachary.clark-williams@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>   MdePkg/MdeLibs.dsc.inc | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/MdePkg/MdeLibs.dsc.inc b/MdePkg/MdeLibs.dsc.inc
> index deb35c1a185c..d782dbf4ffc6 100644
> --- a/MdePkg/MdeLibs.dsc.inc
> +++ b/MdePkg/MdeLibs.dsc.inc
> @@ -17,3 +17,4 @@ [LibraryClasses]
>     CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf
>     SmmCpuRendezvousLib|MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.inf
>     SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
> +  SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115234): https://edk2.groups.io/g/devel/message/115234
Mute This Topic: https://groups.io/mt/104203786/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-stable202402][Patch 1/1] MdePkg: Add SynchronizationLib to MdeLibs.dsc.inc

[Michael D Kinney]

Hi Leif,

Merged: https://github.com/tianocore/edk2/pull/5353

Thanks for the review/approval.  

A few additional topics:

1) For libraries listed in MdeLibs.dsc.inc, if a package DSC provides
   the same mapping, then it is duplicate content that can be cleaned
   up. Would be great to have some tools to help identify these types
   of duplicate mappings and reduce the size of DSC files overall.
2) If we want to reduce DSC file size and duplicate information, we 
   could expand use of MdeLib.dsc.inc concept across all packages to
   provide mappings of all libraries for which there is only a single
   implementation (or preferred default).
3) A discussion/review of the CONTINUOUS_INTEGRATION define feature
   will occur in a future TianoCore Tools/CI meeting to determine if
   the coverage can be improved and see if the usage of that define
   can be simplified in the packages that depend on it to reduce CI
   execution times.

Thanks,

Mike


> -----Original Message-----
> From: Leif Lindholm <quic_llindhol@quicinc.com>
> Sent: Wednesday, February 7, 2024 1:37 AM
> To: Kinney, Michael D <michael.d.kinney@intel.com>;
> devel@edk2.groups.io
> Cc: Andrew Fish <afish@apple.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Xu,
> Wei6 <wei6.xu@intel.com>; Kasbekar, Saloni <saloni.kasbekar@intel.com>;
> Clark-williams, Zachary <zachary.clark-williams@intel.com>
> Subject: Re: [edk2-stable202402][Patch 1/1] MdePkg: Add
> SynchronizationLib to MdeLibs.dsc.inc
> 
> On 2024-02-06 18:38, Michael D Kinney wrote:
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4675
> >
> > Add library mapping for the SynchrnizationLib to MdeLibs.dsc.inc
> 
> Typo: SynchrnizationLib
> 
> > to resolve build failures in the FmpDevicePkg and NetworkPkg for
> > missing library mapping.
> >
> > The following email details why this was missed by EDK II CI
> >
> > * https://edk2.groups.io/g/devel/message/115185
> >
> > Local builds of all packages that use -D CONTINUOUS_INTEGRATION
> > were performed to verify that this change resolves the missing
> > library mapping.
> 
> Hmm...
> I agree with this as a patch for 202402
> Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
> 
> But I think this exposes a serious antipattern.
> Have a look at the SecurityPkg.dsc for CONTINUOUS_INTEGRATION.
> The only reason that doesn't break is because SynchronizationLib is
> explicitly imported there (which we should really drop after this
> addition, but not before the stable tag).
> 
> Meanwhile, that same exact CONTINUOUS_INTEGRATION stanza is duplicated
> five times in that single file. There must be a better way of doing
> this, after the stable tag.
> 
> /
>      Leif
> 
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > Cc: Wei6 Xu <wei6.xu@intel.com>
> > Cc: Saloni Kasbekar <saloni.kasbekar@intel.com>
> > Cc: Zachary Clark-williams <zachary.clark-williams@intel.com>
> > Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> > ---
> >   MdePkg/MdeLibs.dsc.inc | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/MdePkg/MdeLibs.dsc.inc b/MdePkg/MdeLibs.dsc.inc
> > index deb35c1a185c..d782dbf4ffc6 100644
> > --- a/MdePkg/MdeLibs.dsc.inc
> > +++ b/MdePkg/MdeLibs.dsc.inc
> > @@ -17,3 +17,4 @@ [LibraryClasses]
> >     CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf
> >
> SmmCpuRendezvousLib|MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendez
> vousLibNull.inf
> >     SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
> > +
> SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchroniz
> ationLib.inf



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115244): https://edk2.groups.io/g/devel/message/115244
Mute This Topic: https://groups.io/mt/104203786/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-