Re: [PATCH 1/1] ArmPkg: Fix several issues in OemMiscLib

["Rebecca Cran" <rebecca@nuviainc.com>]

On 2/20/21 1:45 PM, Leif Lindholm wrote:
> On Thu, Feb 18, 2021 at 22:08:00 -0700, Rebecca Cran wrote:
>> Update OemMiscLib with the following changes:
>>
>> o Fixed ordering of return type and EFIAPI specifier.
>> o Renamed 'Offset' parameter in OemUpdateSmbiosInfo to 'Field'.
>> o Renamed OemGetProcessorMaxSockets to OemGetMaxProcessors.
>> o Renamed OemIsSocketPresent to OemIsProcessorPresent.
>> o Updated OemGetChassisType to return MISC_CHASSIS_TYPE instead of
>>    EFI_STATUS, which matches other OemMiscLib functions.
> 
> On the whole, this looks fine, but I see three separate patches here:
> - EFIAPI changes
> - Various non-functional renaming
> - Refactoring of OemGetChassisType
> 
> Could you do that rework and submit a v2 please?

I realized after I'd sent it that the EFIAPI changes would be better in 
a separate patch. I've just sent a v2 series with the three patches.

-- 
Rebecca Cran