From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) by mx.groups.io with SMTP id smtpd.web09.16462.1613878257455589306 for ; Sat, 20 Feb 2021 19:30:57 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=CS8Y6RhJ; spf=pass (domain: nuviainc.com, ip: 209.85.166.53, mailfrom: rebecca@nuviainc.com) Received: by mail-io1-f53.google.com with SMTP id a7so9819588iok.12 for ; Sat, 20 Feb 2021 19:30:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jFnA8j5biE2XLc0igOeJt+OdWxF7OpVugIvxVh2FVko=; b=CS8Y6RhJTeWFyAoP5BxzA0YHkFXi2Xy4xT2eC2JpkZ61qejO7Ix5KwKtZMbecutzwV CTikipU7HJGicHiozQPiPBwslRl+9dIcZUCNU2Ze2AuLYMn5MuWjr+qJtJ879j6YXAWU y5J+u8AeUaKMfPAOwAPzAki4MSMqOw0iNS9XhXqp3SHwC1IS7aRWiHyNISQEK9DwR7LL FbBpKE5jrxTptIElitg4cEU2JQE6AN62XuOUeFD6WgL5N3Ql8C9CrdPoDre4sWokAfq/ 3iCyYfMyNIuPBDLXFto6VhEXNrV3MdQHqxZ6zJ71C+ppsnj1Xu9CVuzYJ79Al92NgKfZ kj0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jFnA8j5biE2XLc0igOeJt+OdWxF7OpVugIvxVh2FVko=; b=qRroBOKU3AigOQC7DUTbeKDoEOziKGVYrYtWk/wjAW6queg5smt40jdwZwOg9lb/MW tf5uSaRkuiLZKxD21WMwibvcRgJ0W8NggVreJFRx9chJk/9PpIdrPwr5E7/SyrjbJLtz uwysmxXIloEzo4gQhV79/3NWVKapuGvDqBAFo6oV3P2wAeVqMwbRXn9tkUSOwD43emV6 r4hVIIeFuFKlcu2d2qfHVvD+PmL0ECjHcr8TK6/9BlF3miLvtFJDYFXmc1IK8MRpWTtW AfI9Mz15W5uxLPkF4/anTMBxio4oFxMgvStWK39tHTS4W1ueZfBLcHNXEG9MwEtO2stV ItFw== X-Gm-Message-State: AOAM532xnhbiyTJD1BnW+1eCgKdiFzKeEPw7C1/BlyUg8w78h3SevxUH Azx/TF4OFF3zpmDCGHJcnTWDUA== X-Google-Smtp-Source: ABdhPJw+o+k6JIu8rSsNuZPCcWa04m2p0MfB0cgxdog1/Kks3AAFjAZn3KUIg2J0fxM/dO2v6I3lCw== X-Received: by 2002:a05:6638:164f:: with SMTP id a15mr16926168jat.75.1613878254726; Sat, 20 Feb 2021 19:30:54 -0800 (PST) Return-Path: Received: from [10.0.10.142] (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id r12sm10758580ioo.53.2021.02.20.19.30.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 20 Feb 2021 19:30:54 -0800 (PST) Subject: Re: [PATCH 1/1] ArmPkg: Fix several issues in OemMiscLib To: Leif Lindholm Cc: devel@edk2.groups.io, Ard Biesheuvel References: <20210219050800.5238-1-rebecca@nuviainc.com> <20210220204555.GK1664@vanye> From: "Rebecca Cran" Message-ID: <45125fd5-2587-c377-feec-e2dcaaf435a0@nuviainc.com> Date: Sat, 20 Feb 2021 20:30:52 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210220204555.GK1664@vanye> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 2/20/21 1:45 PM, Leif Lindholm wrote: > On Thu, Feb 18, 2021 at 22:08:00 -0700, Rebecca Cran wrote: >> Update OemMiscLib with the following changes: >> >> o Fixed ordering of return type and EFIAPI specifier. >> o Renamed 'Offset' parameter in OemUpdateSmbiosInfo to 'Field'. >> o Renamed OemGetProcessorMaxSockets to OemGetMaxProcessors. >> o Renamed OemIsSocketPresent to OemIsProcessorPresent. >> o Updated OemGetChassisType to return MISC_CHASSIS_TYPE instead of >> EFI_STATUS, which matches other OemMiscLib functions. > > On the whole, this looks fine, but I see three separate patches here: > - EFIAPI changes > - Various non-functional renaming > - Refactoring of OemGetChassisType > > Could you do that rework and submit a v2 please? I realized after I'd sent it that the EFIAPI changes would be better in a separate patch. I've just sent a v2 series with the three patches. -- Rebecca Cran