public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: Oliver Steffen <osteffen@redhat.com>
Cc: devel@edk2.groups.io, Abner Chang <abner.chang@amd.com>,
	Alexei Fedorov <Alexei.Fedorov@arm.com>,
	Andrew Fish <afish@apple.com>,
	Anthony Perard <anthony.perard@citrix.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Bob Feng <bob.c.feng@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Chasel Chiu <chasel.chiu@intel.com>,
	Daniel Schaefer <git@danielschaefer.me>,
	Erdem Aktas <erdemaktas@google.com>,
	Eric Dong <eric.dong@intel.com>,
	Gerd Hoffmann <kraxel@redhat.com>, Gua Guo <gua.guo@intel.com>,
	Guo Dong <guo.dong@intel.com>,
	Guomin Jiang <guomin.jiang@intel.com>,
	Hao A Wu <hao.a.wu@intel.com>, Igor Kulchytskyy <igork@ami.com>,
	James Bottomley <jejb@linux.ibm.com>,
	James Lu <james.lu@intel.com>,
	Jian J Wang <jian.j.wang@intel.com>,
	Jiaxin Wu <jiaxin.wu@intel.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Julien Grall <julien@xen.org>,
	Leif Lindholm <quic_llindhol@quicinc.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Maciej Rabeda <maciej.rabeda@linux.intel.com>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Min Xu <min.m.xu@intel.com>,
	Nate DeSimone <nathaniel.l.desimone@intel.com>,
	Nickle Wang <nicklew@nvidia.com>,
	Peter Grehan <grehan@freebsd.org>,
	Pierre Gondois <pierre.gondois@arm.com>,
	Rahul Kumar <rahul1.kumar@intel.com>, Ray Ni <ray.ni@intel.com>,
	Rebecca Cran <rebecca@bsdio.com>,
	Sami Mujawar <sami.mujawar@arm.com>,
	Sean Brogan <sean.brogan@microsoft.com>,
	Sean Rhodes <sean@starlabs.systems>,
	Sebastien Boeuf <sebastien.boeuf@intel.com>,
	Siyuan Fu <siyuan.fu@intel.com>, Star Zeng <star.zeng@intel.com>,
	Sunil V L <sunilvl@ventanamicro.com>,
	Supreeth Venkatesh <supreeth.venkatesh@arm.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Wei6 Xu <wei6.xu@intel.com>, Xiaoyu Lu <xiaoyu1.lu@intel.com>,
	Yuwei Chen <yuwei.chen@intel.com>,
	Zhichao Gao <zhichao.gao@intel.com>,
	Zhiguang Liu <zhiguang.liu@intel.com>,
	Pawel Polawski <ppolawsk@redhat.com>,
	Chris Fernald <chris.fernald@outlook.com>
Subject: Re: [PATCH v7 1/6] CI: make Python version configurable
Date: Wed, 30 Nov 2022 13:26:39 -0500	[thread overview]
Message-ID: <4515964c-130e-fd9c-5589-00b05239db59@linux.microsoft.com> (raw)
In-Reply-To: <CA+bRGFphudydAfzzsfrWOn9Nwz793taf29AMEU98DL9=CAOtxQ@mail.gmail.com>

I'm fine for it to come in a separate patch if necessary. If you end up 
deferring it, maybe file a brief BZ to track it.

Thanks,
Michael

On 11/30/2022 12:52 PM, Oliver Steffen wrote:
> Hi Michael
> 
> On Wed, Nov 30, 2022 at 3:13 PM Michael Kubacki
> <mikuback@linux.microsoft.com> wrote:
>>
>> This distributes the Python version (as a default value) across several
>> files - ">=3.10.6". For maintainability, we'd like to manage versioning
>> more centrally to reduce likelihood of misses on updates.
>>
>> You could potentially adjust it such that the default does not specify a
>> version, put the Python version in a template and call that when needed,
>> etc.
> Yes, it sounds like a good idea.
> 
> Can we work on this in a separate patch set?
> I am experimenting with this now, but I fear this might delay
> these patches too much and go for a minimal version for now.
> Maybe we have a chance to merge something before the CI stops
> working tomorrow.
> 
> Thanks,
>    Oliver
> 
>> Thanks,
>> Michael
>>
>> On 11/29/2022 2:26 PM, Oliver Steffen wrote:
>>> Add a new parameter "usePythonVersion" to the CI job templates.
>>> This makes it possible to specify the version of Python to use.
>>> The default value is ">=3.10.6".
>>> If '' is specified, Python will not be downloaded at runtime and
>>> the one provided by the VM/container image will be used.
>>>
>>> Signed-off-by: Oliver Steffen <osteffen@redhat.com>
>>> ---
>>>    .azurepipelines/templates/platform-build-run-steps.yml | 6 +++++-
>>>    .azurepipelines/templates/pr-gate-build-job.yml        | 2 ++
>>>    .azurepipelines/templates/pr-gate-steps.yml            | 6 ++++--
>>>    3 files changed, 11 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/.azurepipelines/templates/platform-build-run-steps.yml
>>> b/.azurepipelines/templates/platform-build-run-steps.yml
>>> index 40a31a509fc5..6c9189a20fde 100644
>>> --- a/.azurepipelines/templates/platform-build-run-steps.yml
>>> +++ b/.azurepipelines/templates/platform-build-run-steps.yml
>>> @@ -34,6 +34,9 @@ parameters:
>>>    - name: extra_install_step
>>>      type: stepList
>>>      default: []
>>> +- name: usePythonVersion
>>> +  type: string
>>> +  default: ">=3.10.6"
>>>
>>>    steps:
>>>    - checkout: self
>>> @@ -42,8 +45,9 @@ steps:
>>>
>>>    - task: UsePythonVersion@0
>>>      inputs:
>>> -    versionSpec: ">=3.10.6"
>>> +    versionSpec: ${{ parameters.usePythonVersion }}
>>>        architecture: "x64"
>>> +  condition: ne('${{ parameters.usePythonVersion }}', '')
>>>
>>>    - script: pip install -r pip-requirements.txt --upgrade
>>>      displayName: 'Install/Upgrade pip modules'
>>> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
>>> b/.azurepipelines/templates/pr-gate-build-job.yml
>>> index 7f88b41dc8d3..d0a6ccd10700 100644
>>> --- a/.azurepipelines/templates/pr-gate-build-job.yml
>>> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
>>> @@ -12,6 +12,7 @@ parameters:
>>>      tool_chain_tag: ''
>>>      vm_image: ''
>>>      arch_list: ''
>>> +  usePythonVersion: '>=3.10.6'
>>>
>>>    # Build step
>>>    jobs:
>>> @@ -77,3 +78,4 @@ jobs:
>>>          build_pkgs: $(Build.Pkgs)
>>>          build_targets: $(Build.Targets)
>>>          build_archs: ${{ parameters.arch_list }}
>>> +      usePythonVersion: ${{ parameters.usePythonVersion }}
>>> diff --git a/.azurepipelines/templates/pr-gate-steps.yml
>>> b/.azurepipelines/templates/pr-gate-steps.yml
>>> index cb431e53fcd1..bf6574b33692 100644
>>> --- a/.azurepipelines/templates/pr-gate-steps.yml
>>> +++ b/.azurepipelines/templates/pr-gate-steps.yml
>>> @@ -12,6 +12,7 @@ parameters:
>>>      build_pkgs: ''
>>>      build_targets: ''
>>>      build_archs: ''
>>> +  usePythonVersion: '>=3.10.6'
>>>
>>>    steps:
>>>    - checkout: self
>>> @@ -20,8 +21,9 @@ steps:
>>>
>>>    - task: UsePythonVersion@0
>>>      inputs:
>>> -    versionSpec: '>=3.10.6'
>>> -    architecture: 'x64'
>>> +    versionSpec: ${{ parameters.usePythonVersion }}
>>> +    architecture: "x64"
>>> +  condition: ne('${{ parameters.usePythonVersion }}', '')
>>>
>>>    - script: pip install -r pip-requirements.txt --upgrade
>>>      displayName: 'Install/Upgrade pip modules'
>>

  reply	other threads:[~2022-11-30 18:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20221129192625.643896-1-osteffen@redhat.com>
2022-11-29 19:26 ` [PATCH v7 1/6] CI: make Python version configurable Oliver Steffen
2022-11-30 14:12   ` Michael Kubacki
2022-11-30 17:52     ` Oliver Steffen
2022-11-30 18:26       ` Michael Kubacki [this message]
2022-11-29 19:26 ` [PATCH v7 2/6] CI: add ~/.local/bin to PATH (Linux only) Oliver Steffen
2022-11-29 19:26 ` [PATCH v7 3/6] CI: Allow running in a container Oliver Steffen
2022-11-29 19:26 ` [PATCH v7 4/6] CI: Use Fedora 35 container (Linux only) Oliver Steffen
2022-11-29 19:26 ` [PATCH v7 5/6] BaseTools: Remove ext. gcc dependencies " Oliver Steffen
2022-11-29 19:26 ` [PATCH v7 6/6] CI: use latest vm_image " Oliver Steffen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4515964c-130e-fd9c-5589-00b05239db59@linux.microsoft.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox